rspec stuff etc

Author: spompea-cfa

app/controllers/diy/diy_notification_preference_controller.rb

@@ -6,7 +6,8 @@ def edit
 
     def update
       diy_intake = current_diy_intake
-      @form = DiyNotificationPreferenceForm.new(diy_intake)
+      form_params = params.fetch(:diy_notification_preference_form, {}).permit(*DiyNotificationPreferenceForm.attribute_names)
+      @form = DiyNotificationPreferenceForm.new(diy_intake, form_params)
       if @form.valid?
         @form.save
         session[:diy_intake_id] = diy_intake.id
@@ -15,15 +16,5 @@ def update
         render :edit
       end
     end
-
-    private
-
-    def tracking_data
-      @form.attributes_for(:diy_intake)
-    end
-
-    def illustration_path
-      "contact-preference.svg"
-    end
   end
 end

app/forms/diy_notification_preference_form.rb

@@ -9,7 +9,7 @@ def initialize(diy_intake = nil, params = {})
   end
 
   def save
-    diy_intake.update(attributes_for(:diy_intake))
+    diy_intake.update!(attributes_for(:diy_intake))
   end
 
   def self.existing_attributes(diy_intake)

app/views/diy/diy_notification_preference/edit.html.erb

@@ -28,6 +28,10 @@
           <%= f.cfa_checkbox(:sms_notification_opt_in, t("views.questions.notification_preference.options.sms_notification_opt_in"), options: { checked_value: "yes", unchecked_value: "no", "data-follow-up": "#sms-opt-in" }) %>
         </div>
 
+        <!-- TODO add reveal widget -->
+        <%= t('views.questions.notification_preference.reveal_header') %>
+        <%= t('views.questions.notification_preference.below_reveal') %>
+
         <p class="text--small spacing-above-25">
           <%= t("views.questions.notification_preference.note_html", terms_url: sms_terms_url, privacy_url: privacy_url) %>
         </p>

spec/controllers/diy/diy_notification_preference_spec.rb

@@ -0,0 +1,59 @@
+require "rails_helper"
+
+RSpec.describe Diy::DiyNotificationPreferenceController do
+  render_views
+
+  example_email_addr = 'example@example.test' # http://www.faqs.org/rfcs/rfc2606.html
+
+  let(:diy_intake) { create :diy_intake, email_address: example_email_addr }
+
+  before do
+    allow(subject).to receive(:current_diy_intake).and_return(diy_intake)
+    allow(subject).to receive(:send_mixpanel_event)
+  end
+
+  describe "#edit" do
+    let!(:diy_intake) { create :diy_intake, email_address: example_email_addr }
+
+    it "renders successfully" do
+      get :edit
+      expect(response).to be_successful
+    end
+  end
+
+  describe "#update" do
+    context "with valid params" do
+      let(:params) do
+        {
+          diy_notification_preference_form: {
+            email_notification_opt_in: "yes",
+            sms_notification_opt_in: "no",
+          }
+        }
+      end
+
+      it "updates the diy_intake's notification preferences" do
+        expect(diy_intake.sms_notification_opt_in).to eq("unfilled")
+        expect(diy_intake.email_notification_opt_in).to eq("unfilled")
+
+        post :update, params: params
+
+        diy_intake.reload
+        expect(diy_intake.sms_notification_opt_in).to eq("no")
+        expect(diy_intake.email_notification_opt_in).to eq("yes")
+      end
+
+      xit "sends an event to mixpanel with relevant data" do
+        post :update, params: params
+
+        expect(subject).to have_received(:send_mixpanel_event).with(
+          event_name: "question_answered",
+          data: {
+            email_notification_opt_in: "yes",
+            sms_notification_opt_in: "no",
+          }
+        )
+      end
+    end
+  end
+end

spec/controllers/diy/file_yourself_controller_spec.rb

@@ -87,10 +87,10 @@
         end
       end
 
-      it "redirects to the tax slayer link page" do
+      it "redirects to the notification preference page" do
         post :update, params: params
 
-        expect(response).to redirect_to diy_continue_to_fsa_path
+        expect(response).to redirect_to diy_diy_notification_preference_path
       end
     end