Skip to content

Commit 08f53c9

Browse files
committed
chore: Enabling running unit tests for functions/ as part of the repo checks. We have had the unit tests disabled in the build due to other tests, so this should be a net neutral change that protects us going forward. We should hopefully be able to fix the other tests when we finish upgrading to firebase-functions v2
1 parent 630225a commit 08f53c9

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/repo-checks.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919
if: always()
2020
run: yarn check-formatting
2121

22-
# TODO: Add unit tests
23-
# - name: Unit Tests
24-
# if: always()
25-
# run: yarn test
22+
# TODO: Fix non-functions unit tests
23+
- name: Unit Tests
24+
if: always()
25+
run: yarn test
2626

2727
- name: Types
2828
if: always()

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"lint:fix": "next lint --fix",
3535
"serve": "firebase emulators:start --only hosting",
3636
"start": "next start",
37+
"test": "yarn --cwd functions test",
3738
"test:e2e": "playwright test --ui",
3839
"test:e2e:headless": "playwright test",
3940
"test:integration": "jest -c tests/jest.integration.config.ts -w 1",

0 commit comments

Comments
 (0)