Skip to content

Commit 24eac79

Browse files
committed
Add a "Future work" section to the readme
1 parent e1f4917 commit 24eac79

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

llm/readme.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,8 @@ pip3 install -r llm/requirements.txt
160160

161161
Note: you'll need to set `OPENAI_DEV` and `OPENAI_PROD` in a
162162
`llm/.secret.local` file. Get it with `firebase functions:secrets:access
163-
OPENAI_DEV`. They can be set to the same token.
163+
OPENAI_DEV`. They can be set to the same token. You can see the function URL
164+
in the emulator after running `yarn dev:up`.
164165

165166
## Deploying to Firebase
166167

@@ -178,3 +179,17 @@ curl \
178179
-d '{"bill_id": "1234","bill_title": "A title","bill_text": "Some bill text"}' \
179180
https://httpsflaskexample-ke6znoupgq-uc.a.run.app/summary
180181
```
182+
183+
## Future work
184+
185+
Currently, we are just using the built-in Flask server. We should switch to a
186+
production WSGI server, like `gunicorn`.
187+
188+
The local emulator installation process is quite cumbersome and ideally the
189+
virtual environment was built during container instantiation instead of from
190+
within the Docker container (i.e. the "Deploying locally" docs above).
191+
192+
The current API is a little wonky because we take `bill_id` **and** `bill_text`.
193+
We could just look up the `bill_text` via the `bill_id` using the Firestore API.
194+
It might make sense to avoid the HTTP wrapper all-together and figure out how
195+
JS <-> Python communication works without an HTTP layer.

0 commit comments

Comments
 (0)