reinstate setBillsFollowing limiter (#1914)

* reinstate setBillsFollowing limiter

* warning for the future

Author: mertbagt

components/EditProfilePage/FollowingTab.tsx

@@ -46,8 +46,10 @@ export function FollowingTab({ className }: { className?: string }) {
       // doc.data() is never undefined for query doc snapshots
       billList.push(doc.data().billLookup)
     })
-    setBillsFollowing(billList)
-  }, [subscriptionRef, uid])
+    if (billsFollowing.length === 0 && billList.length != 0) {
+      setBillsFollowing(billList)
+    } // this limits the code from falling into an infinite loop
+  }, [subscriptionRef, uid, billsFollowing])
 
   useEffect(() => {
     uid ? billsFollowingQuery() : null
@@ -69,7 +71,7 @@ export function FollowingTab({ className }: { className?: string }) {
 
     if (usersFollowing.length === 0 && usersList.length != 0) {
       setUsersFollowing(usersList)
-    }
+    } // this limits the code from falling into an infinite loop
   }, [subscriptionRef, uid, usersFollowing])
 
   const fetchFollowedItems = useCallback(async () => {