Merge pull request #1752 from boazsender/automated-transcriptions

Use Optional over Nullable for optional fields.

Author: Mephistic

functions/src/events/scrapeEvents.ts

@@ -211,9 +211,9 @@ class HearingScraper extends EventScraper<HearingListItem, Hearing> {
       id: `hearing-${EventId}`,
       type: "hearing",
       content,
-      videoURL: maybeVideoURL,
-      videoFetchedAt: maybeVideoURL ? Timestamp.now() : null,
-      videoAssemblyId: transcript ? transcript.id : null,
+      videoURL: maybeVideoURL ? maybeVideoURL : undefined,
+      videoFetchedAt: maybeVideoURL ? Timestamp.now() : undefined,
+      videoAssemblyId: transcript ? transcript.id : undefined,
       ...this.timestamps(content)
     }
     return event

functions/src/events/types.ts

@@ -4,6 +4,7 @@ import {
   Literal as L,
   Null,
   Number,
+  Optional,
   Record,
   Runtype,
   Static,
@@ -77,9 +78,9 @@ export type Hearing = Static<typeof Hearing>
 export const Hearing = BaseEvent.extend({
   type: L("hearing"),
   content: HearingContent,
-  videoURL: Nullable(String),
-  videoAssemblyId: Nullable(String),
-  videoFetchedAt: Nullable(InstanceOf(Timestamp))
+  videoURL: Optional(String),
+  videoAssemblyId: Optional(String),
+  videoFetchedAt: Optional(InstanceOf(Timestamp))
 })
 
 export type Event = Static<typeof Event>