fix(notifications): Remove unused httpsDeliverNotifications firebase function - we can manually trigger the scheduled function if need be, so this is useless. Also fixes a typo in the digest rendering that could prevent the template from rendering with data

Author: Mephistic

functions/src/index.ts

@@ -36,7 +36,6 @@ export {
   populateTestimonySubmissionNotificationEvents,
   cleanupNotifications,
   deliverNotifications,
-  httpsDeliverNotifications,
   httpsCleanupNotifications,
   updateUserNotificationFrequency
 } from "./notifications"

functions/src/notifications/deliverNotifications.ts

@@ -233,26 +233,11 @@ const renderToHtmlString = (digestData: NotificationEmailDigest) => {
     "utf8"
   )
   const compiledTemplate = handlebars.compile(templateSource)
-  return compiledTemplate({ digestData })
+  return compiledTemplate(digestData)
 }
 
 // Firebase Functions
 export const deliverNotifications = functions.pubsub
   .schedule("47 9 1 * 2") // 9:47 AM on the first day of the month and on Tuesdays
   .timeZone("America/New_York")
   .onRun(deliverEmailNotifications)
-
-export const httpsDeliverNotifications = functions.https.onRequest(
-  async (request, response) => {
-    try {
-      await deliverEmailNotifications()
-
-      console.log("DEBUG: deliverNotifications completed")
-
-      response.status(200).send("Successfully delivered notifications")
-    } catch (error) {
-      console.error("Error in deliverNotifications:", error)
-      response.status(500).send("Internal server error")
-    }
-  }
-)

functions/src/notifications/index.ts

@@ -6,10 +6,7 @@ import {
   cleanupNotifications,
   httpsCleanupNotifications
 } from "./cleanupNotifications"
-import {
-  deliverNotifications,
-  httpsDeliverNotifications
-} from "./deliverNotifications"
+import { deliverNotifications } from "./deliverNotifications"
 import { updateUserNotificationFrequency } from "./updateUserNotificationFrequency"
 
 // Export the functions
@@ -19,7 +16,6 @@ export {
   populateTestimonySubmissionNotificationEvents,
   cleanupNotifications,
   deliverNotifications,
-  httpsDeliverNotifications,
   httpsCleanupNotifications,
   updateUserNotificationFrequency
 }

scripts/firebase-admin/runNotificationFunctions.ts

@@ -12,7 +12,6 @@ const db = admin.firestore()
 const notificationFunctions: {
   [K in FunctionName]?: K
 } = {
-  httpsDeliverNotifications: "httpsDeliverNotifications",
   httpsCleanupNotifications: "httpsCleanupNotifications"
 }