Refactor video scrape cuttoff checking

Author: boazsender

functions/src/events/helpers.test.ts

@@ -0,0 +1,21 @@
+import { subDays } from "date-fns"
+import { withinCutoff } from "./helpers"
+
+describe("withinCutoff", () => {
+  beforeEach(() => {
+    jest.useFakeTimers()
+  })
+
+  afterEach(() => {
+    jest.useRealTimers()
+  })
+
+  it("should return true for a date within three days", () => {
+    const now = new Date()
+
+    const threeDaysAgo = subDays(now, 3)
+
+    const result = withinCutoff(threeDaysAgo)
+    expect(result).toEqual(true)
+  })
+})

functions/src/events/helpers.ts

@@ -0,0 +1,8 @@
+import { isAfter, subDays } from "date-fns"
+
+export const withinCutoff = (date: Date) => {
+  const now = new Date()
+  const cutoff = subDays(now, 8)
+
+  return isAfter(date, cutoff) && !isAfter(date, now)
+}

functions/src/events/scrapeEvents.ts

@@ -19,7 +19,7 @@ import {
 import { currentGeneralCourt } from "../shared"
 import { randomBytes } from "node:crypto"
 import { sha256 } from "js-sha256"
-import { differenceInDays } from "date-fns"
+import { withinCutoff } from "./helpers"
 
 const assembly = new AssemblyAI({
   apiKey: process.env.ASSEMBLY_API_KEY ? process.env.ASSEMBLY_API_KEY : ""
@@ -156,14 +156,11 @@ class HearingScraper extends EventScraper<HearingListItem, Hearing> {
       .get()
     const eventData = eventInDb.data()
     const hearing = Hearing.check(eventData)
-    const now = new Date()
-
-    const hearingIsTodayOrFuture =
-      differenceInDays(hearing.startsAt.toDate(), now) < 8
+    const shouldScrape = withinCutoff(hearing.startsAt.toDate())
 
     let maybeVideoURL = null
     let transcript = null
-    if (!hearing.videoFetchedAt && hearingIsTodayOrFuture) {
+    if (!hearing.videoFetchedAt && shouldScrape) {
       const req = await fetch(
         `https://malegislature.gov/Events/Hearings/Detail/${EventId}`
       )
@@ -204,9 +201,7 @@ class HearingScraper extends EventScraper<HearingListItem, Hearing> {
               .collection("private")
               .doc("webhookAuth")
               .set({
-                videoAssemblyWebhookToken: hearingIsTodayOrFuture
-                  ? sha256(newToken)
-                  : null
+                videoAssemblyWebhookToken: sha256(newToken)
               })
           }
         }

functions/src/webhooks/transcription.ts

@@ -1,7 +1,6 @@
 import * as functions from "firebase-functions"
 import { AssemblyAI } from "assemblyai"
 import { db } from "../firebase"
-import { Hearing } from "../events/types"
 import { sha256 } from "js-sha256"
 
 const assembly = new AssemblyAI({