Skip to content

Move Shared Types Utilities #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Move Shared Types Utilities #1845

wants to merge 7 commits into from

Conversation

kiminkim724
Copy link
Collaborator

Summary

  • Move all shared types to a common folder/location

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to the home page
  2. Click on a testimony
  3. See that it's loaded with a loading spinner

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:07am
maple-prod 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:07am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl will be requested when the pull request is marked ready for review sashamaryl is a code owner

@mertbagt mertbagt Awaiting requested review from mertbagt mertbagt will be requested when the pull request is marked ready for review mertbagt is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders will be requested when the pull request is marked ready for review nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 will be requested when the pull request is marked ready for review mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais will be requested when the pull request is marked ready for review timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball will be requested when the pull request is marked ready for review alexjball is a code owner

@Mephistic Mephistic Awaiting requested review from Mephistic Mephistic will be requested when the pull request is marked ready for review Mephistic is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kiminkim724