Fix tests

Author: DMalone87

backend/routes/units.py

@@ -4,7 +4,8 @@
     add_pagination_wrapper, ordered_jsonify)
 from backend.database.models.user import UserRole
 from backend.database.models.agency import Unit
-from backend.routes.search import fetch_details, build_unit_result, build_officer_result
+from backend.routes.search import (
+    fetch_details, build_unit_result, build_officer_result)
 from flask import Blueprint, abort, request, jsonify
 from flask_jwt_extended.view_decorators import jwt_required
 from backend.dto.unit import UnitQueryParams, GetUnitParams
@@ -23,7 +24,8 @@
 
 LOCATION_CYPHER = """
 CALL (u) {
-  MATCH (u)-[]-(:Agency)-[]-(city:CityNode)-[]-(:CountyNode)-[]-(state:StateNode)
+  MATCH (u)-[]-(:Agency)-[]-(city:CityNode)-[]-(:CountyNode)
+  -[]-(state:StateNode)
   RETURN {
     coords: city.coordinates,
     city: city.name,
@@ -58,11 +60,14 @@
 CALL (u) {
   OPTIONAL MATCH (u)<-[]-(:Employment)-[]->(:Officer)
       -[:ACCUSED_OF]->(a:Allegation)-[:ALLEGED]-(c:Complaint)
-  WITH count(DISTINCT c) AS total_complaints, count(DISTINCT a) AS total_allegations
+  WITH
+    count(DISTINCT c) AS total_complaints,
+    count(DISTINCT a) AS total_allegations
   RETURN total_complaints, total_allegations
 }
 """
 
+
 @bp.route("", methods=["GET"])
 @jwt_required()
 @min_role_required(UserRole.PUBLIC)
@@ -177,7 +182,9 @@ def get_unit(uid: str):
                 item.model_dump() for item in officers if item
             ]
             for item in item_dump:
-                item["last_updated"] = item["last_updated"].isoformat() if item.get("last_updated", None) else None
+                item["last_updated"] = item[
+                    "last_updated"].isoformat() if item.get(
+                    "last_updated", None) else None
             unit_data["most_reported_officers"] = item_dump
             idx += 1
         if "total_officers" in params.include:
@@ -195,4 +202,4 @@ def get_unit(uid: str):
                 "city": loc["city"],
                 "state": loc["state"]
             } if loc and loc.get("coords", None) else None
-    return ordered_jsonify(unit_data), 200
+    return ordered_jsonify(unit_data), 200

backend/tests/test_units.py

@@ -75,7 +75,7 @@ def test_get_all_units(client, example_units, access_token):
 
     # Test that we can get all units
     res = client.get(
-        "/api/v1/units/",
+        "/api/v1/units",
         headers={"Authorization": "Bearer {0}".format(access_token)}
     )
     assert res.status_code == 200
@@ -87,7 +87,7 @@ def test_get_search_result(client, example_unit, access_token):
         name__icontains='Precinct 1'
     ).__len__()
     res = client.get(
-        "/api/v1/units/?name=Precinct 1&searchResult=true",
+        "/api/v1/units?name=Precinct 1&searchResult=true",
         headers={"Authorization": "Bearer {0}".format(access_token)},
     )
     assert res.status_code == 200
@@ -96,7 +96,7 @@ def test_get_search_result(client, example_unit, access_token):
 
 def test_bad_query_param(client, access_token):
     res = client.get(
-        "/api/v1/units/?abc=123",
+        "/api/v1/units?abc=123",
         headers={"Authorization": "Bearer {0}".format(access_token)},
     )
 
@@ -110,7 +110,7 @@ def test_unit_pagination(client, example_units, access_token):
     expected_total_pages = math.ceil(total_units//per_page)
     for page in range(1, expected_total_pages + 1):
         res = client.get(
-            f"/api/v1/units/?per_page={per_page}&page={page}",
+            f"/api/v1/units?per_page={per_page}&page={page}",
             headers={"Authorization": "Bearer {0}".format(access_token)},
         )
 
@@ -123,7 +123,7 @@ def test_unit_pagination(client, example_units, access_token):
 
     res = client.get(
         (
-            f"/api/v1/units/?per_page={per_page}"
+            f"/api/v1/units?per_page={per_page}"
             f"&page={expected_total_pages + 1}"
         ),
         headers={"Authorization": "Bearer {0}".format(access_token)},