Testing issue solved

Author: ayushvjain

backend/database/models/officer.py

@@ -4,9 +4,13 @@
 
 from neomodel import (
     StructuredNode,
-    RelationshipTo, RelationshipFrom, Relationship,
-    StringProperty, DateProperty,
-    UniqueIdProperty, One
+    RelationshipTo,
+    RelationshipFrom,
+    Relationship,
+    StringProperty,
+    DateProperty,
+    UniqueIdProperty,
+    One,
 )
 
 
@@ -16,20 +20,26 @@ class StateID(StructuredNode, JsonSerializable):
     law enforcement agencies. For example, in New York, this would be
     the Tax ID Number.
     """
+
     id_name = StringProperty()  # e.g. "Tax ID Number"
     state = StringProperty(choices=State.choices())  # e.g. "NY"
     value = StringProperty()  # e.g. "958938"
-    officer = RelationshipFrom('Officer', "HAS_STATE_ID", cardinality=One)
+    officer = RelationshipFrom("Officer", "HAS_STATE_ID", cardinality=One)
 
     def __repr__(self):
         return f"<StateID: Officer {self.officer_id}, {self.state}>"
 
 
 class Officer(StructuredNode, JsonSerializable):
     __property_order__ = [
-        "uid", "first_name", "middle_name",
-        "last_name", "suffix", "ethnicity",
-        "gender", "date_of_birth"
+        "uid",
+        "first_name",
+        "middle_name",
+        "last_name",
+        "suffix",
+        "ethnicity",
+        "gender",
+        "date_of_birth",
     ]
     __hidden_properties__ = ["citations"]
 
@@ -43,19 +53,23 @@ class Officer(StructuredNode, JsonSerializable):
     date_of_birth = DateProperty()
 
     # Relationships
-    state_ids = RelationshipTo('StateID', "HAS_STATE_ID")
+    state_ids = RelationshipTo("StateID", "HAS_STATE_ID")
     units = Relationship(
-        'backend.database.models.agency.Unit', "MEMBER_OF_UNIT")
+        "backend.database.models.agency.Unit", "MEMBER_OF_UNIT"
+    )
     litigation = Relationship(
-        'backend.database.models.litigation.Litigation', "NAMED_IN")
+        "backend.database.models.litigation.Litigation", "NAMED_IN"
+    )
     allegations = Relationship(
-        'backend.database.models.complaint.Allegation', "ACCUSED_OF")
+        "backend.database.models.complaint.Allegation", "ACCUSED_OF"
+    )
     investigations = Relationship(
-        'backend.database.models.complaint.Investigation', "LEAD_BY")
-    commands = Relationship(
-        'backend.database.models.agency.Unit', "COMMANDS")
+        "backend.database.models.complaint.Investigation", "LEAD_BY"
+    )
+    commands = Relationship("backend.database.models.agency.Unit", "COMMANDS")
     citations = RelationshipTo(
-        'backend.database.models.source.Source', "UPDATED_BY", model=Citation)
+        "backend.database.models.source.Source", "UPDATED_BY", model=Citation
+    )
 
     def __repr__(self):
-        return f"<Officer {self.element_id}>"
+        return f"<Officer {self.uid}>"

backend/tests/test_officers.py

@@ -10,20 +10,20 @@
         "first_name": "John",
         "last_name": "Doe",
         "ethnicity": "White",
-        "gender": "Male"
+        "gender": "Male",
     },
     "hazel": {
         "first_name": "Hazel",
         "last_name": "Nutt",
         "ethnicity": "White",
-        "gender": "Female"
+        "gender": "Female",
     },
     "frank": {
         "first_name": "Frank",
         "last_name": "Furter",
         "ethnicity": "Black/African American",
-        "gender": "Male"
-    }
+        "gender": "Male",
+    },
 }
 
 mock_agencies = {
@@ -33,42 +33,40 @@
         "hq_address": "3510 S Michigan Ave",
         "hq_city": "Chicago",
         "hq_zip": "60653",
-        "jurisdiction": "MUNICIPAL"
+        "jurisdiction": "MUNICIPAL",
     },
     "nypd": {
         "name": "New York Police Department",
         "website_url": "https://www1.nyc.gov/site/nypd/index.page",
         "hq_address": "1 Police Plaza",
         "hq_city": "New York",
         "hq_zip": "10038",
-        "jurisdiction": "MUNICIPAL"
-    }
+        "jurisdiction": "MUNICIPAL",
+    },
 }
 
 mock_employment = {
     "john": {
         "agency": "Chicago Police Department",
         "earliest_employment": "2015-03-14 00:00:00",
         "badge_number": "1234",
-        "currently_employed": True
+        "currently_employed": True,
     },
     "hazel": {
         "agency": "Chicago Police Department",
         "earliest_employment": "2018-08-12 00:00:00",
         "badge_number": "5678",
-        "currently_employed": True
+        "currently_employed": True,
     },
     "frank": {
         "agency": "New York Police Department",
         "earliest_employment": "2019-05-03 00:00:00",
         "badge_number": "1234",
-        "currently_employed": True
-    }
+        "currently_employed": True,
+    },
 }
 
-mock_sources = {
-    "cpdp": {"name": "Citizens Police Data Project"}
-}
+mock_sources = {"cpdp": {"name": "Citizens Police Data Project"}}
 
 
 @pytest.fixture
@@ -82,17 +80,15 @@ def example_officers(db_session):
 
 
 def test_create_officer(
-        db_session,
-        client,
-        contributor_access_token,
-        example_agency):
+    db_session, client, contributor_access_token, example_agency
+):
 
     # Test that we can create an officer without an agency association
     request = {
         "first_name": "Max",
         "last_name": "Payne",
         "ethnicity": "White",
-        "gender": "Male"
+        "gender": "Male",
     }
     res = client.post(
         "/api/v1/officers/",
@@ -104,9 +100,7 @@ def test_create_officer(
     assert res.status_code == 200
     response = res.json
 
-    officer_obj = (
-       Officer.nodes.get(uid=response["uid"])
-    )
+    officer_obj = Officer.nodes.get(uid=response["uid"])
     assert officer_obj.first_name == request["first_name"]
     assert officer_obj.last_name == request["last_name"]
     assert officer_obj.ethnicity == request["ethnicity"]
@@ -203,7 +197,7 @@ def test_officer_pagination(client, db_session, access_token, example_officers):
     # Create Officers in the database
     officers = Officer.nodes.all()
     per_page = 1
-    expected_total_pages = math.ceil(len(officers)//per_page)
+    expected_total_pages = math.ceil(len(officers) // per_page)
 
     for page in range(1, expected_total_pages + 1):
         res = client.get(