Use different API to download generated SQL

Signed-off-by: worksofliam <[email protected]>

Author: worksofliam

package-lock.json

@@ -970,7 +970,7 @@
         },
         {
           "command": "vscode-db2i.getObjectLocks",
-          "when": "viewItem == table || viewItem == view || viewItem == alias || viewItem == constraint || viewItem == function || viewItem == variable || viewItem == index || viewItem == procedure || viewItem == sequence || viewItem == package || viewItem == trigger || viewItem == type",
+          "when": "viewItem == table || viewItem == view || viewItem == alias || viewItem == function || viewItem == variable || viewItem == index || viewItem == procedure || viewItem == sequence || viewItem == package || viewItem == trigger || viewItem == type",
           "group": "db2workWith@5"
         },
         {
@@ -1322,7 +1322,7 @@
   },
   "devDependencies": {
     "@continuedev/core": "^1.0.13",
-    "@halcyontech/vscode-ibmi-types": "^2.14.0",
+    "@halcyontech/vscode-ibmi-types": "^2.14.5",
     "@types/glob": "^7.1.3",
     "@types/node": "18.x",
     "@types/vscode": "^1.95.0",

package.json

@@ -1,6 +1,6 @@
 
+import path from "path";
 import { getInstance } from "../base";
-
 import { JobManager } from "../config";
 
 export type SQLType = "schemas" | "tables" | "views" | "aliases" | "constraints" | "functions" | "variables" | "indexes" | "procedures" | "sequences" | "packages" | "triggers" | "types" | "logicals";
@@ -220,23 +220,27 @@ export default class Schemas {
    * @param object Not user input
    */
   static async generateSQL(schema: string, object: string, internalType: string): Promise<string> {
-    await JobManager.runSQL<{ SRCDTA: string }>([
-      `CALL QSYS2.GENERATE_SQL( DATABASE_OBJECT_NAME => ?, DATABASE_OBJECT_LIBRARY_NAME => ?, DATABASE_OBJECT_TYPE => ?
-                              , CREATE_OR_REPLACE_OPTION => '1', PRIVILEGES_OPTION => '0'
-                              , DATABASE_SOURCE_FILE_NAME => '*STMF'
-                              , STATEMENT_FORMATTING_OPTION => '0'
-                              , SOURCE_STREAM_FILE => '/tmp/Q_GENSQL_' concat current_user concat '.sql'
-                              , SOURCE_STREAM_FILE_END_OF_LINE => 'LF'
-                              , SOURCE_STREAM_FILE_CCSID => 1208 )`
-    ].join(` `), { parameters: [object, schema, internalType] });
-    const lines = await JobManager.runSQL<{ LINE: string }>(
-      `select LINE
-         from table( QSYS2.IFS_READ( PATH_NAME => '/tmp/Q_GENSQL_' concat current_user concat '.sql' ) )`
-    );
-
-    const generatedStatement = lines.map( elem => elem.LINE ).join(`\n`);
-
-    return generatedStatement;
+    const instance = getInstance();
+    const connection = instance.getConnection();
+
+    const result = await connection.withTempDirectory<string>(async (tempDir) => {
+      const tempFilePath = path.posix.join(tempDir, `generatedSql.sql`);
+      await JobManager.runSQL<{ SRCDTA: string }>([
+        `CALL QSYS2.GENERATE_SQL( DATABASE_OBJECT_NAME => ?, DATABASE_OBJECT_LIBRARY_NAME => ?, DATABASE_OBJECT_TYPE => ?
+                                , CREATE_OR_REPLACE_OPTION => '1', PRIVILEGES_OPTION => '0'
+                                , DATABASE_SOURCE_FILE_NAME => '*STMF'
+                                , STATEMENT_FORMATTING_OPTION => '0'
+                                , SOURCE_STREAM_FILE => '${tempFilePath}'
+                                , SOURCE_STREAM_FILE_END_OF_LINE => 'LF'
+                                , SOURCE_STREAM_FILE_CCSID => 1208 )`
+      ].join(` `), { parameters: [object, schema, internalType] });
+
+      // TODO: eventually .content -> .getContent(), it's not available yet
+      const contents = (await connection.content.downloadStreamfileRaw(tempFilePath)).toString();
+      return contents;
+    })
+
+    return result;
   }
 
   static async deleteObject(schema: string, name: string, type: string): Promise<void> {