Merge branch 'main' into iss266

Author: dferrand

.eslintrc.json

@@ -14,7 +14,7 @@ jobs:
           node-version: '20'
       - uses: actions/checkout@v2
 
-      - run: npm install
+      - run: npm ci
 
       - run: npm install -g vsce ovsx
 

.github/workflows/release.yaml

@@ -1,10 +1,6 @@
 name: NodeJS with Webpack
 
-on:
-  push:
-    branches: [ "main" ]
-  pull_request:
-    branches: [ "main" ]
+on: pull_request
 
 jobs:
   build:
@@ -22,9 +18,14 @@ jobs:
       with:
         node-version: ${{ matrix.node-version }}
 
+    - name: Install dependencies
+      run: npm ci
+
+    - name: Type check
+      run: npm run typings
+
     - name: Build and package
       run: |
-        npm install
         npx webpack
         npm install -g vsce
         vsce package
@@ -35,18 +36,41 @@ jobs:
         cat $GITHUB_ENV
 
     - name: Upload dist artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: test_vsix
         path: ${{env.vsix_name}}
 
+    - name: Find Comment
+      uses: peter-evans/find-comment@v1
+      id: fc
+      with:
+        issue-number: ${{ github.event.pull_request.number }}
+        comment-author: 'github-actions[bot]'
+        body-includes: new build is available
+
     - name: Post comment
+      continue-on-error: true
+      if: steps.fc.outputs.comment-id == ''
       uses: actions/github-script@v5
       with:
         script: |
           github.rest.issues.createComment({
             issue_number: context.issue.number,
             owner: context.repo.owner,
             repo: context.repo.repo,
-            body: '👋  A new build is available for this PR based on ${{ github.event.pull_request.head.sha }}.\n * [Download here.](https://github.com/halcyon-tech/vscode-db2i/actions/runs/${{ github.run_id }})\n'
+            body: '👋 A new build is available for this PR based on ${{ github.event.pull_request.head.sha }}.\n * [Download here.](https://github.com/codefori/vscode-db2i/actions/runs/${{ github.run_id }})\n* [Read more about how to test](https://github.com/codefori/vscode-db2i/blob/master/.github/pr_testing_template.md)'
           })
+
+    - name: Update comment
+      continue-on-error: true
+      if: steps.fc.outputs.comment-id != ''
+      uses: peter-evans/create-or-update-comment@v1
+      with:
+        edit-mode: replace
+        comment-id: ${{ steps.fc.outputs.comment-id }}
+        body: |
+          👋 A new build is available for this PR based on ${{ github.event.pull_request.head.sha }}.
+
+          * [Download here.](https://github.com/codefori/vscode-db2i/actions/runs/${{ github.run_id }})
+          * [Read more about how to test](https://github.com/codefori/vscode-db2i/blob/master/.github/pr_testing_template.md)

.github/workflows/webpack_ci.yaml

@@ -2,5 +2,4 @@ node_modules
 .vscode-test/
 *.vsix
 .DS_Store
-dist
-types
+dist

.gitignore

@@ -31,7 +31,24 @@
 			"preLaunchTask": "${defaultBuildTask}",
 			"sourceMaps": true,
 			"env": {
-				"testing": "true"
+				"db2_testing": "true"
+			}
+		},
+		{
+			"name": "Launch Tests (Specific)",
+			"type": "extensionHost",
+			"request": "launch",
+			"args": [
+				"--extensionDevelopmentPath=${workspaceFolder}"
+			],
+			"outFiles": [
+				"${workspaceFolder}/dist/**/*.js"
+			],
+			"preLaunchTask": "${defaultBuildTask}",
+			"sourceMaps": true,
+			"env": {
+				"db2_testing": "true",
+				"db2_specific": "true"
 			}
 		},
 	]

.vscode/launch.json

@@ -10,6 +10,5 @@ vsc-extension-quickstart.md
 media/main.png
 node_modules
 src
-types
 .github
 src/dsc.ts