refactor: builders only accept post id

Author: sushichan044

app/components/note/Note.tsx

@@ -3,8 +3,8 @@ import { useMemo } from "react";
 
 import { LANGUAGE_ID_TO_LABEL } from "../../feature/search/language";
 import {
-  birdWatchLinkFromNote,
-  postLinkFromNote,
+  birdWatchLinkFromPostId,
+  postLinkFromPostId,
 } from "../../feature/twitter/link-builder";
 import type { SearchedNote } from "../../generated/api/schemas";
 import { isNonEmptyString } from "../../utils/string";
@@ -66,7 +66,7 @@ export const Note = ({ note }: NoteProps) => {
             <Button
               color="pink"
               component="a"
-              href={postLinkFromNote(note)}
+              href={postLinkFromPostId(note.postId)}
               size="xs"
               target="_blank"
               variant="light"
@@ -76,7 +76,7 @@ export const Note = ({ note }: NoteProps) => {
             <Button
               color="pink"
               component="a"
-              href={birdWatchLinkFromNote(note)}
+              href={birdWatchLinkFromPostId(note.postId)}
               size="xs"
               target="_blank"
               variant="light"

app/feature/twitter/link-builder.ts

@@ -1,10 +1,8 @@
-import type { Note } from "../../generated/api/schemas";
-
-export const birdWatchLinkFromNote = (note: Note): string => {
-  return `https://x.com/i/birdwatch/t/${note.postId}`;
+export const birdWatchLinkFromPostId = (postId: string): string => {
+  return `https://x.com/i/birdwatch/t/${postId}`;
 };
 
-export const postLinkFromNote = (note: Note): string => {
+export const postLinkFromPostId = (postId: string): string => {
   // X redirects to correct post url regardless of userId, so just specify `i`
-  return `https://x.com/i/status/${note.postId}`;
+  return `https://x.com/i/status/${postId}`;
 };