add alternative typecheckers; add type-simplejson; some annotations and ignores in session.py

Author: yangm2

README.md

@@ -57,6 +57,24 @@ Live at https://tenantfirstaid.com/
        ```sh
        % make typecheck
        ```
+
+       *typecheck* with other Python typecheckers which are not protected in [PR Checks](.github/workflows/pr-check.yml) - useful for completeness & a 2nd opinion
+       1. *typecheck* Python code with `mypy`
+          ```sh
+          % uv run mypy -p tenantfirstaid --python-executable .venv/bin/python3 --check-untyped-defs
+          ```
+          or
+          ```sh
+          % make typecheck-mypy
+          ```
+       1. *typecheck* Python code with `pyrefly`
+          ```sh
+          % uv run pyrefly check --python-interpreter .venv/bin/python3
+          ```
+          or
+          ```sh
+          % make typecheck-pyrefly
+          ```
     1. *test* Python code with `pytest`
        ```sh
        % uv run pytest

backend/Makefile

@@ -20,6 +20,12 @@ lint: uv.lock
 typecheck: uv.lock
 	$(PYTHON) run ty check $(TYPECHECK_OPTIONS)
 
+typecheck-mypy: uv.lock
+	$(PYTHON) run mypy $(TYPECHECK_OPTIONS) -p tenantfirstaid --python-executable .venv/bin/python3 --check-untyped-defs
+
+typecheck-pyrefly: uv.lock
+	$(PYTHON) run pyrefly check $(TYPECHECK_OPTIONS) --python-interpreter .venv/bin/python3
+
 test: uv.lock
 	uv run pytest -v -s $(TEST_OPTIONS)
 

backend/pyproject.toml

@@ -24,12 +24,15 @@ build-backend = "setuptools.build_meta"
 [dependency-groups]
 dev = [
     "ipdb>=0.13.13",
+    "mypy>=1.16.1",
+    "pyrefly>=0.21.0",
     "pytest>=8.4.0",
     "pytest-cov>=6.1.1",
     "pytest-mock>=3.14.1",
     "ruff>=0.12.0",
     "ty>=0.0.1a11",
     "types-Flask>=1.1.6",
+    "types-simplejson>=3.20.0.20250326",
 ]
 
 gen_convo = [

backend/tenantfirstaid/session.py

@@ -58,11 +58,11 @@ def save_session(response):
     def get(self) -> TenantSessionData:
         session_id = self.get_flask_session_id()
 
-        saved_session = self.db_con.get(session_id)
+        saved_session: Optional[str] = self.db_con.get(session_id)  # type: ignore # known issue https://github.com/valkey-io/valkey-py/issues/164
         if not saved_session:
             return self.getNewSessionData()
 
-        return json.loads(saved_session)
+        return json.loads(s=saved_session)
 
     def set(self, value: TenantSessionData):
         session_id = self.get_flask_session_id()
@@ -79,10 +79,10 @@ def __init__(self, tenant_session: TenantSession):
 
     def dispatch_request(self):
         data: Dict[str, Any] = request.json
-        session_id = self.tenant_session.get_flask_session_id()
+        session_id: Optional[str] = self.tenant_session.get_flask_session_id()
 
-        city = data["city"] or "null"
-        state = data["state"]
+        city: str | Literal["null"] = data["city"] or "null"
+        state: str = data["state"]
 
         # Initialize the session with city and state
         initial_data = TenantSessionData(city=city, state=state, messages=[])