Skip to content

Commit d878349

Browse files
reggie-kcrenshaw-devHazel Sudzilouskiagaudreault
authored andcommitted
feat: move pkg/exec in-tree and add fatal timeout upgrade with SIGKILL to ARGO_EXEC_TIMEOUT (#419)
* chore: move pkg/exec in-tree (argoproj#22175) (argoproj#22460) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix: add fatal timeout upgrade with SIGKILL to ARGO_EXEC_TIMEOUT (closes argoproj#20785, argoproj#18478) (argoproj#22713) Signed-off-by: Hazel Sudzilouski <dsudzilouski@olin.edu> Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Hazel Sudzilouski <dsudzilouski@olin.edu> Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Hazel Sudzilouski <t-danielsu@microsoft.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
1 parent 32f460b commit d878349

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

util/exec/exec_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ func TestRunInDir(t *testing.T) {
203203
}
204204

205205
func TestRedact(t *testing.T) {
206-
assert.Empty(t, Redact(nil)(""))
207-
assert.Empty(t, Redact([]string{})(""))
208-
assert.Empty(t, Redact([]string{"foo"})(""))
206+
assert.Equal(t, "", Redact(nil)(""))
207+
assert.Equal(t, "", Redact([]string{})(""))
208+
assert.Equal(t, "", Redact([]string{"foo"})(""))
209209
assert.Equal(t, "foo", Redact([]string{})("foo"))
210210
assert.Equal(t, "******", Redact([]string{"foo"})("foo"))
211211
assert.Equal(t, "****** ******", Redact([]string{"foo", "bar"})("foo bar"))

0 commit comments

Comments
 (0)