Skip to content

Commit 137ba73

Browse files
mkilchhoferppapapetrou76
authored andcommitted
ci(argo-cd): Replace Bitnami redis with simple YAML file (argoproj#3497)
Signed-off-by: Marco Maurer <[email protected]>
1 parent 8b35162 commit 137ba73

File tree

4 files changed

+69
-5
lines changed

4 files changed

+69
-5
lines changed
Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
apiVersion: v1
2+
kind: Namespace
3+
metadata:
4+
labels:
5+
app: external-redis
6+
name: redis
7+
---
8+
apiVersion: apps/v1
9+
kind: Deployment
10+
metadata:
11+
labels:
12+
app: external-redis
13+
name: redis
14+
namespace: redis
15+
spec:
16+
replicas: 1
17+
selector:
18+
matchLabels:
19+
app: external-redis
20+
template:
21+
metadata:
22+
labels:
23+
app: external-redis
24+
spec:
25+
containers:
26+
- args:
27+
- --save
28+
- ""
29+
- --appendonly
30+
- "no"
31+
- --requirepass argocd
32+
image: ecr-public.aws.com/docker/library/redis:7.2.8-alpine
33+
name: redis
34+
ports:
35+
- containerPort: 6379
36+
name: redis
37+
protocol: TCP
38+
resources: {}
39+
securityContext:
40+
allowPrivilegeEscalation: false
41+
capabilities:
42+
drop:
43+
- ALL
44+
readOnlyRootFilesystem: true
45+
securityContext:
46+
runAsNonRoot: true
47+
runAsUser: 999
48+
seccompProfile:
49+
type: RuntimeDefault
50+
---
51+
apiVersion: v1
52+
kind: Service
53+
metadata:
54+
labels:
55+
app: external-redis
56+
name: redis
57+
namespace: redis
58+
spec:
59+
ports:
60+
- name: redis
61+
port: 6379
62+
protocol: TCP
63+
targetPort: redis
64+
selector:
65+
app: external-redis
66+
type: ClusterIP

.github/workflows/lint-and-test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,7 @@ jobs:
8484
- name: Create an external redis for ArgoCD externalRedis feature
8585
if: contains(steps.list-changed.outputs.changed_charts, 'argo-cd')
8686
run: |
87-
kubectl create namespace redis
88-
helm repo add bitnami https://charts.bitnami.com/bitnami
89-
helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set global.image.repository=bitnamisecure/redis --set architecture=standalone
87+
kubectl apply -f ./.github/configs/external-redis.yaml
9088
9189
- name: Run chart-testing (install)
9290
run: ct install --config ./.github/configs/ct-install.yaml --target-branch ${{ github.base_ref }}

charts/argo-cd/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ annotations:
2727
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2828
artifacthub.io/changes: |
2929
- kind: changed
30-
description: Updates ArgoCD to 3.1.5
30+
description: Updates ArgoCD to 3.1.5 and Replace Bitnami dependency used to automatically test this chart

charts/argo-cd/ci/external-redis-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ redis-ha:
88
enabled: false
99

1010
externalRedis:
11-
host: "redis-master.redis.svc.cluster.local"
11+
host: "external-redis.redis.svc.cluster.local"
1212
password: "argocd"
1313

1414
# needed for correct work of event reporter component

0 commit comments

Comments
 (0)