Skip to content

Commit 2ba2eb3

Browse files
mrgb7mkilchhofer
andauthored
feat(argo-rollouts): add annotations for notifications secret (argoproj#2777)
* feat(argo-rollouts): Most users of Argo-rollouts may store secrets on vault which allows to auto inject secrets directly to secrets object using annotations. Signed-off-by:Mohamed Ragab <[email protected]> Signed-off-by: Mohamed Ragab <[email protected]> * Fix indentation Signed-off-by: Mohamed Ragab <[email protected]> --------- Signed-off-by: Mohamed Ragab <[email protected]> Co-authored-by: Marco Maurer (-Kilchhofer) <[email protected]>
1 parent 02949b1 commit 2ba2eb3

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

charts/argo-rollouts/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
appVersion: v1.7.0
33
description: A Helm chart for Argo Rollouts
44
name: argo-rollouts
5-
version: 2.36.0
5+
version: 2.36.1
66
home: https://github.com/argoproj/argo-helm
77
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
88
keywords:
@@ -19,4 +19,4 @@ annotations:
1919
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2020
artifacthub.io/changes: |
2121
- kind: changed
22-
description: Bump argo-rollouts to v1.7.0
22+
description: Add annotations for notifications secret

charts/argo-rollouts/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ For full list of changes please check ArtifactHub [changelog].
5858
| kubeVersionOverride | string | `""` | Override the Kubernetes version, which is used to evaluate certain manifests |
5959
| nameOverride | string | `nil` | String to partially override "argo-rollouts.fullname" template |
6060
| notifications.notifiers | object | `{}` | Configures notification services |
61+
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
6162
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
6263
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
6364
| notifications.templates | object | `{}` | Notification templates |

charts/argo-rollouts/templates/controller/notifications-secret.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ kind: Secret
44
metadata:
55
name: argo-rollouts-notification-secret
66
namespace: {{ .Release.Namespace | quote }}
7+
{{- with .Values.notifications.secret.annotations }}
8+
annotations:
9+
{{- range $key, $value := . }}
10+
{{ $key }}: {{ $value | quote }}
11+
{{- end }}
12+
{{- end }}
713
labels:
814
app.kubernetes.io/component: {{ .Values.controller.component }}
915
{{- include "argo-rollouts.labels" . | nindent 4 }}

charts/argo-rollouts/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,8 @@ notifications:
454454
# -- Generic key:value pairs to be inserted into the notifications secret
455455
items: {}
456456
# slack-token:
457+
# -- Annotations to be added to the notifications secret
458+
annotations: {}
457459

458460
# -- Configures notification services
459461
notifiers: {}

0 commit comments

Comments
 (0)