feat(argo-cd): VerticalPodAutoscaler support for application controller (argoproj#3365)

* chore(deps): update renovatebot/github-action action to v43 (argoproj#3363)

Signed-off-by: Yarin Golzar <[email protected]>

* added VerticalPodAutoscaler support for application controller argoproj#3232

Signed-off-by: Yarin Golzar <[email protected]>

* removed trailing spaces

Signed-off-by: Yarin Golzar <[email protected]>

* chore(deps): update renovatebot/github-action action to v43.0.1 (argoproj#3366)

Signed-off-by: Yarin Golzar <[email protected]>

* fix(argo-cd): do not use hardcoded commit server URL (argoproj#3367)

* fix(argo-cd): do not use hardcoded commit server URL

This commit adds the required template logic to the Argo CD Helm chart
to use the proper, release name dependent URL for the commit server. The current
implementation uses the default hardcoded URL `argocd-commit-server:8086`
from <https://github.com/argoproj/argo-cd/blob/v3.0.9/common/common.go#L31>.

Signed-off-by: Alexej Disterhoft <[email protected]>

* chore(argo-cd): update version to 8.1.2

Signed-off-by: Alexej Disterhoft <[email protected]>

* docs(argo-cd): add commit server service port and port name to README

Signed-off-by: Alexej Disterhoft <[email protected]>

---------

Signed-off-by: Alexej Disterhoft <[email protected]>

* chore(deps): bump github/codeql-action from 3.29.0 to 3.29.1 in the dependencies group (argoproj#3370)

chore(deps): bump github/codeql-action in the dependencies group

Bumps the dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).

Updates `github/codeql-action` from 3.29.0 to 3.29.1
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ce28f5b...39edc49)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yarin Golzar <[email protected]>

* chore(deps): update renovatebot/github-action action to v43.0.2 (argoproj#3371)

Signed-off-by: Yarin Golzar <[email protected]>

* chore(deps): update ghcr.io/renovatebot/renovate docker tag to v41 (argoproj#3373)

Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Signed-off-by: Yarin Golzar <[email protected]>

* chore(deps): bump github/codeql-action from 3.29.1 to 3.29.2 in the dependencies group (argoproj#3378)

chore(deps): bump github/codeql-action in the dependencies group

Bumps the dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).

Updates `github/codeql-action` from 3.29.1 to 3.29.2
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@39edc49...181d5ee)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yarin Golzar <[email protected]>

* feat(argo-rollouts): Support ability to set .Values.namespaceOverride (argoproj#3375)

Signed-off-by: Yarin Golzar <[email protected]>

* updated docs to match vpa default values settings

Signed-off-by: Yarin Golzar <[email protected]>

* chore(argo-cd): Update dependency argoproj/argo-cd to v3.0.11 (argoproj#3380)

---------

Signed-off-by: Yarin Golzar <[email protected]>
Signed-off-by: Alexej Disterhoft <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Signed-off-by: Yarin Golzar <[email protected]>
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Co-authored-by: Yarin Golzar <[email protected]>
Co-authored-by: Alexej Disterhoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tcaenen <[email protected]>
Co-authored-by: Marco Maurer (-Kilchhofer) <[email protected]>

Author: 7 people

charts/argo-cd/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: v3.1.5
 kubeVersion: ">=1.25.0-0"
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 8.3.9
+version: 8.4.0
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 sources:
@@ -26,5 +26,5 @@ annotations:
     fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
     url: https://argoproj.github.io/argo-helm/pgp_keys.asc
   artifacthub.io/changes: |
-    - kind: fixed
-      description: Update ingress class annotation for GKE compatibility
+    - kind: added
+      description: support VerticalPodAutoscaler for application controller

charts/argo-cd/README.md

@@ -953,6 +953,11 @@ NAME: my-release
 | controller.topologySpreadConstraints | list | `[]` (defaults to global.topologySpreadConstraints) | Assign custom [TopologySpreadConstraints] rules to the application controller |
 | controller.volumeMounts | list | `[]` | Additional volumeMounts to the application controller main container |
 | controller.volumes | list | `[]` | Additional volumes to the application controller pod |
+| controller.vpa.annotations | object | `{}` | Annotations to be added to application controller vpa |
+| controller.vpa.containerPolicy | object | `{}` | Controls how VPA computes the recommended resources for application controller container |
+| controller.vpa.enabled | bool | `false` | Deploy a [VerticalPodAutoscaler](https://kubernetes.io/docs/concepts/workloads/autoscaling/#scaling-workloads-vertically/) for the application controller |
+| controller.vpa.labels | object | `{}` | Labels to be added to application controller vpa |
+| controller.vpa.updateMode | string | `"Initial"` | One of the VPA operation modes |
 
 ## Argo Repo Server
 

charts/argo-cd/templates/argocd-application-controller/vpa.yaml

@@ -0,0 +1,33 @@
+{{- if and (.Values.controller.vpa) (.Values.controller.vpa.enabled) }}
+apiVersion: autoscaling.k8s.io/v1
+kind: VerticalPodAutoscaler
+metadata:
+  name: {{ include "argo-cd.controller.fullname" . }}
+  namespace: {{ include  "argo-cd.namespace" . }}
+  labels:
+    {{- include "argo-cd.labels" (dict "context" . "component" .Values.controller.name "name" .Values.controller.name) | nindent 4 }}
+    {{- with .Values.controller.vpa.labels }}
+      {{- toYaml . | nindent 4 }}
+    {{- end }}
+  {{- with .Values.controller.vpa.annotations }}
+  annnotaions:
+  {{- toYaml . | nindent 4 }}
+  {{- end }}
+spec:
+  targetRef:
+    apiVersion: "apps/v1"
+    {{- if .Values.controller.dynamicClusterDistribution }}
+    kind: Deployment
+    {{- else }}
+    kind: StatefulSet
+    {{- end }}
+    name: {{ template "argo-cd.controller.fullname" . }}
+  updatePolicy:
+    updateMode: {{ .Values.controller.vpa.updateMode }}
+  resourcePolicy:
+    containerPolicies:
+    - containerName: {{ .Values.controller.name }}
+    {{ with .Values.controller.vpa.containerPolicy }}
+    {{- toYaml . | nindent 6 }}
+    {{- end }}
+{{- end }}

charts/argo-cd/values.yaml

@@ -817,6 +817,31 @@ controller:
     ## Has higher precedence over `controller.pdb.minAvailable`
     maxUnavailable: ""
 
+  ## Application controller Vertical Pod Autoscaler
+  ## Ref: https://kubernetes.io/docs/concepts/workloads/autoscaling/#scaling-workloads-vertically/
+  vpa:
+    # -- Deploy a [VerticalPodAutoscaler](https://kubernetes.io/docs/concepts/workloads/autoscaling/#scaling-workloads-vertically/) for the application controller
+    enabled: false
+    # -- Labels to be added to application controller vpa
+    labels: {}
+    # -- Annotations to be added to application controller vpa
+    annotations: {}
+    # -- One of the VPA operation modes
+    ## Ref: https://kubernetes.io/docs/concepts/workloads/autoscaling/#scaling-workloads-vertically
+    ## Note: Recreate update mode requires more than one replica unless the min-replicas VPA controller flag is overridden
+    updateMode: Initial
+    # -- Controls how VPA computes the recommended resources for application controller container
+    ## Ref: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/examples/hamster.yaml
+    containerPolicy: {}
+      # controlledResources: ["cpu", "memory"]
+      # minAllowed:
+      #   cpu: 250m
+      #   memory: 256Mi
+      # maxAllowed:
+      #   cpu: 1
+      #   memory: 1Gi
+
+
   ## Application controller image
   image:
     # -- Repository to use for the application controller