Skip to content

Commit 4b8703d

Browse files
authored
chore(argo-workflows): Support podGCDeleteDelayDuration and podGCGracePeriodSeconds (argoproj#1728)
Signed-off-by: yu-croco <[email protected]>
1 parent 5bd70fb commit 4b8703d

File tree

4 files changed

+18
-2
lines changed

4 files changed

+18
-2
lines changed

charts/argo-workflows/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ appVersion: v3.4.4
33
name: argo-workflows
44
description: A Helm chart for Argo Workflows
55
type: application
6-
version: 0.22.6
6+
version: 0.22.7
77
icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png
88
home: https://github.com/argoproj/argo-helm
99
sources:
@@ -13,4 +13,4 @@ maintainers:
1313
url: https://argoproj.github.io/
1414
annotations:
1515
artifacthub.io/changes: |
16-
- "[Added]: Suuport envFrom for main container"
16+
- "[Added]: Support podGCDeleteDelayDuration and podGCGracePeriodSeconds"

charts/argo-workflows/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ Fields to note:
111111
| controller.pdb.enabled | bool | `false` | Configure [Pod Disruption Budget] for the controller pods |
112112
| controller.persistence | object | `{}` | enable persistence using postgres |
113113
| controller.podAnnotations | object | `{}` | podAnnotations is an optional map of annotations to be applied to the controller Pods |
114+
| controller.podGCDeleteDelayDuration | string | `5s` (Argo Workflows default) | The duration in seconds before the pods in the GC queue get deleted. A zero value indicates that the pods will be deleted immediately. |
115+
| controller.podGCGracePeriodSeconds | string | `30` seconds (Kubernetes default) | Specifies the duration in seconds before a terminating pod is forcefully killed. A zero value indicates that the pod will be forcefully terminated immediately. |
114116
| controller.podLabels | object | `{}` | Optional labels to add to the controller pods |
115117
| controller.podSecurityContext | object | `{}` | SecurityContext to set on the controller pods |
116118
| controller.priorityClassName | string | `""` | Leverage a PriorityClass to ensure your pods survive resource shortages. |

charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,3 +181,9 @@ data:
181181
{{- with .Values.controller.kubeConfig }}
182182
kubeConfig: {{- toYaml . | nindent 6 }}
183183
{{- end }}
184+
{{- with .Values.controller.podGCGracePeriodSeconds }}
185+
podGCGracePeriodSeconds: {{ . }}
186+
{{- end }}
187+
{{- with .Values.controller.podGCDeleteDelayDuration }}
188+
podGCDeleteDelayDuration: {{ . }}
189+
{{- end }}

charts/argo-workflows/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,14 @@ controller:
316316
# # volume name when mounting the secret, default to kubeconfig
317317
# volumeName: kube-config-volume
318318

319+
# -- Specifies the duration in seconds before a terminating pod is forcefully killed. A zero value indicates that the pod will be forcefully terminated immediately.
320+
# @default -- `30` seconds (Kubernetes default)
321+
podGCGracePeriodSeconds:
322+
323+
# -- The duration in seconds before the pods in the GC queue get deleted. A zero value indicates that the pods will be deleted immediately.
324+
# @default -- `5s` (Argo Workflows default)
325+
podGCDeleteDelayDuration: ""
326+
319327
# mainContainer adds default config for main container that could be overriden in workflows template
320328
mainContainer:
321329
# -- imagePullPolicy to apply to Workflow main container. Defaults to `.Values.images.pullPolicy`.

0 commit comments

Comments
 (0)