Skip to content

Commit 9591bf1

Browse files
ilia-medvedev-codefreshpdrastilhorjulfnxf5025ashlineldridge
authored
Update chart to 5.16.0 (#5)
* feat(argo-cd): Upgrade Argo CD to 2.5.0 (argoproj#1568) Signed-off-by: Petr Drastil <[email protected]> * chore(github): Bump GitHub actions versions (argoproj#1575) Signed-off-by: Petr Drastil <[email protected]> * fix(argo-cd): Chart NOTES nil references (argoproj#1582) Signed-off-by: Filipe Santos <[email protected]> * docs(argo-cd): Improve documentation (argoproj#1584) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> * fix(argo-workflows): serviceaccount rbac when sso is enabled (argoproj#1586) Signed-off-by: Nick Fisher <[email protected]> Signed-off-by: Nick Fisher <[email protected]> * Fix incorrect applicationSet property in README (argoproj#1590) Based on [here](https://github.com/argoproj/argo-helm/blob/55b8b34d20ebaf38fa05e1113daf30220d11e725/charts/argo-cd/templates/argocd-applicationset/deployment.yaml#L9), I think `replicas` should be `replicaCount` (though `replicas` would be more consistent). Signed-off-by: Ashlin Eldridge <[email protected]> Signed-off-by: Ashlin Eldridge <[email protected]> * fix(argo-cd): Remove AWS volume from server (argoproj#1591) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> * chore(argo-cd): Cleanup Redis manifest (argoproj#1577) Signed-off-by: Petr Drastil <[email protected]> * fix(argo-cd): Fix migration path for server configs (argoproj#1585) Signed-off-by: Petr Drastil <[email protected]> * fix(argo-cd): Type conversion for ConfigMaps values (argoproj#1594) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Add probes for ApplicationSet controller (argoproj#1532) Signed-off-by: Petr Drastil <[email protected]> * chore(argo-cd): Remove liveness probe from application controller (argoproj#1581) Signed-off-by: Petr Drastil <[email protected]> * chore(github): Add dependabot.yml (argoproj#1595) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Set container security contexts (argoproj#1579) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Support custom TLS certificates for Dex (argoproj#1477) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Support manually managed TLS certificate for Server (argoproj#1534) Signed-off-by: Petr Drastil <[email protected]> * fix(argo-cd): Don't install CRDs for disabled components (argoproj#1596) Signed-off-by: Marco Kilchhofer <[email protected]> * fix(argo-cd): update network policy port name (argoproj#1603) Signed-off-by: Eric Cimino <[email protected]> * chore(argo-workflows): Update ArgoWorkflows to v3.4.3 (argoproj#1610) Signed-off-by: yu-croco <[email protected]> * fix(argo-cd): Replace coalesce with merge for old config values (argoproj#1612) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Add revisionHistoryLimit (argoproj#1599) Signed-off-by: Petr Drastil <[email protected]> * Upgrade Argo Image to the latest (argoproj#1614) Signed-off-by: Dong Wang <[email protected]> Signed-off-by: Dong Wang <[email protected]> * chore(argo-cd): Update redis-ha (argoproj#1617) Signed-off-by: yu-croco <[email protected]> * fix(argo-cd): Add /tmp voulmeMount to extensions container (argoproj#1620) * Fixes argoproj#1619 - Add /tmp voulmeMount to extensions container Signed-off-by: Tim Van de Walle <[email protected]> * Bump version, add change notes Signed-off-by: Tim Van de Walle <[email protected]> Signed-off-by: Tim Van de Walle <[email protected]> * fix(argo-cd): Add missing ClusterRole permissions to argo-cd-server to manage Application in all namespaces (argoproj#1621) Signed-off-by: Elad Dolev <[email protected]> * fix(argo-cd): Use Dex non-distroless image (argoproj#1626) Signed-off-by: Petr Drastil <[email protected]> * chore(argo-cd): Upgrade Argo CD to 2.5.2 (argoproj#1628) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> * Allow to add custom artifact repository (argoproj#1453) Signed-off-by: Max Kochubey <[email protected]> Signed-off-by: Max Kochubey <[email protected]> * fix(argo-cd): Use raw json for cluster credentials for Vault compatibility (argoproj#1634) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> Co-authored-by: Aikawa <[email protected]> * fix(argo-cd): Cluster credentials config should be a string (argoproj#1636) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> * fix(argo-workflows): Added missing attribute for sso (argoproj#1641) Signed-off-by: yu-croco <[email protected]> * docs(argo-cd): Improve changelog information (argoproj#1652) Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Petr Drastil <[email protected]> * chore(argo-cd): Consolidated GnuPG configuration (argoproj#1609) Signed-off-by: Petr Drastil <[email protected]> * fix(argo-cd): Invalid argocd-gpg-keys-cm template (argoproj#1656) The template removed a little too much whitespace resulting in an invalid ConfigMap. Error: ``` Error: YAML parse error on argocd/charts/argo-cd/templates/argocd-configs/argocd-gpg-keys-cm.yaml: error converting YAML to JSON: yaml: line 10: mapping values are not allowed in this context ``` Signed-off-by: Allex <[email protected]> Signed-off-by: Allex <[email protected]> * feat(argo-workflows): Allow controller to whitelist secrets (argoproj#1646) * allow users to whitelist secrets Signed-off-by: emmayylu <[email protected]> * remove unnecessary if-statement Signed-off-by: emmayylu <[email protected]> * use square bracket for array Signed-off-by: emmayylu <[email protected]> * fix typo and update readme Signed-off-by: emmayylu <[email protected]> Signed-off-by: emmayylu <[email protected]> Signed-off-by: emmayylu <[email protected]> Co-authored-by: emmayylu <[email protected]> * feat(argo-workflows): Add labels for ServiceAccounts (argoproj#1665) * Add labels for ServiceAccounts Signed-off-by: Eugene Lugovtsov <[email protected]> * fix workflow serviceaccount labels Signed-off-by: Eugene Lugovtsov <[email protected]> * fix docs Signed-off-by: Eugene Lugovtsov <[email protected]> Signed-off-by: Eugene Lugovtsov <[email protected]> * fix(argo-cd): deprecate server.extraArgs."--insecure" (argoproj#1669) Signed-off-by: GitHub <[email protected]> Signed-off-by: GitHub <[email protected]> * chore(argo-workflows): Support workflow retention (argoproj#1668) Signed-off-by: yu-croco <[email protected]> * feat(argo-cd): Upgrade argocd to v2.5.3 (argoproj#1671) Signed-off-by: smcavallo <[email protected]> * fix helm install md (argoproj#1672) Signed-off-by: fsl <[email protected]> Signed-off-by: fsl <[email protected]> * feat(argo-cd): Add Repo Server strict TLS cert support (argoproj#1673) Signed-off-by: Karl Parry <[email protected]> * chore(argo-workflows): Update Argo Workflows to v3.4.4 (argoproj#1674) Signed-off-by: yu-croco <[email protected]> * fix(argo-cd): Rename tls secret to include the -secret suffix (argoproj#1676) - "[Fixed]: TLS secret name so Dex correctly generates the checksum for argocd-dex-server-tls." - "[Fixed]: Standardise the naming convention of the TLS secret manifests." - "[Added]: Add checksum to Repo-Server for the argocd-repo-server-tls secret." Signed-off-by: Karl Parry <[email protected]> * chore(argo-cd): Remove duplicate ApplicationSet features (argoproj#1598) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): Add ability to annotate Deployments and StatefulSets (argoproj#1608) * feat(argo-cd): Add ability to annotate Deployments and StatefulSets Signed-off-by: John Stewart <[email protected]> * fix: Controller and AppSet controller was mixed Signed-off-by: Marco Kilchhofer <[email protected]> Signed-off-by: John Stewart <[email protected]> Signed-off-by: Marco Kilchhofer <[email protected]> Co-authored-by: Marco Kilchhofer <[email protected]> * chart update WIP * backport applicationset * backport applicationset * argocd 2.5.5 --------- Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: Filipe Santos <[email protected]> Signed-off-by: Nick Fisher <[email protected]> Signed-off-by: Ashlin Eldridge <[email protected]> Signed-off-by: Marco Kilchhofer <[email protected]> Signed-off-by: Eric Cimino <[email protected]> Signed-off-by: yu-croco <[email protected]> Signed-off-by: Dong Wang <[email protected]> Signed-off-by: Tim Van de Walle <[email protected]> Signed-off-by: Elad Dolev <[email protected]> Signed-off-by: Max Kochubey <[email protected]> Signed-off-by: Allex <[email protected]> Signed-off-by: emmayylu <[email protected]> Signed-off-by: emmayylu <[email protected]> Signed-off-by: Eugene Lugovtsov <[email protected]> Signed-off-by: GitHub <[email protected]> Signed-off-by: smcavallo <[email protected]> Signed-off-by: fsl <[email protected]> Signed-off-by: Karl Parry <[email protected]> Signed-off-by: John Stewart <[email protected]> Co-authored-by: Petr Drastil <[email protected]> Co-authored-by: Filipe <[email protected]> Co-authored-by: Nick Fisher <[email protected]> Co-authored-by: Ashlin Eldridge <[email protected]> Co-authored-by: Marco Kilchhofer <[email protected]> Co-authored-by: Eric Cimino <[email protected]> Co-authored-by: Aikawa <[email protected]> Co-authored-by: Dong Wang <[email protected]> Co-authored-by: tvandewalle <[email protected]> Co-authored-by: Elad Dolev <[email protected]> Co-authored-by: Max Kochubey <[email protected]> Co-authored-by: Allex <[email protected]> Co-authored-by: emmayylu <[email protected]> Co-authored-by: emmayylu <[email protected]> Co-authored-by: Eugene Lugovtsov <[email protected]> Co-authored-by: Zadkiel Aharonian <[email protected]> Co-authored-by: smcavallo <[email protected]> Co-authored-by: fsl <[email protected]> Co-authored-by: Karl Parry <[email protected]> Co-authored-by: John Stewart <[email protected]>
1 parent 4befcd5 commit 9591bf1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+1221
-491
lines changed

.github/dependabot.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
## Reference: https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
2+
version: 2
3+
updates:
4+
- package-ecosystem: "github-actions"
5+
directory: "/"
6+
schedule:
7+
interval: weekly
8+
day: "saturday"

.github/workflows/lint-and-test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ jobs:
2626

2727
- name: Setup Chart Linting
2828
id: lint
29-
uses: helm/[email protected].0
29+
uses: helm/[email protected].1
3030
with:
3131
# Note: Also update in scripts/lint.sh
32-
version: v3.7.0
32+
version: v3.7.1
3333

3434
- name: List changed charts
3535
id: list-changed
@@ -41,6 +41,7 @@ jobs:
4141
echo "::set-output name=changed::true"
4242
echo "::set-output name=changed_charts::$charts"
4343
fi
44+
4445
- name: Run chart-testing (lint)
4546
run: ct lint --debug --config ./.github/configs/ct-lint.yaml --target-branch ${{ github.base_ref }} --lint-conf ./.github/configs/lintconf.yaml
4647

.github/workflows/pr-title.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
name: Validate PR title
2020
runs-on: ubuntu-latest
2121
steps:
22-
- uses: amannn/action-semantic-pull-request@v4
22+
- uses: amannn/action-semantic-pull-request@v5
2323
env:
2424
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2525
with:

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ helm dependency update
9393
Minimally:
9494

9595
```
96-
helm install charts/argo-cd --namespace argocd -n argo-cd
96+
helm install argocd argo/argo-cd -n argocd --create-namespace
9797
kubectl port-forward service/argo-cd-argocd-server -n argocd 8080:443
9898
```
9999

charts/argo-cd/Chart.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
dependencies:
22
- name: redis-ha
33
repository: https://dandydeveloper.github.io/charts/
4-
version: 4.22.2
5-
digest: sha256:b6dc7774d0cc20a7a889d10e61f3dd653bdacd7836558f4875688b5cb5051d80
6-
generated: "2022-09-19T12:39:19.736045+02:00"
4+
version: 4.22.3
5+
digest: sha256:ef6269e4e073dad10c230ccfb069fc013608111c895c5e7568450bb3967cf195
6+
generated: "2022-11-03T12:04:33.673857+09:00"

charts/argo-cd/Chart.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
apiVersion: v2
2-
appVersion: v2.4.15-cap-CR-16709-init-app-proxy
2+
appVersion: v2.5.5-cap-CR-16950
33
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
44
name: argo-cd
5-
version: 5.7.0-2-CR-16709-init-app-proxy
5+
version: 5.16.0-2-cap-CR-16950
6+
kubeVersion: ">=1.22.0-0"
67
home: https://github.com/argoproj/argo-helm
78
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
89
sources:
@@ -17,11 +18,9 @@ maintainers:
1718
url: https://argoproj.github.io/
1819
dependencies:
1920
- name: redis-ha
20-
version: 4.22.2
21+
version: 4.22.3
2122
repository: https://dandydeveloper.github.io/charts/
2223
condition: redis-ha.enabled
2324
annotations:
2425
artifacthub.io/changes: |
25-
- "[Added]: Configuration sections configs.cm and configs.rbac"
26-
- "[Deprecated]: Generic configuration via server.config"
27-
- "[Deprecated]: Argo RBAC configuration via server.rbacConfig"
26+
- "[Added]: Ability to annotate Deployment and Statefulset objects for all components"

charts/argo-cd/README.md

Lines changed: 85 additions & 38 deletions
Large diffs are not rendered by default.

charts/argo-cd/README.md.gotmpl

Lines changed: 33 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This is a **community maintained** chart. This chart installs [argo-cd](https://
1010

1111
The default installation is intended to be similar to the provided Argo CD [releases](https://github.com/argoproj/argo-cd/releases).
1212

13-
If you want to avoid including sensitive information unencrypted (clear text) in your version control, make use of the [declarative set up](https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/) of Argo CD.
13+
If you want to avoid including sensitive information unencrypted (clear text) in your version control, make use of the [declarative setup] of Argo CD.
1414
For instance, rather than adding repositories and their keys in your Helm values, you could deploy [SealedSecrets](https://github.com/bitnami-labs/sealed-secrets) with contents as seen in this [repositories section](https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#repositories) or any other secrets manager service (i.e. HashiCorp Vault, AWS/GCP Secrets Manager, etc.).
1515

1616
## High Availability
@@ -41,7 +41,7 @@ repoServer:
4141
minReplicas: 2
4242

4343
applicationSet:
44-
replicas: 2
44+
replicaCount: 2
4545
```
4646

4747
### HA mode without autoscaling
@@ -60,7 +60,7 @@ repoServer:
6060
replicas: 2
6161

6262
applicationSet:
63-
replicas: 2
63+
replicaCount: 2
6464
```
6565

6666
### Synchronizing Changes from Original Repository
@@ -83,8 +83,6 @@ git diff v1.8.7 v2.0.0 -- manifests/install.yaml
8383

8484
Changes in the `CustomResourceDefinition` resources shall be fixed easily by copying 1:1 from the [`manifests/crds` folder](https://github.com/argoproj/argo-cd/tree/master/manifests/crds) into this [`charts/argo-cd/templates/crds` folder](https://github.com/argoproj/argo-helm/tree/master/charts/argo-cd/templates/crds).
8585

86-
## Upgrading
87-
8886
### Custom resource definitions
8987

9088
Some users would prefer to install the CRDs _outside_ of the chart. You can disable the CRD installation of this chart by using `--set crds.install=false` when installing the chart.
@@ -100,6 +98,32 @@ kubectl apply -k "https://github.com/argoproj/argo-cd/manifests/crds?ref=<appVer
10098
kubectl apply -k "https://github.com/argoproj/argo-cd/manifests/crds?ref=v2.4.9"
10199
```
102100

101+
## Changelog
102+
103+
For full list of changes please check ArtifactHub [changelog].
104+
105+
Highlighted versions provide information about additional steps that should be performed by user when upgrading to newer version.
106+
107+
### 5.13.0
108+
109+
This version reduces history limit for Argo CD deployment replicas to 3 to provide more visibility for Argo CD deployments that manage itself. If you need more deployment revisions for rollbacks set `global.revisionHistoryLimit` parameter.
110+
111+
### 5.12.0
112+
113+
This version deprecates the `configs.secret.argocdServerTlsConfig` option. Use `server.certificate` or `server.certificateSecret` to provide custom TLS configuration for Argo CD server.
114+
If you terminate TLS on ingress please use `argocd-server-tls` secret instead of `argocd-secret` secret.
115+
116+
### 5.10.0
117+
118+
This version hardens security by configuring default container security contexts and adds hard requirement for Kubernetes 1.22+ to work properly.
119+
The change aligns chart with officially [supported versions](https://argo-cd.readthedocs.io/en/release-2.5/operator-manual/installation/#supported-versions) by upstream project.
120+
121+
### 5.7.0
122+
123+
This version introcudes new `configs.cm` and `configs.rbac` sections that replaces `server.config` and `server.rbacConfig` respectively.
124+
Please move your current configuration to the new place. The Argo CD RBAC config now also sets defaults in the `argocd-rbac-cm`.
125+
If you have manually created this ConfigMap please ensure templating is disabled so you will not lose your changes.
126+
103127
### 5.5.20
104128

105129
This version moved API version templates into dedicated helper. If you are using these in your umbrella
@@ -312,7 +336,7 @@ server:
312336

313337
## Prerequisites
314338

315-
- Kubernetes 1.7+
339+
- {{ template "chart.kubeVersionLine" . }}
316340
- Helm v3.0.0+
317341

318342
## Installing the Chart
@@ -490,10 +514,12 @@ Autogenerated from chart metadata using [helm-docs](https://github.com/norwoodj/
490514
[affinity]: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
491515
[BackendConfigSpec]: https://cloud.google.com/kubernetes-engine/docs/concepts/backendconfig#backendconfigspec_v1beta1_cloudgooglecom
492516
[CSS styles]: https://argo-cd.readthedocs.io/en/stable/operator-manual/custom-styles/
517+
[changelog]: https://artifacthub.io/packages/helm/argo/argo-cd?modal=changelog
493518
[external cluster credentials]: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#clusters
494519
[FrontendConfigSpec]: https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features#configuring_ingress_features_through_frontendconfig_parameters
495-
[Declarative setup]: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup
520+
[declarative setup]: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup
496521
[gRPC-ingress]: https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/
522+
[GnuPG]: https://argo-cd.readthedocs.io/en/stable/user-guide/gpg-verification/
497523
[HPA]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
498524
[MetricRelabelConfigs]: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs
499525
[Node selector]: https://kubernetes.io/docs/user-guide/node-selection/

charts/argo-cd/templates/NOTES.txt

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,42 @@ DEPRECATED option server.logFormat - Use configs.params.server.log.format
2828
{{- if .Values.server.logLevel }}
2929
DEPRECATED option server.logLevel - Use configs.params.server.log.level
3030
{{- end }}
31+
{{- if has "--insecure" .Values.server.extraArgs }}
32+
DEPRECATED option server.extraArgs."--insecure" - Use configs.params.server.insecure
33+
{{- end }}
3134
{{- if .Values.repoServer.logFormat }}
3235
DEPRECATED option repoServer.logFormat - Use configs.params.repoServer.log.format
3336
{{- end }}
3437
{{- if .Values.repoServer.logLevel }}
3538
DEPRECATED option repoServer.logLevel - Use configs.params.repoServer.log.level
3639
{{- end }}
37-
{{- if or .Values.server.config .Values.server.configEnabled .Values.server.configAnnotations }}
40+
{{- if or .Values.server.config (hasKey .Values.server "configEnabled") .Values.server.configAnnotations }}
3841
DEPRECATED option server.config - Use configs.cm
3942
{{- end }}
40-
{{- if or .Values.server.rbacConfig .Values.server.rbacConfigCreate .Values.server.rbacConfigAnnotations }}
43+
{{- if or .Values.server.rbacConfig (hasKey .Values.server "rbacConfigCreate") .Values.server.rbacConfigAnnotations }}
4144
DEPRECATED option server.rbacConfig - Use configs.rbac
4245
{{- end }}
46+
{{- if .Values.configs.secret.argocdServerTlsConfig }}
47+
DEPRECATED option config.secret.argocdServerTlsConfig - Use server.certificate or server.certificateSecret
48+
{{- end }}
49+
{{- if .Values.configs.gpgKeys }}
50+
DEPRECATED option configs.gpgKeys - Use config.gpg.keys
51+
{{- end }}
52+
{{- if .Values.configs.gpgKeysAnnotations }}
53+
DEPRECATED option configs.gpgKeysAnnotations - Use config.gpg.annotations
54+
{{- end }}
4355
{{- if .Values.controller.service }}
4456
REMOVED option controller.service - Use controller.metrics
4557
{{- end }}
4658
{{- if .Values.repoServer.copyutil }}
4759
REMOVED option repoSever.copyutil.resources - Use repoServer.resources
4860
{{- end }}
61+
{{- if .Values.applicationSet.args.debug }}
62+
REMOVED option applicationSet.args.debug - Use applicationSet.logLevel: debug
63+
{{- end }}
64+
{{- if .Values.applicationSet.args.enableLeaderElection }}
65+
REMOVED option applicationSet.args.enableLeaderElection - Value determined based on replicas
66+
{{- end }}
4967

5068
In order to access the server UI you have the following options:
5169

@@ -58,14 +76,14 @@ In order to access the server UI you have the following options:
5876
- Set the `configs.params."server.insecure"` in the values file and terminate SSL at your ingress: https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/#option-2-multiple-ingress-objects-and-hosts
5977

6078

61-
{{ if eq (index (coalesce .Values.server.config .Values.configs.cm) "admin.enabled") "true" -}}
79+
{{ if eq (toString (index (coalesce .Values.server.config .Values.configs.cm) "admin.enabled")) "true" -}}
6280
After reaching the UI the first time you can login with username: admin and the random password generated during the installation. You can find the password by running:
6381

6482
kubectl -n {{ .Release.Namespace }} get secret argocd-initial-admin-secret -o jsonpath="{.data.password}" | base64 -d
6583

6684
(You should delete the initial secret afterwards as suggested by the Getting Started Guide: https://argo-cd.readthedocs.io/en/stable/getting_started/#4-login-using-the-cli)
67-
{{ else if or (index .Values.server.config "dex.config") (index .Values.server.config "oidc.config") -}}
85+
{{ else if or (index .Values.configs.cm "dex.config") (index .Values.configs.cm "oidc.config") -}}
6886
After reaching the UI the first time you can login using Dex or OIDC.
6987
{{ else -}}
70-
After reaching the UI the first time you cannot login with username and password since you've disabled it. You should enable admin back or configure Dex via `server.config.dex.config` or OIDC via `server.config.oidc.config`.
88+
After reaching the UI the first time you cannot login with username and password since you've disabled it. You should enable admin back or configure Dex via `configs.cm.dex.config` or OIDC via `configs.cm.oidc.config`.
7189
{{ end -}}

charts/argo-cd/templates/_helpers.tpl

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,17 @@ Create dex name and version as used by the chart label.
1515
{{- printf "%s-%s" (include "argo-cd.fullname" .) .Values.dex.name | trunc 63 | trimSuffix "-" -}}
1616
{{- end -}}
1717

18+
{{/*
19+
Create Dex server endpoint
20+
*/}}
21+
{{- define "argo-cd.dex.server" -}}
22+
{{- $insecure := index .Values.configs.params "dexserver.disable.tls" | toString -}}
23+
{{- $scheme := (eq $insecure "true") | ternary "http" "https" -}}
24+
{{- $host := include "argo-cd.dex.fullname" . -}}
25+
{{- $port := int .Values.dex.servicePortHttp -}}
26+
{{- printf "%s://%s:%d" $scheme $host $port }}
27+
{{- end }}
28+
1829
{{/*
1930
Create redis name and version as used by the chart label.
2031
*/}}
@@ -171,21 +182,25 @@ ui.cssurl: "./custom/custom.styles.css"
171182
Merge Argo Configuration with Preset Configuration
172183
*/}}
173184
{{- define "argo-cd.config.cm" -}}
174-
{{- $config := coalesce .Values.server.config (omit .Values.configs.cm "create" "annotations") -}}
185+
{{- $config := (mergeOverwrite (deepCopy (omit .Values.configs.cm "create" "annotations")) (.Values.server.config | default dict)) -}}
175186
{{- $preset := include "argo-cd.config.cm.presets" . | fromYaml | default dict -}}
176-
{{- mergeOverwrite $preset $config | toYaml }}
187+
{{- range $key, $value := mergeOverwrite $preset $config }}
188+
{{ $key }}: {{ toString $value | toYaml }}
189+
{{- end }}
177190
{{- end -}}
178191

179192
{{/*
180193
Argo Params Default Configuration Presets
181194
*/}}
182195
{{- define "argo-cd.config.params.presets" -}}
183196
repo.server: "{{ include "argo-cd.repoServer.fullname" . }}:{{ .Values.repoServer.service.port }}"
197+
server.repo.server.strict.tls: {{ .Values.repoServer.certificateSecret.enabled | toString }}
184198
{{- with include "argo-cd.redis.server" . }}
185199
redis.server: {{ . | quote }}
186200
{{- end }}
187201
{{- if .Values.dex.enabled }}
188-
server.dex.server: "http://{{ include "argo-cd.dex.fullname" . }}:{{ .Values.dex.servicePortHttp }}"
202+
server.dex.server: {{ include "argo-cd.dex.server" . | quote }}
203+
server.dex.server.strict.tls: {{ .Values.dex.certificateSecret.enabled | toString }}
189204
{{- end }}
190205
{{- range $component := tuple "controller" "server" "reposerver" }}
191206
{{ $component }}.log.format: {{ $.Values.global.logging.format | quote }}
@@ -198,8 +213,8 @@ Merge Argo Params Configuration with Preset Configuration
198213
*/}}
199214
{{- define "argo-cd.config.params" -}}
200215
{{- $config := omit .Values.configs.params "annotations" }}
201-
{{- $preset := include "argo-cd.config.params.presets" $ | fromYaml | default dict -}}
216+
{{- $preset := include "argo-cd.config.params.presets" . | fromYaml | default dict -}}
202217
{{- range $key, $value := mergeOverwrite $preset $config }}
203-
{{ $key }}: {{ $value | quote }}
218+
{{ $key }}: {{ toString $value | toYaml }}
204219
{{- end }}
205220
{{- end -}}

0 commit comments

Comments
 (0)