fix(argo-cd): Rename tls secret to include the -secret suffix (argoproj#1676)

- "[Fixed]: TLS secret name so Dex correctly generates the checksum for argocd-dex-server-tls."
- "[Fixed]: Standardise the naming convention of the TLS secret manifests."
- "[Added]: Add checksum to Repo-Server for the argocd-repo-server-tls secret."

Signed-off-by: Karl Parry <[email protected]>

Author: karlparry

charts/argo-cd/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: v2.5.3
 kubeVersion: ">=1.22.0-0"
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 5.15.0
+version: 5.15.1
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 sources:
@@ -23,4 +23,6 @@ dependencies:
     condition: redis-ha.enabled
 annotations:
   artifacthub.io/changes: |
-    - "[Added]: Ability to deploy argocd-repo-server-server-tls secret and configure Strict TLS for Repo Server"
+    - "[Fixed]: TLS secret name so Dex correctly generates the checksum for argocd-dex-server-tls."
+    - "[Fixed]: Standardise the naming convention of the TLS secret manifests."
+    - "[Added]: Add checksum to Repo-Server for the argocd-repo-server-tls secret."

…gocd-configs/argocd-repo-server-tls.yaml …nfigs/argocd-repo-server-tls-secret.yamlcharts/argo-cd/templates/argocd-configs/argocd-repo-server-tls.yaml renamed to charts/argo-cd/templates/argocd-configs/argocd-repo-server-tls-secret.yaml charts/argo-cd/templates/argocd-configs/argocd-repo-server-tls.yaml renamed to charts/argo-cd/templates/argocd-configs/argocd-repo-server-tls-secret.yaml

@@ -16,6 +16,9 @@ spec:
     metadata:
       annotations:
         checksum/cmd-params: {{ include (print $.Template.BasePath "/argocd-configs/argocd-cmd-params-cm.yaml") . | sha256sum }}
+        {{- if .Values.repoServer.certificateSecret.enabled }}
+        checksum/repo-server-tls: {{ include (print $.Template.BasePath "/argocd-configs/argocd-repo-server-tls-secret.yaml") . | sha256sum }}
+        {{- end }}
         {{- with (mergeOverwrite (deepCopy .Values.global.podAnnotations) .Values.repoServer.podAnnotations) }}
         {{- range $key, $value := . }}
         {{ $key }}: {{ $value | quote }}

…es/argocd-configs/argocd-server-tls.yaml …cd-configs/argocd-server-tls-secret.yamlcharts/argo-cd/templates/argocd-configs/argocd-server-tls.yaml renamed to charts/argo-cd/templates/argocd-configs/argocd-server-tls-secret.yaml charts/argo-cd/templates/argocd-configs/argocd-server-tls.yaml renamed to charts/argo-cd/templates/argocd-configs/argocd-server-tls-secret.yaml

@@ -16,7 +16,7 @@ spec:
       annotations:
         checksum/cmd-params: {{ include (print $.Template.BasePath "/argocd-configs/argocd-cmd-params-cm.yaml") . | sha256sum }}
         {{- if .Values.dex.certificateSecret.enabled }}
-        checksum/dex-server-tls: {{ include (print $.Template.BasePath "/argocd-configs/argocd-dex-server-tls.yaml") . | sha256sum }}
+        checksum/dex-server-tls: {{ include (print $.Template.BasePath "/argocd-configs/argocd-dex-server-tls-secret.yaml") . | sha256sum }}
         {{- end }}
         {{- with (mergeOverwrite (deepCopy .Values.global.podAnnotations) .Values.dex.podAnnotations) }}
         {{- range $key, $value := . }}