Skip to content

Commit ee508fe

Browse files
jaimephyu-croco
andauthored
fix(argo-rollouts): Add subscriptions into notifcations-configmap (argoproj#2793)
* fix(argo-rollouts): Add subscriptions into notifcations-configmap Signed-off-by: Jaime Pérez Halcón <[email protected]> * fix(argo-rollouts): Set version Signed-off-by: Jaime Pérez Halcón <[email protected]> * fix(argo-rollouts): Updated readme Signed-off-by: Jaime Pérez Halcón <[email protected]> * fix(values.yaml): fixed trailing spaces Signed-off-by: Jaime Pérez Halcón <[email protected]> --------- Signed-off-by: Jaime Pérez Halcón <[email protected]> Co-authored-by: Aikawa <[email protected]>
1 parent 7b30c3b commit ee508fe

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

charts/argo-rollouts/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
appVersion: v1.7.0
33
description: A Helm chart for Argo Rollouts
44
name: argo-rollouts
5-
version: 2.36.1
5+
version: 2.36.2
66
home: https://github.com/argoproj/argo-helm
77
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
88
keywords:
@@ -19,4 +19,4 @@ annotations:
1919
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2020
artifacthub.io/changes: |
2121
- kind: changed
22-
description: Add annotations for notifications secret
22+
description: Add subscriptions into notifications-configmap

charts/argo-rollouts/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ For full list of changes please check ArtifactHub [changelog].
6161
| notifications.secret.annotations | object | `{}` | Annotations to be added to the notifications secret |
6262
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
6363
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
64+
| notifications.subscriptions | object | `{}` | The subscriptions define the subscriptions to the triggers in a general way for all rollouts |
6465
| notifications.templates | object | `{}` | Notification templates |
6566
| notifications.triggers | object | `{}` | The trigger defines the condition when the notification should be sent |
6667
| providerRBAC.additionalRules | list | `[]` | Additional RBAC rules for others providers |

charts/argo-rollouts/templates/controller/notifcations-configmap.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,7 @@ data:
1616
{{- with .Values.notifications.triggers }}
1717
{{- toYaml . | nindent 2 }}
1818
{{- end }}
19+
{{- with .Values.notifications.subscriptions }}
20+
subscriptions:
21+
{{- toYaml . | nindent 4 }}
22+
{{- end }}

charts/argo-rollouts/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,3 +479,11 @@ notifications:
479479
# trigger.on-purple: |
480480
# - send: [my-purple-template]
481481
# when: rollout.spec.template.spec.containers[0].image == 'argoproj/rollouts-demo:purple'
482+
483+
# -- The subscriptions define the subscriptions to the triggers in a general way for all rollouts
484+
subscriptions: {}
485+
# subscriptions:
486+
# recipients:
487+
# - slack:<channel>
488+
# triggers:
489+
# - on-rollout-completed

0 commit comments

Comments
 (0)