Skip to content

Commit 197f9db

Browse files
agrawrohdanielm-codefresh
authored andcommitted
fix(e2e): DeFlake E2E Tests argoproj#1647 (argoproj#1648)
Signed-off-by: Rohit Agrawal <[email protected]>
1 parent d6131a6 commit 197f9db

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ DEV_IMAGE=false
2121
# E2E variables
2222
E2E_INSTANCE_ID ?= argo-rollouts-e2e
2323
E2E_TEST_OPTIONS ?=
24-
E2E_PARALLEL ?= 1
24+
E2E_PARALLEL ?= 4
2525

2626
override LDFLAGS += \
2727
-X ${PACKAGE}/utils/version.version=${VERSION} \
@@ -244,7 +244,7 @@ start-e2e:
244244

245245
.PHONY: test-e2e
246246
test-e2e:
247-
go test -timeout 20m -v -count 1 --tags e2e -p ${E2E_PARALLEL} --short ./test/e2e ${E2E_TEST_OPTIONS}
247+
go test -timeout 30m -v -count 1 --tags e2e -p ${E2E_PARALLEL} --short ./test/e2e ${E2E_TEST_OPTIONS}
248248

249249
.PHONY: coverage
250250
coverage: test

test/e2e/analysis_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build e2e
12
// +build e2e
23

34
package e2e
@@ -450,6 +451,7 @@ spec:
450451
args: null
451452
`).
452453
WaitForRolloutStatus("Paused").
454+
Sleep(2*time.Second). // Give some time before validating the scaling down event
453455
Then().
454456
ExpectRevisionPodCount("1", 1).
455457
ExpectRevisionScaleDown("2", true).
@@ -459,6 +461,7 @@ spec:
459461
When().
460462
PromoteRollout().
461463
WaitForRolloutStatus("Healthy").
464+
Sleep(2*time.Second). // Give some time before validating the scaling down event
462465
Then().
463466
ExpectRevisionPodCount("1", 1).
464467
ExpectRevisionScaleDown("1", true).
@@ -714,6 +717,7 @@ func (s *AnalysisSuite) TestBackgroundAnalysisWithArgs() {
714717
When().
715718
UpdateSpec().
716719
WaitForRolloutStatus("Paused").
720+
Sleep(3 * time.Second). // Give some time before validating that AnalysisRun got kicked off
717721
Then().
718722
ExpectAnalysisRunCount(1).
719723
ExpectBackgroundAnalysisRunPhase("Running").

0 commit comments

Comments
 (0)