Merge pull request #18 from codefresh-io/CR-7557-sync-v1.1.0

Cr 7557 sync v1.1.0

Author: ilyagorban-codefresh

.github/workflows/docker-publish.yml

@@ -3,7 +3,7 @@ name: Docker
 on:
   push:
     branches:
-      - master
+      # - master  # commented due to Codefresh convention
       - release-*
 
   # Run tests for any PRs.
@@ -37,31 +37,33 @@ jobs:
         with:
           images: |
             quay.io/codefresh/argo-rollouts
-            ghcr.io/codefresh-io/argo-rollouts
+          # ghcr.io/codefresh-io/argo-rollouts
           tags: |
             type=ref,event=branch
-          flavor: |
-            latest=${{ github.ref == 'refs/heads/master' }}
+          # commented due to  Codefresh convention
+          # flavor: |
+          #   latest=${{ github.ref == 'refs/heads/master' }}
 
       - name: Docker meta (plugin)
         id: plugin-meta
         uses: docker/metadata-action@v3
         with:
           images: |
             quay.io/codefresh/kubectl-argo-rollouts
-            ghcr.io/codefresh-io/kubectl-argo-rollouts
+          # ghcr.io/codefresh-io/kubectl-argo-rollouts
           tags: |
             type=ref,event=branch
-          flavor: |
-            latest=${{ github.ref == 'refs/heads/master' }}
+          # commented due to  Codefresh convention
+          # flavor: |
+          #   latest=${{ github.ref == 'refs/heads/master' }}
 
-      - name: Login to GitHub Container Registry
-        if: github.event_name != 'pull_request'
-        uses: docker/login-action@v1
-        with:
-          registry: ghcr.io
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+      # - name: Login to GitHub Container Registry
+      #   if: github.event_name != 'pull_request'
+      #   uses: docker/login-action@v1
+      #   with:
+      #     registry: ghcr.io
+      #     username: ${{ github.repository_owner }}
+      #     password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Login to Quay.io
         if: github.event_name != 'pull_request'

.github/workflows/e2e.yaml

@@ -3,12 +3,19 @@ name: E2E Tests
 on:
   push:
     branches:
-      - 'master'
+      # - 'master' # commented due to Codefresh convention
       - 'release-*'
   pull_request:
     branches:
-      - 'master'
+      # - 'master' # commented due to Codefresh convention
       - 'release-*'
+  workflow_dispatch:
+    inputs:
+      debug_enabled:
+        description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)'
+        required: false
+        default: false
+
 jobs:
   test-e2e:
     name: Run end-to-end tests
@@ -35,6 +42,16 @@ jobs:
           kubectl apply -k  manifests/crds
           kubectl apply -f  test/e2e/crds
       - name: Start controller
-        run: make start-e2e &
+        run: make start-e2e 2>&1 | sed -r "s/[[:cntrl:]]\[[0-9]{1,3}m//g" > /tmp/e2e-controller.log &
+      - name: Setup tmate session
+        uses: mxschmitt/action-tmate@v3
+        if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled}}
       - name: Run e2e tests
         run: make test-e2e
+        if: ${{ !(github.event_name == 'workflow_dispatch' && github.event.inputs.debug_enabled) }}
+      - name: Upload e2e-controller logs
+        uses: actions/upload-artifact@v2
+        with:
+          name: e2e-controller-k8s.log
+          path: /tmp/e2e-controller.log
+        if: ${{ failure() }}

.github/workflows/gh-pages.yaml

@@ -20,7 +20,7 @@ jobs:
       - name: build
         run: |
           pip install mkdocs mkdocs_material
-          make plugin-docs
+          make docs
           mkdocs build
       - name: Deploy
         uses: peaceiris/actions-gh-pages@v3

.github/workflows/go.yml

@@ -2,11 +2,12 @@ name: Go
 on:
   push:
     branches:
-      - "master"
-      - "release-*"
+      # - "master"
+      - "release-*" # Codefresh convention
   pull_request:
     branches:
-      - "master"
+      # - "master"
+      - "release-*" # Codefresh convention
 jobs:
   lint-go:
     name: Lint Go code
@@ -55,7 +56,7 @@ jobs:
           path: coverage.out
 
       - name: Upload code coverage information to codecov.io
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v2.0.3
         with:
           file: coverage.out
 
@@ -133,6 +134,7 @@ jobs:
         run: |
           make codegen
           make manifests
+          make docs
 
       - name: Ensure nothing changed
         run: git diff --exit-code

.github/workflows/release.yaml

@@ -44,7 +44,7 @@ jobs:
         with:
           images: |
             quay.io/codefresh/argo-rollouts
-            ghcr.io/codefresh-io/argo-rollouts
+          # ghcr.io/codefresh-io/argo-rollouts
           tags: |
             type=semver,pattern={{version}},prefix=v,value=${{ github.event.inputs.tag }}
           flavor: |
@@ -56,19 +56,19 @@ jobs:
         with:
           images: |
             quay.io/codefresh/kubectl-argo-rollouts
-            ghcr.io/codefresh-io/kubectl-argo-rollouts
+         #  ghcr.io/codefresh-io/kubectl-argo-rollouts
           tags: |
             type=semver,pattern={{version}},prefix=v,value=${{ github.event.inputs.tag }}
           flavor: |
             latest=false
 
-      - name: Login to GitHub Container Registry
-        if: github.event_name != 'pull_request'
-        uses: docker/login-action@v1
-        with:
-          registry: ghcr.io
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+      # - name: Login to GitHub Container Registry
+      #   if: github.event_name != 'pull_request'
+      #   uses: docker/login-action@v1
+      #   with:
+      #     registry: ghcr.io
+      #     username: ${{ github.repository_owner }}
+      #     password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Login to Quay.io
         if: github.event_name != 'pull_request'
@@ -129,7 +129,10 @@ jobs:
           files: |
             dist/kubectl-argo-rollouts-linux-amd64
             dist/kubectl-argo-rollouts-darwin-amd64
+            dist/kubectl-argo-rollouts-windows-amd64
             manifests/install.yaml
             manifests/namespace-install.yaml
+            manifests/notifications-install.yaml
+            docs/features/kustomize/rollout_cr_schema.json
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -4,6 +4,7 @@
 dist/
 *.iml
 # delve debug binaries
+__debug_bin
 cmd/**/debug
 debug.test
 coverage.out

CHANGELOG.md

@@ -1,5 +1,159 @@
 # Changelog
 
+# v1.1.0
+
+## Notable Features
+* Rollout Notifications
+* Dynamic scaling of stable ReplicaSet (dynamicStableScale)
+* Automated rollbacks without analysis (progressDeadlineAbort)
+* Kustomize Open API Schema
+* Rollout Dashboard as a Service
+* Controlling Scaledown Behavior During Aborts (abortScaleDownDelaySeconds)
+* Analysis: AWS CloudWatch Metric Provider
+* AWS TargetGroup IP Verification
+* Weighted Experiment Canary Steps
+* Istio: Multicluster Support
+* Istio: TLS Route Support
+* Istio: Multiple VirtualServices
+* AnalysisRun GC
+* Analysis: Graphite Metric Provider
+
+## Changes since v1.0
+
+### Controller
+* feat: support dynamic scaling of stable ReplicaSet as inverse of canary weight (#1430)
+* fix: promote nil pointer error when there are no steps (#1510)
+* feat: support management of multiple Istio VirtualService objects (#1381)
+* feat: verify AWS TargetGroup after updating active/stable services (#1348)
+* feat: ALB TrafficRouting with experiment step
+* feat: TrafficRouting SMI with Experiment Step in Canary (#1351)
+* feat: ability to abort an update when exceeding progressDeadlineSeconds (#1397)
+* feat: add support for Istio VirtualService spec.tls[] (#1380)
+* feat: configurable and more aggressive cleanup of old AnalysisRuns and Experiments (#1342)
+* feat: ability to auto-create Services for each template in an Experiment (#1158)
+* feat: introduce abortScaleDownDelaySeconds to control scale down of preview/canary upon abort (#1160)
+* feat: argo rollout compatibility with emissary and edge stack v2.0 (#1330)
+* feat: Add support for Istio multicluster (#1274)
+* feat: add workload-ref/generation to rollout (#1198)
+* feat: support notifications on rollout events using notifications-engine (#1175)
+* chore: add liveness and readiness probe to the install manifests (#1324)
+* fix: Nginx ingressClassName passed to canary ingress (#1448)
+* fix: canary scaledown event could violate maxUnavailable (#1429)
+* fix: analysis runs to wait for all metrics to complete (#1407)
+* fix: Promote full did not work against BlueGreen with previewReplicaCount (#1384)
+* fix: retarget blue-green previewService before scaling up preview ReplicaSet (#1368)
+* fix: zero-value abortScaleDownDelay was not honored with setCanaryScale (#1375)
+* fix: abort scaledown stable RS for canary with traffic routing (#1331)
+
+### Analysis
+* feat: add support for Graphite metrics provider (#1406)
+* feat: Support CloudWatch as a metric provider (#1338)
+* fix: Analysis argument validation (#1412)
+
+### Plugin
+* feat: create windows version for CLI (#1517)
+* feat: provide shell completion. Closes #619 (#1478)
+* fix: create analysisrun cmd using template generated name (#1471)
+* fix: nil pointer in create analysisrun cmd (#1399)
+* fix: lint subcommand for workload ref rollout (#1328)
+* fix: undo referenced object for workloadRef rollout (#1275)
+
+### Dashboard
+* feat: allow selection of namespace in rollout dashboard (#1291)
+* fix(ui): UI crashes on rollout view due to undefined status (#1287)
+
+### Misc
+* feat: kustomize rollout: add openapi to doc and examples (#1371)
+* feat: add rollout stat row to grafana dashboard (#1343)
+
+## Upgrade Notes
+### Difference in scale down behavior during aborts
+
+The v1.1 `abortScaleDownDelaySeconds` feature now allows users full control over the scaling
+behavior of the canary/preview ReplicaSet during an abort. Previously in v1.0, it was not possible
+to affect this behavior. As part of this feature, v1.1 also fixes some inconsistencies in behavior
+with respect to abort scale down.
+
+The most notable change is that upon an abort, the blue-green preview ReplicaSet in v1.1 will now
+scale down 30 seconds after the abort, whereas in v1.0 the preview ReplicaSet was left running
+indefinitely (without any option to scale it down). If you prefer the v1.0 behavior, you can set
+`abortScaleDownDelaySeconds: 0`, which will leave the preview ReplicaSet running indefinitely
+on abort:
+
+```yaml
+spec:
+  strategy:
+     blueGreen:
+       abortScaleDownDelaySeconds: 0
+```
+
+Please read the full
+[documentation](https://argoproj.github.io/argo-rollouts/features/scaledown-aborted-rs/) to understand
+the differences in canary/preview scaling behavior for aborted Rollouts from v1.0 to v1.1.
+
+# v1.0.6
+## Changes since v1.0.4
+
+### Bug Fixes
+
+- fix: replica count for new deployment (#1449)
+- fix: Nginx ingressClassName passed to canary ingress (#1448)
+- fix: Analysis argument validation (#1412)
+- fix: retarget blue-green previewService before scaling up preview ReplicaSet (#1368)
+- fix: analysis runs to wait for all metrics to complete (#1407)
+- fix: canary scaledown event could violate maxUnavailable (#1429)
+- chore: release workflow docker build context should use local path and not git context (#1388)
+- chore: github release action was using incorect docker cache (#1387)
+
+# v1.0.4
+## Changes since v1.0.3
+
+### Controller
+* fix: Promote full did not work against BlueGreen with previewReplicaCount
+
+# v1.0.3
+
+## Changes since v1.0.2
+
+### Controller
+
+* fix: nil pointer dereference when reconciling paused blue-green rollout (#1378)
+* fix: Abort rollout doesn't remove all canary pods for setCanaryScale (#1352)
+* fix: unsolicited rollout after upgrade from v0.10->v1.0 when pod was using service account (#1367)
+* fix: default replica before resolving workloadRef (#1304)
+
+# v1.0.2
+
+## Changes since v1.0.1
+
+### Controller
+
+* feat: allow VirtualService HTTPRoute to be inferred if there is single route (#1273)
+* fix: rollout paused longer than progressDeadlineSeconds would briefly degrade (#1268)
+* fix: controller would drop fields when updating DestinationRules (#1253)
+* fix: the wrong panel title on the sample dashboard (#1260)
+* fix: analysis with multiple metrics (#1261)
+* fix: Mitigate the bug where items are re-added constantly to the workqueue. #1193 (#1243)
+* fix: workload rollout spec is invalid template is not empty (#1224)
+* fix: Fix error check in validation for AnalysisTemplates not found (#1249)
+* fix: make function call consistent with otherRSs definition (#1171)
+
+### Plugin
+
+* fix: avoid using root user in plugin container (#1256)
+
+
+# v1.0.1
+
+## Changes since v1.0.0
+
+### Controller
+
+* feat: WebMetric to support string body responses (#1212)
+* fix: Modify validation to check Analysis args passed through RO spec (#1215)
+* fix: AnalysisRun args could not be resolved from secret (#1213)
+
+
 # v1.0.0
 
 ## Notable Features

Dockerfile

@@ -63,7 +63,7 @@ RUN touch ui/dist/node_modules.marker && \
     touch ui/dist/app/index.html && \
     find ui/dist
 
-ARG MAKE_TARGET="controller plugin-linux plugin-darwin"
+ARG MAKE_TARGET="controller plugin-linux plugin-darwin plugin-windows"
 RUN make ${MAKE_TARGET}
 
 ####################################################################################################

Dockerfile.dev

@@ -1,6 +1,20 @@
 ####################################################################################################
 # argo-rollouts-dev
 ####################################################################################################
-FROM scratch
-COPY dist/rollouts-controller-linux-amd64 /bin/rollouts-controller
+FROM golang:1.16.3 as builder
+
+RUN apt-get update && apt-get install -y \
+    ca-certificates && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
+
+FROM scratch    
+
+COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
+COPY rollouts-controller-linux-amd64 /bin/rollouts-controller
+
+# Use numeric user, allows kubernetes to identify this user as being
+# non-root when we use a security context with runAsNonRoot: true
+USER 999
+
 ENTRYPOINT [ "/bin/rollouts-controller" ]