fix(analysis): surface analysis validation failure to rollout status (argoproj#1833)

Signed-off-by: Hui Kang <[email protected]>

Author: cskh

pkg/apis/rollouts/validation/validation_references.go

@@ -133,6 +133,18 @@ func ValidateAnalysisTemplatesWithType(rollout *v1alpha1.Rollout, templates Anal
 		return allErrs
 	}
 
+	if rollout.Spec.Strategy.Canary != nil {
+		for _, step := range rollout.Spec.Strategy.Canary.Steps {
+			if step.Analysis != nil {
+				_, err := analysisutil.NewAnalysisRunFromTemplates(templates.AnalysisTemplates, templates.ClusterAnalysisTemplates, buildAnalysisArgs(templates.Args, rollout), step.Analysis.DryRun, step.Analysis.MeasurementRetention, "", "", "")
+				if err != nil {
+					allErrs = append(allErrs, field.Invalid(fldPath, value, err.Error()))
+					return allErrs
+				}
+			}
+		}
+	}
+
 	for _, template := range templates.AnalysisTemplates {
 		allErrs = append(allErrs, ValidateAnalysisTemplateWithType(rollout, template, nil, templates.TemplateType, fldPath)...)
 	}

pkg/apis/rollouts/validation/validation_references_test.go

@@ -256,6 +256,39 @@ func TestValidateAnalysisTemplatesWithType(t *testing.T) {
 		assert.Empty(t, allErrs)
 	})
 
+	t.Run("failure - duplicate MeasurementRetention", func(t *testing.T) {
+		rollout := getRollout()
+		rollout.Spec.Strategy.Canary.Steps = append(rollout.Spec.Strategy.Canary.Steps, v1alpha1.CanaryStep{
+			Analysis: &v1alpha1.RolloutAnalysis{
+				Templates: []v1alpha1.RolloutAnalysisTemplate{
+					{
+						TemplateName: "analysis-template-name",
+					},
+				},
+				MeasurementRetention: []v1alpha1.MeasurementRetention{
+					{
+						MetricName: "example",
+						Limit:      2,
+					},
+				},
+			},
+		})
+		templates := getAnalysisTemplatesWithType()
+		templates.AnalysisTemplates[0].Spec.Args = append(templates.AnalysisTemplates[0].Spec.Args, v1alpha1.Argument{Name: "valid"})
+		templates.AnalysisTemplates[0].Spec.MeasurementRetention = []v1alpha1.MeasurementRetention{
+			{
+				MetricName: "example",
+				Limit:      5,
+			},
+		}
+		templates.Args = []v1alpha1.AnalysisRunArgument{{Name: "valid", Value: "true"}}
+
+		allErrs := ValidateAnalysisTemplatesWithType(rollout, templates)
+		assert.Len(t, allErrs, 1)
+		msg := fmt.Sprintf("spec.strategy.canary.steps[0].analysis.templates: Invalid value: \"templateNames: [analysis-template-name cluster-analysis-template-name]\": two Measurement Retention metric rules have the same name 'example'")
+		assert.Equal(t, msg, allErrs[0].Error())
+	})
+
 }
 
 func TestValidateAnalysisTemplateWithType(t *testing.T) {