Skip to content

Commit 72f85a6

Browse files
authored
fix: remove unused code of crd generation (argoproj#1288)
Signed-off-by: Hui Kang <[email protected]>
1 parent 6900988 commit 72f85a6

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

hack/gen-crd-spec/main.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,6 @@ func removeK8S118Fields(un *unstructured.Unstructured) {
253253
// Replace this with "spec.template.spec.volumes[].ephemeral.volumeClaimTemplate.spec.resources.{limits/requests}"
254254
// when it's ok to only support k8s 1.17+
255255
setValidationOverride(un, preserveUnknownFields, "spec.template.spec.volumes")
256-
validation, _, _ := unstructured.NestedMap(un.Object, "spec", "validation", "openAPIV3Schema")
257-
removeFieldHelper(validation, "x-kubernetes-list-type")
258-
removeFieldHelper(validation, "x-kubernetes-list-map-keys")
259-
unstructured.SetNestedMap(un.Object, validation, "spec", "validation", "openAPIV3Schema")
260256
case "Experiment":
261257
setValidationOverride(un, preserveUnknownFields, "spec.templates[].template.spec.containers[].resources.limits")
262258
setValidationOverride(un, preserveUnknownFields, "spec.templates[].template.spec.containers[].resources.requests")
@@ -267,10 +263,6 @@ func removeK8S118Fields(un *unstructured.Unstructured) {
267263
// Replace this with "spec.templates[].template.spec.volumes[].ephemeral.volumeClaimTemplate.spec.resources.{limits/requests}"
268264
// when it's ok to only support k8s 1.17+
269265
setValidationOverride(un, preserveUnknownFields, "spec.templates[].template.spec.volumes")
270-
validation, _, _ := unstructured.NestedMap(un.Object, "spec", "validation", "openAPIV3Schema")
271-
removeFieldHelper(validation, "x-kubernetes-list-type")
272-
removeFieldHelper(validation, "x-kubernetes-list-map-keys")
273-
unstructured.SetNestedMap(un.Object, validation, "spec", "validation", "openAPIV3Schema")
274266
case "ClusterAnalysisTemplate", "AnalysisTemplate", "AnalysisRun":
275267
setValidationOverride(un, preserveUnknownFields, "spec.metrics[].provider.job.spec.template.spec.containers[].resources.limits")
276268
setValidationOverride(un, preserveUnknownFields, "spec.metrics[].provider.job.spec.template.spec.containers[].resources.requests")
@@ -281,10 +273,6 @@ func removeK8S118Fields(un *unstructured.Unstructured) {
281273
// Replace this with "spec.metrics[].provider.job.spec.template.spec.volumes[].ephemeral.volumeClaimTemplate.spec.resources.{limits/requests}"
282274
// when it's ok to only support k8s 1.17+
283275
setValidationOverride(un, preserveUnknownFields, "spec.metrics[].provider.job.spec.template.spec.volumes")
284-
validation, _, _ := unstructured.NestedMap(un.Object, "spec", "validation", "openAPIV3Schema")
285-
removeFieldHelper(validation, "x-kubernetes-list-type")
286-
removeFieldHelper(validation, "x-kubernetes-list-map-keys")
287-
unstructured.SetNestedMap(un.Object, validation, "spec", "validation", "openAPIV3Schema")
288276
default:
289277
panic(fmt.Sprintf("unknown kind: %s", kind))
290278
}

0 commit comments

Comments
 (0)