Merge branch 'master' into release-3.4

Signed-off-by: Saravanan Balasubramanian <[email protected]>

Author: sarabala1979

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,48 @@
+name: Reproducible bug report
+description: Create a reproducible bug report. Not for support requests.
+labels: [ bug ]
+body:
+  - type: checkboxes
+    id: terms
+    attributes:
+      label: Pre-requisites
+      options:
+        - label: I have double-checked my configuration
+          required: true
+        - label: I can confirm the issues exists when I tested with `:latest`
+          required: true
+        - label: I'd like to contribute the fix myself (see [contributing guide](https://github.com/argoproj/argo-workflows/blob/master/docs/CONTRIBUTING.md))
+  - type: textarea
+    id: description
+    attributes:
+      label: What happened/what you expected to happen?
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Version
+      placeholder: e.g. v3.3.8 or latest
+    validations:
+      required: true
+  - type: textarea
+    id: failing-workflow
+    attributes:
+      label: Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
+      render: YAML
+    validations:
+      required: true
+  - type: textarea
+    id: controller-logs
+    attributes:
+      label: Logs from the workflow controller
+      value: kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
+    validations:
+      required: true
+  - type: textarea
+    id: wait-logs
+    attributes:
+      label: Logs from in your workflow's wait container
+      value: kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -0,0 +1,49 @@
+name: Regression report
+description: Create a regression report. Not for support requests.
+labels: [ bug, regression ]
+
+body:
+  - type: checkboxes
+    id: terms
+    attributes:
+      label: Pre-requisites
+      options:
+        - label: I have double-checked my configuration
+          required: true
+        - label: I can confirm the issues exists when I tested with `:latest`
+          required: true
+        - label: I'd like to contribute the fix myself (see [contributing guide](https://github.com/argoproj/argo-workflows/blob/master/docs/CONTRIBUTING.md))
+  - type: textarea
+    id: description
+    attributes:
+      label: What happened/what you expected to happen?
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Version
+      placeholder: e.g. v3.3.8 or latest
+    validations:
+      required: true
+  - type: textarea
+    id: failing-workflow
+    attributes:
+      label: Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
+      render: YAML
+    validations:
+      required: true
+  - type: textarea
+    id: controller-logs
+    attributes:
+      label: Logs from the workflow controller
+      value: kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
+    validations:
+      required: true
+  - type: textarea
+    id: wait-logs
+    attributes:
+      label: Logs from in your workflow's wait container
+      value: kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/regression.md

@@ -157,7 +157,13 @@ jobs:
       - run: make start PROFILE=${{matrix.profile}} AUTH_MODE=client STATIC_FILES=false LOG_LEVEL=info API=${{matrix.test == 'test-api' || matrix.test == 'test-cli' || matrix.test == 'test-java-sdk' || matrix.test == 'test-python-sdk'}} UI=false AZURE=true > /tmp/argo.log 2>&1 &
       - run: make wait
         timeout-minutes: 4
-      - run: make ${{matrix.test}} E2E_SUITE_TIMEOUT=20m STATIC_FILES=false AZURE=true
+      - name: make ${{matrix.test}}
+        # https://github.com/marketplace/actions/retry-step
+        uses: nick-fields/[email protected]
+        with:
+          timeout_minutes: 20
+          max_attempts: 2
+          command: make ${{matrix.test}} E2E_SUITE_TIMEOUT=20m STATIC_FILES=false AZURE=true
       - if: ${{ failure() }}
         run: |
           [ -e /tmp/argo.log ] && cat /tmp/argo.log
@@ -173,7 +179,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: "1.18"
+          go-version: "1.19"
       - uses: actions/cache@v3
         with:
           path: |
@@ -185,9 +191,9 @@ jobs:
       - name: Install protoc
         run: |
           set -eux -o pipefail
-          curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v3.11.1/protoc-3.11.1-linux-x86_64.zip
-          sudo unzip -o protoc-3.11.1-linux-x86_64.zip -d /usr/local bin/protoc
-          sudo unzip -o protoc-3.11.1-linux-x86_64.zip -d /usr/local 'include/*'
+          curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v3.19.4/protoc-3.19.4-linux-x86_64.zip
+          sudo unzip -o protoc-3.19.4-linux-x86_64.zip -d /usr/local bin/protoc
+          sudo unzip -o protoc-3.19.4-linux-x86_64.zip -d /usr/local 'include/*'
           sudo chmod +x /usr/local/bin/protoc
           sudo find /usr/local/include -type f | xargs sudo chmod a+r
           sudo find /usr/local/include -type d | xargs sudo chmod a+rx

.github/ISSUE_TEMPLATE/regression.yaml

@@ -25,7 +25,6 @@ run:
 linters:
   enable:
     - bodyclose
-    - deadcode
     - errcheck
     - goimports
     # only minor issues
@@ -41,11 +40,9 @@ linters:
     - rowserrcheck
     - sqlclosecheck
     - staticcheck
-    - structcheck
     - typecheck
     - unparam
     - unused
-    - varcheck
 linters-settings:
   goimports:
     local-prefixes: github.com/argoproj/argo-workflows/
@@ -60,3 +57,11 @@ linters-settings:
       - G402
       # G601: Implicit memory aliasing in for loop.
       - G601
+issues:
+  exclude:
+    # We are leaving io/ioutil for now to make backports easier
+    # https://github.com/argoproj/argo-workflows/pull/6964#issuecomment-946827019
+    - "SA1019: \"io/ioutil\" has been deprecated since Go 1.16"
+  exclude-rules:
+    - path: server/artifacts/artifact_server_test.go
+      text: "response body must be closed"

.github/workflows/ci-build.yaml

@@ -148,6 +148,7 @@ k8s-jobs
 kube
 kubelet
 kubernetes
+liveness
 localhost
 memoization
 memoized

.golangci.yml

@@ -1,5 +1,22 @@
 # Changelog
 
+## v3.4.0 (2022-09-18)
+
+ * [047952afd](https://github.com/argoproj/argo-workflows/commit/047952afd539d06cae2fd6ba0b608b19c1194bba) fix: SDK workflow file
+ * [97328f1ed](https://github.com/argoproj/argo-workflows/commit/97328f1ed3885663b780f43e6b553208ecba4d3c) chore(deps): bump classnames and @types/classnames in /ui (#9603)
+ * [2dac194a5](https://github.com/argoproj/argo-workflows/commit/2dac194a52acb46c5535e5f552fdf7fd520d0f4e) chore(deps-dev): bump @babel/core from 7.19.0 to 7.19.1 in /ui (#9602)
+ * [47544cc02](https://github.com/argoproj/argo-workflows/commit/47544cc02a8663b5b69e4c213a382ff156deb63e) feat: Support retrying complex workflows with nested group nodes (#9499)
+ * [30bd96b4c](https://github.com/argoproj/argo-workflows/commit/30bd96b4c030fb728a3da78e0045982bf778d554) fix: Error message if cronworkflow failed to update (#9583)
+ * [fc5e11cd3](https://github.com/argoproj/argo-workflows/commit/fc5e11cd37f51e36517f7699c23afabac4f08528) chore(deps-dev): bump webpack-dev-server from 4.10.1 to 4.11.0 in /ui (#9567)
+ * [ace179804](https://github.com/argoproj/argo-workflows/commit/ace179804996edc0d356bff257a980e60b9bc5a0) docs(dev-container): Fix buildkit doc for local dev (#9580)
+
+### Contributors
+
+ * JM
+ * Saravanan Balasubramanian
+ * Yuan Tang
+ * dependabot[bot]
+
 ## v3.4.0-rc4 (2022-09-10)
 
  * [dee4ea5b0](https://github.com/argoproj/argo-workflows/commit/dee4ea5b0be2408e13af7745db910d0130e578f2) chore(deps-dev): bump @babel/core from 7.18.13 to 7.19.0 in /ui (#9566)

.spelling

@@ -299,11 +299,13 @@ $(GOPATH)/bin/goimports:
 	go install golang.org/x/tools/cmd/[email protected]
 
 /usr/local/bin/clang-format:
+ifeq (, $(shell which clang-format))
 ifeq ($(shell uname),Darwin)
 	brew install clang-format
 else
 	sudo apt-get install clang-format
 endif
+endif
 
 pkg/apis/workflow/v1alpha1/generated.proto: $(GOPATH)/bin/go-to-protobuf $(PROTO_BINARIES) $(TYPES) $(GOPATH)/src/github.com/gogo/protobuf
 	# These files are generated on a v3/ folder by the tool. Link them to the root folder
@@ -393,7 +395,7 @@ dist/manifests/%: manifests/%
 # lint/test/etc
 
 $(GOPATH)/bin/golangci-lint:
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.47.1
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.49.0
 
 .PHONY: lint
 lint: server/static/files.go $(GOPATH)/bin/golangci-lint
@@ -421,6 +423,9 @@ test: server/static/files.go
 .PHONY: install
 install: githooks
 	kubectl get ns $(KUBE_NAMESPACE) || kubectl create ns $(KUBE_NAMESPACE)
+	# install cert-manager if Certificate CRD is not available
+	kubectl get ns cert-manager || kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.9.1/cert-manager.yaml
+	kubectl wait --for=condition=Ready pods --all --namespace cert-manager
 	kubectl config set-context --current --namespace=$(KUBE_NAMESPACE)
 	@echo "installing PROFILE=$(PROFILE)"
 	kubectl kustomize --load-restrictor=LoadRestrictionsNone test/e2e/manifests/$(PROFILE) | sed 's|quay.io/argoproj/|$(IMAGE_NAMESPACE)/|' | sed 's/namespace: argo/namespace: $(KUBE_NAMESPACE)/' | kubectl -n $(KUBE_NAMESPACE) apply --prune -l app.kubernetes.io/part-of=argo -f -

CHANGELOG.md

@@ -70,6 +70,7 @@ The following commands install Argo Workflows as well as some commmonly used com
 
 ```bash
 kubectl create ns argo
+kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.9.1/cert-manager.yaml
 kubectl apply -n argo -f https://raw.githubusercontent.com/argoproj/argo-workflows/master/manifests/quick-start-postgres.yaml
 ```