fix(ui): Use proper podname for containersets. Fixes argoproj#13038 (argoproj#13039)

Signed-off-by: instauro <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Co-authored-by: instauro <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]>
(cherry picked from commit 10e3a6d)

Author: instauro

ui/src/app/shared/pod-name.test.ts

@@ -52,6 +52,7 @@ describe('pod names', () => {
         expect(getPodName(wf, node)).toEqual(v2podName);
         delete wf.metadata.annotations;
         expect(getPodName(wf, node)).toEqual(v2podName);
+        expect(getPodName(wf, {...node, name: node.name + '.mycontainername', type: 'Container'})).toEqual(v2podName); // containerSet node check
 
         wf.metadata.name = longWfName;
         node.templateName = longTemplateName;

ui/src/app/shared/pod-name.ts

@@ -11,15 +11,18 @@ const maxPrefixLength = maxK8sResourceNameLength - k8sNamingHashLength;
 // getPodName returns a deterministic pod name
 // In case templateName is not defined or that version is explicitly set to  POD_NAME_V1, it will return the nodeID (v1)
 // In other cases it will return a combination of workflow name, template name, and a hash (v2)
-// note: this is intended to be equivalent to the server-side Go code in workflow/util/pod_name.go
+// note: this is intended to be equivalent to the server-side Go code in workflow/util/pod_name.go#GeneratePodName
 export function getPodName(workflow: Workflow, node: NodeStatus): string {
     const version = workflow.metadata?.annotations?.[ANNOTATION_KEY_POD_NAME_VERSION];
     if (version === POD_NAME_V1) {
         return node.id;
     }
 
     const workflowName = workflow.metadata.name;
-    if (workflowName === node.name) {
+    // convert containerSet node name to its corresponding pod node name by removing the ".<containerName>" postfix
+    // this part is from workflow/controller/container_set_template.go#executeContainerSet; the inverse never happens in the back-end, so is unique to the front-end
+    const podNodeName = node.type == 'Container' ? node.name.replace(/\.[^/.]+$/, '') : node.name;
+    if (workflowName === podNodeName) {
         return workflowName;
     }
 
@@ -30,7 +33,7 @@ export function getPodName(workflow: Workflow, node: NodeStatus): string {
     }
     prefix = ensurePodNamePrefixLength(prefix);
 
-    const hash = createFNVHash(node.name);
+    const hash = createFNVHash(podNodeName);
     return `${prefix}-${hash}`;
 }