Merge pull request #339 from codefresh-io/cr-24608-sync-upstream-3.5.8

feat: sync upstream `v3.5.8`

Author: ATGardner

.github/workflows/docs.yaml

@@ -18,8 +18,6 @@ permissions:
 jobs:
   docs:
     runs-on: ubuntu-latest
-    permissions:
-      contents: write # for publishing the docs to GH Pages
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
@@ -44,10 +42,3 @@ jobs:
           name: docs
           path: site
           if-no-files-found: error
-      - name: Publish to GH Pages (when on main)
-        if: github.repository == 'argoproj/argo-workflows' && github.ref == 'refs/heads/main'
-        uses: peaceiris/actions-gh-pages@373f7f263a76c20808c831209c920827a82a2847 # v3.9.3
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-          publish_branch: gh-pages
-          publish_dir: ./site

.golangci.yml

@@ -1,18 +1,6 @@
 # https://golangci-lint.run/usage/quick-start/
 run:
   timeout: 12m
-  skip-dirs:
-    - dist
-    - docs
-    - examples
-    - hack
-    - manifests
-    - pkg/client
-    - sdks
-    - ui
-    - vendor
-  skip-files:
-    - server/static/files.go
   build-tags:
     - api
     - cli
@@ -66,3 +54,15 @@ issues:
   exclude-rules:
     - path: server/artifacts/artifact_server_test.go
       text: "response body must be closed"
+  exclude-dirs:
+    - dist
+    - docs
+    - examples
+    - hack
+    - manifests
+    - pkg/client
+    - sdks
+    - ui
+    - vendor
+  exclude-files:
+    - server/static/files.go

.spelling

@@ -8,9 +8,9 @@
 120s
 120sec
 1Gi
-1Mi
 1h
 1m
+1Mi
 2Gi
 2h
 30s
@@ -25,182 +25,178 @@
 90m
 Alexandre
 Alibaba
-Ang
-Anthos
-ArgoLabs
-Artifactory
-BlackRock
-Breitgand
-CRD
-CRDs
-CloudSQL
-ClusterRoleBinding
-ClusterRoles
-Codespaces
-ConfigMap
-ConfigMaps
-Couler
-CronWorkflow
-CronWorkflows
-DataDog
-Dataflow
-DevOps
-Devenv
-Dex
-EditorConfig
-EtcD
-EventRouter
-Generator
-GitOps
-Github
-Golang
-Grafana
-Grammarly
-Hadoop
-Heptio
-Homebrew
-IAM-based
-IPs
-InitContainer
-InsideBoard
-Invocators
-Istio
-Jemison
-JetBrains
-KNative
-Kaniko
-Katacoda
-Kerberos
-Killercoda
-KubectlExec
-Kubeflow
-Kustomize
-LDFlags
-Lifecycle-Hook
-LitmusChaos
-MLOps
-Makefile
-MinIO
-Minikube
-MySQL
-Nagal
-Nano
-Nginx
-Node.JS.
-OAuth
-OAuth2
-Okta
-OpenAPI
-PDBs
-PProf
-PVCs
-Peixuan
-Ploomber
-Postgres
-RCs
-Roadmap
-RoleBinding
-SDKs
-SageMaker
-ServiceAccount
-Sharding
-Singer.io
-Snyk
-Sumit
-Tekton
-Traefik
-Triaging
-TripAdvisor
-UI
-VSCode
-Valasek
-Webhooks
-Welch
-WorkflowTemplate
-WorkflowTemplates
 a.m.
 anded
+Ang
+Anthos
 apis
 architecting
 argo
+ArgoLabs
 argoproj
 args
+Artifactory
 async
 auth
 backend
+backported
+BlackRock
 boolean
 booleans
+Breitgand
 buildkit
 changelog
+CloudSQL
+ClusterRoleBinding
+ClusterRoles
+Codespaces
 config
+ConfigMap
+ConfigMaps
+Couler
 cpu
+CRD
+CRDs
 cron
+CronWorkflow
+CronWorkflows
 daemoned
+DataDog
+Dataflow
 dependabot
 dev
 devenv
+Devenv
+DevOps
+Dex
 dockershim
 docs
 dropdown
-e.g.
 e2e
+EditorConfig
+e.g.
 entrypoint
 enum
 env
 errored
+EtcD
+EventRouter
 expr
 fibonacci
 finalizer
+Generator
+Github
 gitops
+GitOps
+Golang
 goroutine
 goroutines
 govaluate
+Grafana
+Grammarly
 gzipped
-i.e.
+Hadoop
+Heptio
+Homebrew
+IAM-based
 idempotence
+i.e.
+InitContainer
+InsideBoard
 instantiator
 instantiators
+Invocators
+IPs
+Istio
+Jemison
 jenkins
+JetBrains
 k3d
 k3s
+k8s
 k8s-jobs
+Kaniko
+Katacoda
+Kerberos
+Killercoda
+KNative
 kube
 kube-apiserver
-kube-scheduler
 kubectl
+KubectlExec
+Kubeflow
 kubelet
 kubernetes
+kube-scheduler
+Kustomize
+LDFlags
+Lifecycle-Hook
+LitmusChaos
 liveness
 localhost
+Makefile
 maxFailures
 maxSuccess
 memoization
 memoized
 memoizing
 metadata
 minikube
+Minikube
+MinIO
+MLOps
 mutex
+MySQL
+Nagal
 namespace
 namespaces
+Nano
 natively
+Nginx
 nix.conf
+Node.JS.
 non-member
-p.m.
+OAuth
+OAuth2
+Okta
+OpenAPI
 parameterizing
 params
+PDBs
+Peixuan
+Ploomber
+p.m.
+Postgres
 pprof
+PProf
 pre-commit
+PVCs
 rc2
+RCs
 repo
 roadmap
+Roadmap
+RoleBinding
 runtime
 runtimes
 s3
+SageMaker
 sandboxed
+SDKs
+ServiceAccount
+Sharding
 shortcodes
+Singer.io
+Snyk
 stateful
 stderr
+Sumit
+Tekton
+Traefik
 triaged
+Triaging
+TripAdvisor
+UI
 un-reconciled
 v1
 v1.0
@@ -234,13 +230,18 @@ v3.3.
 v3.4
 v3.4.
 v3.5
-versioned
+Valasek
 validator
 vendored
 versioned
 versioning
+VSCode
 webHDFS
 webhook
 webhooks
+Webhooks
+Welch
 workflow-controller-configmap
+WorkflowTemplate
+WorkflowTemplates
 yaml