chore: enabled exportloopref linter (argoproj#6855)

Signed-off-by: Sean Trantalis <[email protected]>

Author: strantalis

.golangci.yml

@@ -23,8 +23,7 @@ linters:
     - goimports
     # only minor issues
     # - errorlint
-    # TODO https://github.com/argoproj/argo-workflows/issues/6840
-    # - exportloopref
+    - exportloopref
     - gci
     - gosec
     - gosimple

workflow/controller/operator_test.go

@@ -1820,6 +1820,7 @@ func TestSidecarResourceLimits(t *testing.T) {
 	assert.NoError(t, err)
 	var waitCtr *apiv1.Container
 	for _, ctr := range pod.Spec.Containers {
+		ctr := ctr
 		if ctr.Name == "wait" {
 			waitCtr = &ctr
 			break

workflow/controller/workflowpod_test.go

@@ -620,6 +620,7 @@ func Test_createWorkflowPod_rateLimited(t *testing.T) {
 		{Limit: 0, Burst: 1}: false,
 		{Limit: 1, Burst: 1}: false,
 	} {
+		limit := limit
 		t.Run(fmt.Sprintf("%v", limit), func(t *testing.T) {
 			wf := wfv1.MustUnmarshalWorkflow(helloWorldWf)
 			cancel, controller := newController(wf, func(c *WorkflowController) {