fix: terminate telemetry services before process.exit calls

Author: vasil-cf

lib/addNewMask.js

@@ -1,5 +1,7 @@
+/* eslint-disable promise/catch-or-return */
+
 // ↓ Should be imported first
-require('@codefresh-io/cf-telemetry/init');
+const { terminate } = require('@codefresh-io/cf-telemetry/init');
 // ↓ Keep one blank line below to prevent automatic import reordering
 
 const { Logger } = require('@codefresh-io/cf-telemetry/logs');
@@ -43,14 +45,14 @@ async function updateMasks(secret) {
         if (response.statusCode === 201) {
             logger.log(`successfully updated masks with secret: ${secret.key}`);
             exitWithError = false;
-            process.exit(exitCodes.success);
+            terminate().finally(() => process.exit(exitCodes.success));
         } else {
             logger.error(`could not create mask for secret: ${secret.key}. Server responded with: ${response.statusCode}\n\n${response.body}`);
-            process.exit(exitCodes.error);
+            terminate().finally(() => process.exit(exitCodes.error));
         }
     } catch (error) {
         logger.error(`could not create mask for secret: ${secret.key}. Error: ${error}`);
-        process.exit(exitCodes.error);
+        terminate().finally(() => process.exit(exitCodes.error));
     }
 }
 
@@ -60,7 +62,7 @@ if (require.main === module) {
     // first argument is the secret key second argument is the secret value
     if (process.argv.length < 4) {
         logger.log('not enough arguments, need secret key and secret value');
-        process.exit(exitCodes.missingArguments);
+        terminate().finally(() => process.exit(exitCodes.missingArguments));
     }
     const key = process.argv[2];
     const value = process.argv[3];

lib/helpers.js

@@ -1,3 +1,9 @@
+/* eslint-disable promise/catch-or-return */
+
+// ↓ Should be imported first
+const { terminate } = require('@codefresh-io/cf-telemetry/init');
+// ↓ Keep one blank line below to prevent automatic import reordering
+
 const { stat, writeFile, readFile } = require('node:fs/promises');
 const path = require('path');
 const { Logger } = require('@codefresh-io/cf-telemetry/logs');
@@ -60,11 +66,11 @@ const getServerAddress = async () => {
  */
 const registerExitHandlers = () => {
     process.on('SIGTERM', () => {
-        process.exit(143); // default exit code for SIGTERM
+        terminate().finally(() => process.exit(143)); // default exit code for SIGTERM
     });
 
     process.on('SIGINT', () => {
-        process.exit(130); // default exit code for SIGINT
+        terminate().finally(() => process.exit(130)); // default exit code for SIGINT
     });
 };
 

lib/isReady.js

@@ -1,5 +1,7 @@
+/* eslint-disable promise/catch-or-return */
+
 // ↓ Should be imported first
-require('@codefresh-io/cf-telemetry/init');
+const { terminate } = require('@codefresh-io/cf-telemetry/init');
 // ↓ Keep one blank line below to prevent automatic import reordering
 
 const { readFileSync } = require('fs');
@@ -41,5 +43,5 @@ function isContainerLoggerReady(state) {
         isReady = isContainerLoggerReady(state);
     }
 
-    process.exit(isReady ? 0 : 1);
+    terminate().finally(() => process.exit(isReady ? 0 : 1));
 })();

lib/logger.js

@@ -1,3 +1,9 @@
+/* eslint-disable promise/catch-or-return */
+
+// ↓ Should be imported first
+const { terminate } = require('@codefresh-io/cf-telemetry/init');
+// ↓ Keep one blank line below to prevent automatic import reordering
+
 const fs = require('fs');
 const { EventEmitter } = require('events');
 const _ = require('lodash');
@@ -151,7 +157,7 @@ class Logger {
      */
     _error(err) {
         logger.error(err.toString());
-        process.exit(1);
+        terminate().finally(() => process.exit(1));
     }
 
     /**