fix: tests for isReady.js

Author: vasil-cf

lib/isReady.js

@@ -31,7 +31,7 @@ function isContainerLoggerReady(state) {
     return isReady;
 }
 
-(async () => {
+const isReady = async () => {
     const containerId = process.argv[2];
     const state = JSON.parse(readFileSync('./lib/state.json').toString('utf-8'));
     let isReady = false;
@@ -43,4 +43,10 @@ function isContainerLoggerReady(state) {
 
     await terminate();
     process.exit(isReady ? 0 : 1);
-})();
+};
+
+if (require.main === module) {
+    isReady();
+} else {
+    module.exports = { isReady };
+}

test/isReady.unit.spec.js

@@ -18,67 +18,103 @@ describe('isReady script', () => {
         process.argv = orgArgs;
     });
     describe('Container Logger Checks', () => {
-        it('Should check exit with 0 code if container logger is ready', () => {
+        it('Should check exit with 0 code if container logger is ready', async () => {
             const state = JSON.stringify({ status: 'ready', containers: {} })
             process.argv = [];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const { isReady } = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': { terminate: terminateSpy },
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(0);
         });
-        it('Should check exit with 1 code if container logger is not ready', () => {
+        it('Should check exit with 1 code if container logger is not ready', async () => {
             const state = JSON.stringify({ status: 'notReady', containers: {} })
             process.argv = [];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const { isReady } = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': { terminate: terminateSpy },
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(1);
         });
     });
     describe('Container Checks', () => {
-        it('Should check exit with 0 code if container is ready', () => {
-            const state = JSON.stringify({ status: 'ready', containers: { 'container-id': { status: ContainerHandlingStatus.LISTENING } } })
+        it('Should check exit with 0 code if container is ready', async () => {
+            const state = JSON.stringify({
+                status: 'ready',
+                containers: {'container-id': {status: ContainerHandlingStatus.LISTENING}}
+            })
             process.argv = ['foo', 'bar', 'container-id'];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const {isReady} = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': {terminate: terminateSpy},
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(0);
         });
-        it('Should check exit with 0 code if container is waiting for start status', () => {
-            const state = JSON.stringify({ status: 'ready', containers: { 'container-id': { status: ContainerHandlingStatus.WAITING_FOR_START } } })
+        it('Should check exit with 0 code if container is waiting for start status', async () => {
+            const state = JSON.stringify({
+                status: 'ready',
+                containers: {'container-id': {status: ContainerHandlingStatus.WAITING_FOR_START}}
+            })
             process.argv = ['foo', 'bar', 'container-id'];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const {isReady} = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': {terminate: terminateSpy},
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(0);
         });
-        it('Should check exit with 0 code if container is finished status', () => {
-            const state = JSON.stringify({ status: 'ready', containers: { 'container-id': { status: ContainerHandlingStatus.FINISHED } } })
+        it('Should check exit with 0 code if container is finished status', async () => {
+            const state = JSON.stringify({
+                status: 'ready',
+                containers: {'container-id': {status: ContainerHandlingStatus.FINISHED}}
+            })
             process.argv = ['foo', 'bar', 'container-id'];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const {isReady} = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': {terminate: terminateSpy},
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(0);
         });
-        it('Should check exit with 1 code if container is not ready', () => {
-            const state = JSON.stringify({ status: 'ready', containers: { 'container-id': { status: ContainerHandlingStatus.INITIALIZING } } })
+        it('Should check exit with 1 code if container is not ready', async () => {
+            const state = JSON.stringify({
+                status: 'ready',
+                containers: {'container-id': {status: ContainerHandlingStatus.INITIALIZING}}
+            })
             process.argv = ['foo', 'bar', 'container-id'];
-            proxyquire('../lib/isReady.js', {
+            const terminateSpy = sinon.spy();
+            const {isReady} = proxyquire('../lib/isReady.js', {
+                '@codefresh-io/cf-telemetry/init': {terminate: terminateSpy},
                 'fs': {
                     readFileSync: () => Buffer.from(state),
                 },
             });
+            await isReady();
+            expect(terminateSpy).to.have.been.calledOnce;
             expect(process.exit).to.have.been.calledOnceWith(1);
         });
     });
-});
+});