More ingress controllers support (#292)

* istio, traefik and ambassador support

* bump

Author: danielm-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.268
+VERSION=v0.0.269
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

@@ -151,6 +151,9 @@ const (
 
 	IngressControllerNginxCommunity  ingressControllerType = "k8s.io/ingress-nginx"
 	IngressControllerNginxEnterprise ingressControllerType = "nginx.org/ingress-controller"
+	IngressControllerIstio           ingressControllerType = "istio.io/ingress-controller"
+	IngressControllerTraefik         ingressControllerType = "traefik.io/ingress-controller"
+	IngressControllerAmbassador      ingressControllerType = "getambassador.io/ingress-controller"
 )
 
 var summaryArr []summaryLog
@@ -469,7 +472,7 @@ func ensureIngressClass(ctx context.Context, opts *RuntimeInstallOptions) error
 		return fmt.Errorf("failed to get ingress class list from your cluster: %w", err)
 	}
 
-	supportedControllers := []ingressControllerType{IngressControllerNginxCommunity, IngressControllerNginxEnterprise}
+	supportedControllers := []ingressControllerType{IngressControllerNginxCommunity, IngressControllerNginxEnterprise, IngressControllerIstio, IngressControllerTraefik, IngressControllerAmbassador}
 	var ingressClassNames []string
 	ingressClassNameToController := make(map[string]ingressController)
 	var isValidClass bool
@@ -527,6 +530,10 @@ func getIngressControllerName(controllerType ingressControllerType, className st
 		return "ingress-nginx-controller"
 	case IngressControllerNginxEnterprise:
 		return fmt.Sprintf("%s-ingress-controller", className)
+	case IngressControllerTraefik:
+		return "traefik"
+	case IngressControllerIstio:
+		return "istio-ingressgateway"
 	default:
 		return ""
 	}
@@ -1864,7 +1871,7 @@ func configureAppProxy(ctx context.Context, opts *RuntimeInstallOptions, rt *run
 			Host:             opts.HostName,
 			Paths: []ingressutil.IngressPath{
 				{
-					Path:        fmt.Sprintf("/%s", store.Get().AppProxyIngressPath),
+					Path:        store.Get().AppProxyIngressPath,
 					PathType:    netv1.PathTypePrefix,
 					ServiceName: store.Get().AppProxyServiceName,
 					ServicePort: store.Get().AppProxyServicePort,

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.268/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.269/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.268/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.269/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.268
+  version: 0.0.269
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events

pkg/store/store.go

@@ -172,7 +172,7 @@ func init() {
 	s.WorkflowsIngressName = "-workflows-ingress"
 	s.WorkflowsIngressPath = "workflows"
 	s.AppProxyIngressName = "-cap-app-proxy"
-	s.AppProxyIngressPath = "app-proxy"
+	s.AppProxyIngressPath = "/app-proxy/"
 	s.AppProxyServicePort = 3017
 	s.AppProxyServiceName = "cap-app-proxy"
 	s.DocsLink = "https://codefresh.io/csdp-docs/"