Remove-ingress-class-required (#231)

* removed ingress class flag from git-source create

* bump

* docs update

* improve string

Author: rotem-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.211
+VERSION=v0.0.212
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -454,7 +454,7 @@ func askUserIfToProceedWithInsecure(ctx context.Context) error {
 	}
 
 	log.G(ctx).Warnf("The ingress host does not have a valid certificate.")
-	labelStr := fmt.Sprintf("%vDo you wish to continue the installation with insecure ingress host mode?%v", CYAN, COLOR_RESET)
+	labelStr := fmt.Sprintf("%vDo you wish to continue with the installation in insecure mode with this ingress host?%v", CYAN, COLOR_RESET)
 
 	prompt := promptui.Select{
 		Label:     labelStr,

cmd/commands/git-source.go

@@ -116,7 +116,6 @@ func NewGitSourceCreateCommand() *cobra.Command {
 		insCloneOpts *git.CloneOptions
 		gsCloneOpts  *git.CloneOptions
 		createRepo   bool
-		ingressClass string
 	)
 
 	cmd := &cobra.Command{
@@ -141,10 +140,6 @@ func NewGitSourceCreateCommand() *cobra.Command {
 				log.G(ctx).Fatal("must enter a valid value to --git-src-repo. Example: https://github.com/owner/repo-name/path/to/workflow")
 			}
 
-			if ingressClass == "" && !store.Get().BypassIngressClassCheck {
-				log.G(ctx).Fatal("must enter a valid ingressClass name to --ingress-class")
-			}
-
 			err := ensureRepo(cmd, args[0], insCloneOpts, true)
 			if err != nil {
 				return err
@@ -181,15 +176,11 @@ func NewGitSourceCreateCommand() *cobra.Command {
 				GsName:              args[1],
 				RuntimeName:         args[0],
 				CreateDemoResources: false,
-				IngressClass: ingressClass,
 			})
 		},
 	}
 
 	cmd.Flags().BoolVar(&createRepo, "create-repo", false, "If true, will create the specified git-source repo in case it doesn't already exist")
-	cmd.Flags().StringVar(&ingressClass, "ingress-class", "", "The ingress class name")
-	cmd.Flags().BoolVar(&store.Get().BypassIngressClassCheck, "bypass-ingress-class-check", false, "Disables the ingress class check during git-source installation")
-	util.Die(cmd.Flags().MarkHidden("bypass-ingress-class-check"))
 
 	insCloneOpts = apu.AddCloneFlags(cmd, &apu.CloneFlagsOptions{})
 	gsCloneOpts = apu.AddCloneFlags(cmd, &apu.CloneFlagsOptions{

docs/commands/cli-v2_git-source_create.md

@@ -24,7 +24,6 @@ cli-v2 git-source create runtime_name git-source_name [flags]
   -t, --git-token string           Your git provider api token [GIT_TOKEN]
   -u, --git-user string            Your git provider user name [GIT_USER] (not required in GitHub)
   -h, --help                       help for create
-      --ingress-class string       The ingress class name
       --repo string                Repository URL [GIT_REPO]
 ```
 

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.211/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.212/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.211/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.212/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
     namespace: '{{ namespace }}'
 spec:
     defVersion: 1.0.0
-    version: 0.0.211
+    version: 0.0.212
     bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
     components:
         - name: events