add no_proxy to runner init (#583)

Author: oren-codefresh

lib/interface/cli/commands/hybrid/helper.js

@@ -902,9 +902,11 @@ function serealizeToKeyValuePairs(obj) {
 function detectProxy() {
     const httpProxy = process.env.http_proxy || process.env.HTTP_PROXY;
     const httpsProxy = process.env.https_proxy || process.env.HTTPS_PROXY;
+    const noProxy = process.env.no_proxy || process.env.NO_PROXY;
     return {
         httpProxy,
         httpsProxy,
+        noProxy,
     };
 }
 

lib/interface/cli/commands/hybrid/init.cmd.js

@@ -164,6 +164,9 @@ const initCmd = new Command({
         .option('https-proxy', {
             describe: 'https proxy to be used in the runner',
         })
+        .option('no-proxy', {
+            describe: 'no_proxy to be used in the runner',
+        })
         .option('verbose', {
             describe: 'Print logs',
         })
@@ -234,6 +237,7 @@ const initCmd = new Command({
             'env-vars': envVars,
             'http-proxy': httpProxy,
             'https-proxy': httpsProxy,
+            'no-proxy': noProxy,
             url,
             token,
             name,
@@ -298,6 +302,7 @@ const initCmd = new Command({
         const detectedProxyVars = detectProxy();
         httpProxy = httpProxy || detectedProxyVars.httpProxy;
         httpsProxy = httpsProxy || detectedProxyVars.httpsProxy;
+        noProxy = noProxy || detectedProxyVars.noProxy;
         envVars = envVars || [];
         if (!Array.isArray(envVars)) {
             envVars = [envVars];
@@ -352,6 +357,15 @@ const initCmd = new Command({
 
                 });
             }
+            if (noProxy) {
+                questions.push({
+                    type: 'input',
+                    name: 'noProxy',
+                    default: noProxy,
+                    message: 'NO_PROXY to be used by runner inside Kubernetes?',
+
+                });
+            }
 
             if (appProxy && !appProxyHost) {
                 // will only be asked if you want to install app-proxy but you give no host in the options
@@ -449,6 +463,10 @@ const initCmd = new Command({
             envVars.push(`https_proxy=${httpsProxy}`);
             envVars.push(`HTTPS_PROXY=${httpsProxy}`);
         }
+        if (noProxy) {
+            envVars.push(`no_proxy=${noProxy}`);
+            envVars.push(`NO_PROXY=${noProxy}`);
+        }
 
         // save the answers for backup
         _argv['kube-context-name'] = kubeContextName;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.73.13",
+  "version": "0.73.14",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,