Skip to content

feat(cf-common): global imagePullSecrets with name #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

feat(cf-common): global imagePullSecrets with name #111

merged 2 commits into from
May 22, 2025

Conversation

mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented May 22, 2025 •
edited
Loading

What

Handle case when global imagePullSecrets can be provided as list of maps like:

global:
  imagePullSecrets:
    - name: my-reg-secrets

or list of strings like:

global:
  imagePullSecrets:
    - my-reg-secrets

The resulting manifest should always have a proper spec

spec:
  template:
    spec:
      imagePullSecrets:
        - name: my-reg-secrets

and NOT

spec:
  template:
    spec:
      imagePullSecrets:
        - name: name my-reg-secrets

Why

Notes

See charts/cf-common/templates/container/_image.tpl for changes

@mikhail-klimko mikhail-klimko marked this pull request as ready for review May 22, 2025 16:04
@mikhail-klimko mikhail-klimko requested a review from a team as a code owner May 22, 2025 16:04
@github-actions github-actions bot added the tests label May 22, 2025
@mikhail-klimko mikhail-klimko merged commit a0e89db into master May 22, 2025
6 checks passed
@mikhail-klimko mikhail-klimko deleted the feat/global-image-pull-secret-with-name branch May 22, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarbis zarbis zarbis approved these changes

Assignees
No one assigned
Labels
library tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikhail-klimko @zarbis