Skip to content

Commit 1fdc158

Browse files
Cr 15581 finalize google secret manager (#507)
* move image to image repository and delete step subdir * fix link to image * fix numbering in readme
1 parent 7441c58 commit 1fdc158

File tree

4 files changed

+5
-78
lines changed

4 files changed

+5
-78
lines changed

incubating/google-secret-manager/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@ PreReqs:
44

55
1. [Hybrid Codefresh Runner](https://codefresh.io/docs/docs/administration/codefresh-runner/) on GKE
66

7-
1. GKE w/ [Workload Identity Enabled](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity)
7+
2. GKE w/ [Workload Identity Enabled](https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity)
88

9-
1. GKE w/ [Config Connector Enabled](https://cloud.google.com/config-connector/docs/how-to/getting-started)
9+
3. GKE w/ [Config Connector Enabled](https://cloud.google.com/config-connector/docs/how-to/getting-started)
1010

11-
1. Create IAM Policy Binding between GCP SA and GKE SA.
11+
4. Create IAM Policy Binding between GCP SA and GKE SA.
1212

1313
```
1414
gcloud iam service-accounts add-iam-policy-binding <gcp-sa-name>@<gcp-project-name>.iam.gserviceaccount.com \
1515
--role roles/iam.workloadIdentityUser \
1616
--member "serviceAccount:<gcp-project-name>.svc.id.goog[<runner-namespace>/default]"
1717
```
1818

19-
1. Hybrid Codefresh Runner's Service Account `default` in the Runner namepsace must be properly annotated with a GSM Service Account that has access to Google Secret Manager to read the Secret.
19+
5. Hybrid Codefresh Runner's Service Account `default` in the Runner namepsace must be properly annotated with a GSM Service Account that has access to Google Secret Manager to read the Secret.
2020

2121
Example of the annotation required.
2222
```
File renamed without changes.

incubating/google-secret-manager/step.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ metadata:
1313
official: true
1414
icon:
1515
type: image
16-
url: 'https://cdn.jsdelivr.net/gh/codefresh-contrib/google-secret-manager@main/step/secret_manager.png'
16+
url: 'https://cdn.jsdelivr.net/gh/codefresh-io/steps/incubating/google-secret-manager/images/secret_manager.png'
1717
background: '#f4f4f4'
1818
examples:
1919
- description: fetch-secret-from-gsm

incubating/google-secret-manager/step/step.yaml

Lines changed: 0 additions & 73 deletions
This file was deleted.

0 commit comments

Comments
 (0)