Saas-7194 validate k8s version (#126)

Author: roi-codefresh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/VERSION

@@ -1 +1 @@
-1.2.5
+1.2.6

venonactl/go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/codefresh-io/go-sdk v0.18.0
 	github.com/dustin/go-humanize v1.0.0
 	github.com/gophercloud/gophercloud v0.8.0 // indirect
+	github.com/hashicorp/go-version v1.2.0
 	github.com/huandu/xstrings v1.3.0 // indirect
 	github.com/imdario/mergo v0.3.8 // indirect
 	github.com/inconshreveable/log15 v0.0.0-20200109203555-b30bc20e4fd1

venonactl/go.sum

@@ -253,6 +253,8 @@ github.com/grpc-ecosystem/grpc-gateway v1.9.0/go.mod h1:vNeuVxBJEsws4ogUvrchl83t
 github.com/grpc-ecosystem/grpc-gateway v1.9.5/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
 github.com/hashicorp/errwrap v0.0.0-20141028054710-7554cd9344ce/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-multierror v0.0.0-20161216184304-ed905158d874/go.mod h1:JMRHfdO9jKNzS/+BTlxCjKNQHg/jZAft8U7LloJvN7I=
+github.com/hashicorp/go-version v1.2.0 h1:3vNe/fWF5CBgRIguda1meWhsZHy3m8gCJ5wx+dIzX/E=
+github.com/hashicorp/go-version v1.2.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
 github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
 github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
 github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=

venonactl/pkg/plugins/helper.go

@@ -33,9 +33,11 @@ import (
 	"github.com/codefresh-io/venona/venonactl/pkg/logger"
 	templates "github.com/codefresh-io/venona/venonactl/pkg/templates/kubernetes"
 
+	ver "github.com/hashicorp/go-version"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/version"
 	"k8s.io/client-go/kubernetes/scheme"
 )
 
@@ -52,6 +54,8 @@ type (
 	}
 )
 
+var requiredK8sVersion, _ = ver.NewConstraint(">= 1.10")
+
 func unescape(s string) template.HTML {
 	return template.HTML(s)
 }
@@ -149,8 +153,19 @@ func getKubeObjectsFromTempalte(values map[string]interface{}, pattern string, l
 	return KubeObjectsFromTemplates(templatesMap, values, pattern, logger)
 }
 
-func ensureClusterRequirements(client *kubernetes.Clientset, req validationRequest) (validationResult, error) {
+func ensureClusterRequirements(client *kubernetes.Clientset, req validationRequest, logger logger.Logger) (validationResult, error) {
 	result := validationResult{}
+	result.isValid = true
+
+	v, err := client.ServerVersion()
+	if err != nil {
+		// should not fail if can't validate version
+		logger.Warn("Failed to validate kubernetes version", "cause", err)
+	} else if res := testKubernetesVersion(v); !res {
+		result.isValid = false
+		result.message = append(result.message, "Cluster does not meet the kubernetes version requirements")
+	}
+
 	nodes, err := client.CoreV1().Nodes().List(metav1.ListOptions{})
 	if err != nil {
 		return result, err
@@ -159,7 +174,6 @@ func ensureClusterRequirements(client *kubernetes.Clientset, req validationReque
 		return result, errors.New("Nodes not found")
 	}
 
-	result.isValid = true
 	if len(nodes.Items) == 0 {
 		result.message = append(result.message, "No nodes in cluster")
 		result.isValid = false
@@ -181,6 +195,11 @@ func ensureClusterRequirements(client *kubernetes.Clientset, req validationReque
 	return result, nil
 }
 
+func testKubernetesVersion(version *version.Info) bool {
+	v, _ := ver.NewVersion(version.String())
+	return requiredK8sVersion.Check(v)
+}
+
 func testNode(n v1.Node, req validationRequest) []string {
 	result := []string{}
 

venonactl/pkg/plugins/runtime-environment.go

@@ -89,7 +89,7 @@ func (u *runtimeEnvironmentPlugin) Install(opt *InstallOptions, v Values) (Value
 		res, err := ensureClusterRequirements(cs, validationRequest{
 			cpu:        "1",
 			momorySize: "1Gi",
-		})
+		}, u.logger)
 		if err != nil {
 			return nil, err
 		}

venonactl/pkg/plugins/venona.go

@@ -78,7 +78,7 @@ func (u *venonaPlugin) Install(opt *InstallOptions, v Values) (Values, error) {
 		res, err := ensureClusterRequirements(cs, validationRequest{
 			cpu:        "500m",
 			momorySize: "1Gi",
-		})
+		}, u.logger)
 		if err != nil {
 			return nil, err
 		}