Skip to content

Commit 3a65c23

Browse files
feat/alonbe/improve_cf_runtime_chart (#318)
* Check if monitor is enabled before creating monitor secret * trunc volume cleanup cron name to make sure it's not more than 52 chars by k8s limit * bump Co-authored-by: roi-codefresh <[email protected]>
1 parent 157ef7b commit 3a65c23

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

.deploy/cf-runtime/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: cf-runtime
33
description: A Helm chart for Codefresh Runner
44
type: application
5-
version: 1.8.0
6-
appVersion: "1.8.0"
5+
version: 1.9.2
6+
appVersion: "1.9.2"
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if (not .Values.monitor.existingMonitorToken ) -}}
1+
{{- if and .Values.monitor.enabled (not .Values.monitor.existingMonitorToken ) -}}
22
apiVersion: v1
33
kind: Secret
44
type: Opaque
@@ -7,4 +7,4 @@ metadata:
77
labels: {{- include "cf-monitor.labels" . | nindent 4 }}
88
data:
99
codefresh.token: {{ .Values.monitor.token | b64enc }}
10-
{{- end -}}
10+
{{- end -}}

.deploy/cf-runtime/templates/volume-provisioner/_helpers.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ Expand the name of the chart.
99
{{- printf "%s-%s" (include "cf-runtime.fullname" .) "volume-provisioner" | trunc 63 | trimSuffix "-" }}
1010
{{- end }}
1111

12+
{{- define "cf-vp.volumeCleanupCronName" -}}
13+
{{- printf "%s-%s" (include "cf-runtime.fullname" .) "volume-cleanup" | trunc 52 | trimSuffix "-" }}
14+
{{- end }}
15+
1216
{{- define "cf-vp.provisionerName" -}}
1317
{{- printf "%s-%s" (include "cf-runtime.fullname" .) "volume-provisioner" | trunc 63 | trimSuffix "-" }}
1418
{{- end }}

.deploy/cf-runtime/templates/volume-provisioner/cron-job.dind-volume-cleanup.vp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
apiVersion: batch/v1beta1
33
kind: CronJob
44
metadata:
5-
name: {{ include "cf-vp.fullname" . }}
5+
name: {{ include "cf-vp.volumeCleanupCronName" . }}
66
labels: {{- include "cf-vp.cleanupLabels" . | nindent 4 }}
77
spec:
88
schedule: "0,10,20,30,40,50 * * * *"

.deploy/cf-runtime/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dockerRegistry: "quay.io" # Registry prefix for the runtime images (default quay
2424
newRelicLicense: "" # NEWRELIC_LICENSE_KEY (for app-proxy and runner deployments)
2525

2626
runner: # Runner Deployment
27-
image: "codefresh/venona:1.8.0"
27+
image: "codefresh/venona:1.9.2"
2828
env: {}
2929
## e.g:
3030
# env:

0 commit comments

Comments
 (0)