make env-vars parameter as array (#171)

* make env-vars parameter as array

* fix release pipelines

Author: oren-codefresh

venona/VERSION

@@ -1 +1 @@
-1.4.13
+1.4.14

venona/build/release.yaml

@@ -8,7 +8,7 @@ steps:
     title: Clone repository
     type: git-clone
     repo: https://github.com/codefresh-io/venona
-    revision: ${{CF_BRANCH}}
+    revision: ${{CF_PULL_REQUEST_TARGET}}
     credentials:
       username: github
       password: ${{secrets.hybrid.git}}

venonactl/VERSION

@@ -1 +1 @@
-1.4.13
+1.4.14

venonactl/build/release.yaml

@@ -9,7 +9,7 @@ steps:
     title: Clone repository
     type: git-clone
     repo: https://github.com/codefresh-io/venona
-    revision: ${{CF_BRANCH}}
+    revision: ${{CF_PULL_REQUEST_TARGET}}
     credentials:
       username: github
       password: ${{secrets.hybrid.git}}

venonactl/cmd/install-agent.go

@@ -42,7 +42,7 @@ var installAgentCmdOptions struct {
 	agentID              string
 	kubernetesRunnerType bool
 	tolerations          string
-	envVars              string
+	envVars              []string
 	dockerRegistry       string
 }
 
@@ -98,10 +98,9 @@ var installAgentCmd = &cobra.Command{
 			s.Version.Current.Version = version
 		}
 		s.DockerRegistry = installAgentCmdOptions.dockerRegistry
-		if installAgentCmdOptions.envVars != "" {
+		if installAgentCmdOptions.envVars != nil {
 			s.AdditionalEnvVars = make(map[string]string)
-			parts := strings.Split(installAgentCmdOptions.envVars, ",")
-			for _, part := range parts {
+			for _, part := range installAgentCmdOptions.envVars {
 				splited := strings.Split(part, "=")
 				s.AdditionalEnvVars[splited[0]] = splited[1]
 			}
@@ -139,7 +138,7 @@ func init() {
 	installAgentCmd.Flags().StringVar(&installAgentCmdOptions.kube.context, "kube-context-name", viper.GetString("kube-context"), "Name of the kubernetes context on which venona should be installed (default is current-context) [$KUBE_CONTEXT]")
 	installAgentCmd.Flags().StringVar(&installAgentCmdOptions.kube.nodeSelector, "kube-node-selector", "", "The kubernetes node selector \"key=value\" to be used by venona resources (default is no node selector)")
 	installAgentCmd.Flags().StringVar(&installAgentCmdOptions.tolerations, "tolerations", "", "The kubernetes tolerations as JSON string to be used by venona resources (default is no tolerations)")
-	installAgentCmd.Flags().StringVar(&installAgentCmdOptions.envVars, "envVars", "", "More env vars to be declared \"key=value\"")
+	installAgentCmd.Flags().StringArrayVar(&installAgentCmdOptions.envVars, "envVars", nil, "More env vars to be declared \"key=value\"")
 	installAgentCmd.Flags().StringVar(&installAgentCmdOptions.dockerRegistry, "docker-registry", "", "The prefix for the container registry that will be used for pulling the required components images. Example: --docker-registry=\"docker.io\"")
 
 	installAgentCmd.Flags().BoolVar(&installAgentCmdOptions.kube.inCluster, "in-cluster", false, "Set flag if venona is been installed from inside a cluster")