Saas 7194 fix (#129)

Author: roi-codefresh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "1.2.7",
+  "version": "1.2.8",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/VERSION

@@ -1 +1 @@
-1.2.7
+1.2.8

venonactl/go.mod

@@ -4,7 +4,7 @@ go 1.13
 
 require (
 	github.com/Azure/go-autorest/autorest v0.10.0 // indirect
-	github.com/Masterminds/semver v1.5.0 // indirect
+	github.com/Masterminds/semver v1.5.0
 	github.com/Masterminds/sprig v2.22.0+incompatible
 	github.com/briandowns/spinner v1.11.1
 	github.com/codefresh-io/go-sdk v0.18.0

venonactl/pkg/plugins/helper.go

@@ -33,9 +33,11 @@ import (
 	"github.com/codefresh-io/venona/venonactl/pkg/logger"
 	templates "github.com/codefresh-io/venona/venonactl/pkg/templates/kubernetes"
 
+	"github.com/Masterminds/semver"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/version"
 	"k8s.io/client-go/kubernetes/scheme"
 )
 
@@ -52,6 +54,8 @@ type (
 	}
 )
 
+var requiredK8sVersion, _ = semver.NewConstraint(">= 1.10.0")
+
 func unescape(s string) template.HTML {
 	return template.HTML(s)
 }
@@ -149,8 +153,22 @@ func getKubeObjectsFromTempalte(values map[string]interface{}, pattern string, l
 	return KubeObjectsFromTemplates(templatesMap, values, pattern, logger)
 }
 
-func ensureClusterRequirements(client *kubernetes.Clientset, req validationRequest) (validationResult, error) {
-	result := validationResult{}
+func ensureClusterRequirements(client *kubernetes.Clientset, req validationRequest, logger logger.Logger) (validationResult, error) {
+	result := validationResult{true, nil}
+
+	v, err := client.ServerVersion()
+	if err != nil {
+		// should not fail if can't get version
+		logger.Warn("Failed to validate kubernetes version", "cause", err)
+	} else if res, err := testKubernetesVersion(v); !res {
+		if err != nil {
+			logger.Warn("Failed to validate kubernetes version", "cause", err)
+		} else {
+			result.isValid = false
+			result.message = append(result.message, fmt.Sprintf("Cluster does not meet the version requirements, minimum supported version is: '1.10.0' found version: '%v'", v))
+		}
+	}
+
 	nodes, err := client.CoreV1().Nodes().List(metav1.ListOptions{})
 	if err != nil {
 		return result, err
@@ -159,7 +177,6 @@ func ensureClusterRequirements(client *kubernetes.Clientset, req validationReque
 		return result, errors.New("Nodes not found")
 	}
 
-	result.isValid = true
 	if len(nodes.Items) == 0 {
 		result.message = append(result.message, "No nodes in cluster")
 		result.isValid = false
@@ -181,6 +198,20 @@ func ensureClusterRequirements(client *kubernetes.Clientset, req validationReque
 	return result, nil
 }
 
+func testKubernetesVersion(version *version.Info) (bool, error) {
+	v, err := semver.NewVersion(version.String())
+	if err != nil {
+		return false, err
+	}
+	// extract only major, minor and patch
+	verStr := fmt.Sprintf("%v.%v.%v", v.Major(), v.Minor(), v.Patch())
+	v, err = semver.NewVersion(verStr)
+	if err != nil {
+		return false, err
+	}
+	return requiredK8sVersion.Check(v), nil
+}
+
 func testNode(n v1.Node, req validationRequest) []string {
 	result := []string{}
 

venonactl/pkg/plugins/runtime-environment.go

@@ -89,7 +89,7 @@ func (u *runtimeEnvironmentPlugin) Install(opt *InstallOptions, v Values) (Value
 		res, err := ensureClusterRequirements(cs, validationRequest{
 			cpu:        "1",
 			momorySize: "1Gi",
-		})
+		}, u.logger)
 		if err != nil {
 			return nil, err
 		}

venonactl/pkg/plugins/venona.go

@@ -78,7 +78,7 @@ func (u *venonaPlugin) Install(opt *InstallOptions, v Values) (Values, error) {
 		res, err := ensureClusterRequirements(cs, validationRequest{
 			cpu:        "500m",
 			momorySize: "1Gi",
-		})
+		}, u.logger)
 		if err != nil {
 			return nil, err
 		}