feat: remove sidecar container (#627)

Author: mikhail-klimko

charts/cf-runtime/.ci/values-ci.yaml

@@ -18,9 +18,6 @@ monitor:
   enabled: true
   rbac:
     namespaced: true
-runner:
-  sidecar:
-    enabled: true
 runtime:
   dind:
     podLabels:

charts/cf-runtime/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 description: A Helm chart for Codefresh Runner
 name: cf-runtime
-version: 8.3.11
+version: 8.3.12
 keywords:
   - codefresh
   - runner
@@ -18,13 +18,7 @@ annotations:
   # Supported kinds: `added`, `changed`, `deprecated`, `removed`, `fixed`, `security`:
   artifacthub.io/changes: |
     - kind: changed
-      description: "Update \"dind\" to 28.3.3-3.0.3"
-    - kind: changed
-      description: "Update \"engine\" to 1.180.2"
-    - kind: fixed
-      description: "Prevent DinD containers escaping the pod cgroup on cgroup v2. Rootless DinD requires additional configuration on cgroup v2, see \"Rootless DinD\" section in docs for details."
-    - kind: fixed
-      description: "Enable legacy Prometheus metrics in the \"engine\" only if METRICS_PROMETHEUS_ENABLED=true."
+      description: "Remove sidecar container from runner deployment"
 dependencies:
   - name: cf-common
     repository: oci://quay.io/codefresh/charts

charts/cf-runtime/README.md

@@ -1,6 +1,6 @@
 ## Codefresh Runner
 
-![Version: 8.3.11](https://img.shields.io/badge/Version-8.3.11-informational?style=flat-square)
+![Version: 8.3.12](https://img.shields.io/badge/Version-8.3.12-informational?style=flat-square)
 
 Helm chart for deploying [Codefresh Runner](https://codefresh.io/docs/docs/installation/codefresh-runner/) to Kubernetes.
 
@@ -1297,7 +1297,6 @@ Install the Helm chart
 | runner.serviceAccount.annotations | object | `{}` | Additional service account annotations |
 | runner.serviceAccount.create | bool | `true` | Create service account |
 | runner.serviceAccount.name | string | `""` | Override service account name |
-| runner.sidecar | object | `{"enabled":false,"env":{"RECONCILE_INTERVAL":300},"image":{"digest":"sha256:da0c9d12b4772e6cd6c1ecb93883471e8785d4d61c9108c9f7d0dc9cc2f5a149","registry":"quay.io","repository":"codefresh/kubectl","tag":"1.33.0"},"resources":{}}` | Sidecar container Reconciles runtime spec from Codefresh API for drift detection |
 | runner.tolerations | list | `[]` | Set tolerations |
 | runner.updateStrategy | object | `{"type":"RollingUpdate"}` | Upgrade strategy |
 | runtime | object | See below | Set runtime parameters |

charts/cf-runtime/files/reconcile-runtime.sh

@@ -69,23 +69,6 @@ spec:
         volumeMounts:
           {{- toYaml . | nindent 8 }}
         {{- end }}
-      {{- if .Values.sidecar.enabled }}
-      - name: reconcile-runtime
-        image: {{ include (printf "%s.image.name" $cfCommonTplSemver ) (dict "image" .Values.sidecar.image "context" .) }}
-        imagePullPolicy: {{ .Values.sidecar.image.pullPolicy | default "IfNotPresent" }}
-        command:
-        - /bin/bash
-        args:
-        - -ec
-        - |
-          {{- .Files.Get "files/reconcile-runtime.sh" | nindent 10 }}
-        env:
-        {{- include "runner-sidecar.environment-variables" . | nindent 8 }}
-        {{- with .Values.sidecar.resources }}
-        resources:
-          {{- toYaml . | nindent 10  }}
-        {{- end }}
-      {{- end }}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

charts/cf-runtime/templates/_components/runner/_deployment.yaml

@@ -90,18 +90,6 @@ runner:
       requests:
         memory: 256Mi
         cpu: '0.2'
-  # -- Sidecar container
-  # Reconciles runtime spec from Codefresh API for drift detection
-  sidecar:
-    enabled: false
-    image:
-      registry: quay.io
-      repository: codefresh/kubectl
-      tag: 1.33.0
-      digest: sha256:da0c9d12b4772e6cd6c1ecb93883471e8785d4d61c9108c9f7d0dc9cc2f5a149
-    env:
-      RECONCILE_INTERVAL: 300
-    resources: {}
   # -- Add additional env vars
   env: {}
   # E.g.