constants

oren-codefresh · oren-codefresh · commit e24d49d9b056 · 2019-10-08T11:05:32.000+03:00
diff --git a/venonactl/cmd/install.go b/venonactl/cmd/install.go
@@ -30,6 +30,11 @@ import (
 	"github.com/spf13/viper"
 )
 
+const (
+	clusterNameMaxLength = 20
+	namespaceMaxLength = 20
+)
+
 var installCmdOptions struct {
 	dryRun                 bool
 	clusterNameInCodefresh string
@@ -219,10 +224,10 @@ func parseNodeSelector(s string) (nodeSelector, error) {
 }
 
 func validateInstallOptions(opts plugins.InstallOptions) (error)  {
-	if len(opts.ClusterName) > 20 {
+	if len(opts.ClusterName) > clusterNameMaxLength {
 		return errors.New("cluster name lenght is limited to 20")
 	}
-	if len(opts.ClusterNamespace) > 20 {
+	if len(opts.ClusterNamespace) > namespaceMaxLength {
 		return errors.New("cluster namespace is limited to 20")
 	} 	
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,11 @@ import (`
`30`	`30`	`"github.com/spf13/viper"`
`31`	`31`	`)`
`32`	`32`
	`33`	`+const (`
	`34`	`+ clusterNameMaxLength = 20`
	`35`	`+ namespaceMaxLength = 20`
	`36`	`+)`
	`37`	`+`
`33`	`38`	`var installCmdOptions struct {`
`34`	`39`	`dryRun bool`
`35`	`40`	`clusterNameInCodefresh string`
`@@ -219,10 +224,10 @@ func parseNodeSelector(s string) (nodeSelector, error) {`
`219`	`224`	`}`
`220`	`225`
`221`	`226`	`func validateInstallOptions(opts plugins.InstallOptions) (error) {`
`222`		`- if len(opts.ClusterName) > 20 {`
	`227`	`+ if len(opts.ClusterName) > clusterNameMaxLength {`
`223`	`228`	`return errors.New("cluster name lenght is limited to 20")`
`224`	`229`	`}`
`225`		`- if len(opts.ClusterNamespace) > 20 {`
	`230`	`+ if len(opts.ClusterNamespace) > namespaceMaxLength {`
`226`	`231`	`return errors.New("cluster namespace is limited to 20")`
`227`	`232`	`}`
`228`	`233`	`return nil`