Skip to content

Commit 2c31e6a

Browse files
authored
Fix release draft script (argoproj-labs#811)
1 parent f9b5d95 commit 2c31e6a

File tree

2 files changed

+33
-5
lines changed

2 files changed

+33
-5
lines changed

.github/workflows/create-release-draft.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,22 @@ jobs:
3131
run: |
3232
make release-binaries
3333
34+
- name: Setup qemu
35+
uses: docker/setup-qemu-action@v3
36+
37+
- name: Setup Docker buildx
38+
uses: docker/setup-buildx-action@v3
39+
40+
- name: Build and possibly push image
41+
run: |
42+
set -ex
43+
docker login --username "${DOCKER_USERNAME}" --password "${DOCKER_PASSWORD}" quay.io
44+
IMAGE_PUSH=yes make multiarch-image
45+
working-directory: argocd-image-updater
46+
env:
47+
DOCKER_USERNAME: ${{ secrets.QUAY_USERNAME }}
48+
DOCKER_PASSWORD: ${{ secrets.QUAY_TOKEN }}
49+
3450
- name: Create release draft
3551
id: create-release
3652
env:

hack/create-release-pr.sh

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,23 @@
44
# - install gh cli and semver-cli (go install github.com/davidrjonas/semver-cli@latest)
55
# - create and push "release-X.Y" branch
66
# - checkout this branch locally
7-
# - run this script from repo root: ./hack/create-release-pr.sh
7+
# - run this script from repo root: ./hack/create-release-pr.sh [REMOTE]
88
# - merge the PR
99
# It will trigger the release workflow that would create release draft on github
1010

11-
RELEASE_BRANCH="$(git rev-parse --abbrev-ref HEAD || true)"
1211
set -eux
1312
set -o pipefail
1413

14+
15+
CURRENT_BRANCH="$(git branch --show-current)"
16+
17+
if [[ ! "$CURRENT_BRANCH" == release-* ]]; then
18+
echo "!! Please checkout branch 'release-X.Y' (currently in branch: '${CURRENT_BRANCH}')" >&2
19+
exit 1
20+
fi
21+
22+
RELEASE_BRANCH="${CURRENT_BRANCH}"
23+
1524
### look for latest on-branch tag
1625
PREVIOUS_TAG=$(git describe --tags --abbrev=0 --match "*${RELEASE_BRANCH##release-}*" 2>/dev/null || true)
1726

@@ -26,11 +35,14 @@ echo $NEW_VERSION > VERSION
2635
IMAGE_TAG="v${NEW_VERSION}"
2736
make manifests
2837

38+
REMOTE=${1:-origin}
39+
REMOTE_URL=$(git remote get-url ${REMOTE})
40+
2941
git checkout -b "feat/new-version-${NEW_VERSION}"
3042
git commit -m "Release ${NEW_VERSION}" VERSION manifests/
31-
git push --set-upstream origin "feat/new-version-${NEW_VERSION}"
32-
gh label --repo $(git remote get-url origin) create --force release
33-
gh pr --repo $(git remote get-url origin) \
43+
git push --set-upstream ${REMOTE} "feat/new-version-${NEW_VERSION}"
44+
gh label --repo ${REMOTE_URL} create --force release
45+
gh pr --repo ${REMOTE_URL} \
3446
create \
3547
--base ${RELEASE_BRANCH} \
3648
--title "Release ${NEW_VERSION}" \

0 commit comments

Comments
 (0)