fix: Fix write-back commits (argoproj-labs#767)

Signed-off-by: jannfis <[email protected]>

Author: jannfis

Dockerfile

@@ -14,7 +14,7 @@ FROM alpine:3.19
 
 RUN apk update && \
     apk upgrade && \
-    apk add ca-certificates git openssh-client aws-cli tini && \
+    apk add ca-certificates git openssh-client aws-cli tini gpg && \
     rm -rf /var/cache/apk/*
 
 RUN mkdir -p /usr/local/bin

ext/git/writer.go

@@ -32,13 +32,21 @@ func (m *nativeGitClient) Commit(pathSpec string, opts *CommitOptions) error {
 	defaultCommitMsg := "Update parameters"
 	// Git configuration
 	config := "gpg.format=" + opts.SigningMethod
-	args := []string{"-c", config, "commit"}
+	args := []string{}
+	// -c is a global option and needs to be passed before the actual git sub
+	// command (commit).
+	if opts.SigningMethod != "" {
+		args = append(args, "-c", config)
+	}
+	args = append(args, "commit")
 	if pathSpec == "" || pathSpec == "*" {
 		args = append(args, "-a")
 	}
 	// Commit fails with a space between -S flag and path to SSH key
 	// -S/user/test/.ssh/signingKey or -SAAAAAAAA...
-	args = append(args, fmt.Sprintf("-S%s", opts.SigningKey))
+	if opts.SigningKey != "" {
+		args = append(args, fmt.Sprintf("-S%s", opts.SigningKey))
+	}
 	if opts.SignOff {
 		args = append(args, "-s")
 	}