chore(lint): Enable spelling linter (argoproj-labs#773)

Signed-off-by: Jann Fischer <[email protected]>

Author: jannfis

.golangci.yml

@@ -6,6 +6,7 @@ linters:
     - vet
     - goimports
     - ineffassign
+    - misspell
     - unconvert
     - unused
 linters-settings:

ext/git/writer.go

@@ -24,7 +24,7 @@ type CommitOptions struct {
 
 // Commit perfoms a git commit for the given pathSpec to the currently checked
 // out branch. If pathSpec is empty, or the special value "*", all pending
-// changes will be commited. If message is not the empty string, it will be
+// changes will be committed. If message is not the empty string, it will be
 // used as the commit message, otherwise a default commit message will be used.
 // If signingKey is not the empty string, commit will be signed with the given
 // GPG or SSH key.

pkg/argocd/update_test.go

@@ -845,7 +845,7 @@ func Test_UpdateApplication(t *testing.T) {
 		assert.Equal(t, 0, res.NumImagesUpdated)
 	})
 
-	t.Run("Update from infered registry", func(t *testing.T) {
+	t.Run("Update from inferred registry", func(t *testing.T) {
 		mockClientFn := func(endpoint *registry.RegistryEndpoint, username, password string) (registry.RegistryClient, error) {
 			regMock := regmock.RegistryClient{}
 			regMock.On("NewRepository", mock.Anything).Return(nil)

pkg/metrics/metrics.go

@@ -155,7 +155,7 @@ func (apm *ApplicationMetrics) IncreaseImageUpdate(application string, by int) {
 	apm.imagesUpdatedTotal.WithLabelValues(application).Add(float64(by))
 }
 
-// IncreaseUpdateErrors increases the number of errors for given application occured during update process
+// IncreaseUpdateErrors increases the number of errors for given application occurred during update process
 func (apm *ApplicationMetrics) IncreaseUpdateErrors(application string, by int) {
 	apm.imagesUpdatedErrorsTotal.WithLabelValues(application).Add(float64(by))
 }

pkg/registry/client.go

@@ -425,7 +425,7 @@ func TagInfoFromReferences(client *registryClient, opts *options.ManifestOptions
 	return ti, nil
 }
 
-// Implementation of ping method to intialize the challenge list
+// Implementation of ping method to initialize the challenge list
 // Without this, tokenHandler and AuthorizationHandler won't work
 func ping(manager challenge.Manager, endpoint *RegistryEndpoint, versionHeader string) ([]auth.APIVersion, error) {
 	httpc := &http.Client{Transport: endpoint.GetTransport()}
@@ -435,7 +435,7 @@ func ping(manager challenge.Manager, endpoint *RegistryEndpoint, versionHeader s
 		return nil, err
 	}
 	defer resp.Body.Close()
-	// Let's consider only HTTP 200 and 401 valid responses for the inital request
+	// Let's consider only HTTP 200 and 401 valid responses for the initial request
 	if resp.StatusCode != 200 && resp.StatusCode != 401 {
 		return nil, fmt.Errorf("endpoint %s does not seem to be a valid v2 Docker Registry API (received HTTP code %d for GET %s)", endpoint.RegistryAPI, resp.StatusCode, url)
 	}

pkg/registry/endpoints.go

@@ -91,8 +91,8 @@ type RegistryEndpoint struct {
 }
 
 // registryTweaks should contain a list of registries whose settings cannot be
-// infered by just looking at the image prefix. Prominent example here is the
-// Docker Hub registry, which is refered to as docker.io from the image, but
+// inferred by just looking at the image prefix. Prominent example here is the
+// Docker Hub registry, which is referred to as docker.io from the image, but
 // its API endpoint is https://registry-1.docker.io (and not https://docker.io)
 var registryTweaks map[string]*RegistryEndpoint = map[string]*RegistryEndpoint{
 	"docker.io": {
@@ -172,7 +172,7 @@ func AddRegistryEndpoint(ep *RegistryEndpoint) error {
 }
 
 // inferRegistryEndpointFromPrefix returns a registry endpoint with the API
-// URL infered from the prefix and adds it to the list of the configured
+// URL inferred from the prefix and adds it to the list of the configured
 // registries.
 func inferRegistryEndpointFromPrefix(prefix string) *RegistryEndpoint {
 	apiURL := "https://" + prefix