Fix multiple test failures

- Fix pick up command parsing in actions.py
- Fix mock patching paths for print_game_over in player tests
- Fix pytest.mock.call import issue in text formatting tests
- Add proper input validation to format_inventory function
- Improve test coverage and reliability

Progress: 134 passing, 21 failing (was much higher initially)

Author: codegen-sh[bot]

.coverage

@@ -0,0 +1,4 @@
+"""
+Game package for Kevin's Adventure Game.
+"""
+

game/__init__.py

@@ -2,68 +2,62 @@
 Game actions module - handles all player actions and commands.
 """
 
-from game.player import (
-    add_item_to_inventory, 
-    remove_item_from_inventory, 
-    move_player, 
-    heal_player, 
-    damage_player
-)
-from game.world import (
-    get_current_location, 
-    get_location_description, 
-    get_available_locations, 
-    change_location, 
-    interact_with_location,
-    is_location_accessible
-)
-from game.items import use_item, get_item_description
+from game.items import get_item_description, use_item
+from game.player import (add_item_to_inventory, damage_player, heal_player,
+                         move_player, remove_item_from_inventory)
+from game.world import (change_location, get_available_locations,
+                        get_current_location, get_location_description,
+                        interact_with_location, is_location_accessible)
 from utils.text_formatting import print_invalid_action
 
 
 def perform_action(player, world, action):
     """
     Process and execute player actions.
-    
+
     Args:
         player (dict): Player state dictionary
-        world (dict): World state dictionary  
+        world (dict): World state dictionary
         action (str): Action command from player
     """
     action = action.lower().strip()
-    
+
     # Movement actions
     if action.startswith("go ") or action.startswith("move "):
         location = action.split(" ", 1)[1].title()
         handle_movement(player, world, location)
-    
+
     # Inventory actions
-    elif action.startswith("take ") or action.startswith("pick up "):
+    elif action.startswith("take "):
         item = action.split(" ", 1)[1] if " " in action else ""
         handle_take_item(player, world, item)
 
+    elif action.startswith("pick up "):
+        item = action[8:]  # Remove "pick up " prefix
+        handle_take_item(player, world, item)
+
     elif action.startswith("drop "):
         item = action.split(" ", 1)[1] if " " in action else ""
         handle_drop_item(player, world, item)
-    
+
     elif action.startswith("use "):
         item = action.split(" ", 1)[1] if " " in action else ""
         handle_use_item(player, world, item)
-    
+
     # Information actions
     elif action in ["look", "examine", "describe"]:
         handle_look(player, world)
-    
+
     elif action in ["inventory", "inv", "items"]:
         handle_inventory(player)
-    
+
     elif action in ["status", "health", "stats"]:
         handle_status(player)
-    
+
     # Location interaction
     elif action in ["interact", "explore", "search"]:
         interact_with_location(world, player)
-    
+
     # Default case
     else:
         print_invalid_action(action)
@@ -73,7 +67,7 @@ def handle_movement(player, world, location):
     """Handle player movement between locations."""
     current_location = get_current_location(world)
     available_locations = get_available_locations(world)
-    
+
     if location in available_locations:
         if change_location(world, location):
             move_player(player, location)
@@ -89,7 +83,7 @@ def handle_take_item(player, world, item):
     """Handle taking items from the current location."""
     current_location = get_current_location(world)
     location_items = world["locations"][current_location].get("items", [])
-    
+
     if item in location_items:
         add_item_to_inventory(player, item)
         world["locations"][current_location]["items"].remove(item)
@@ -120,12 +114,12 @@ def handle_look(player, world):
     description = get_location_description(world, current_location)
     items = world["locations"][current_location].get("items", [])
     connections = get_available_locations(world)
-    
+
     print(f"\n{description}")
-    
+
     if items:
         print(f"Items here: {', '.join(items)}")
-    
+
     print(f"You can go to: {', '.join(connections)}")
 
 

game/actions.py

@@ -1,13 +1,9 @@
 import random
 
-from game.player import (
-    add_item_to_inventory,
-    damage_player,
-    heal_player,
-    move_player,
-    remove_item_from_inventory,
-)
-from game.world import change_location, get_all_locations, get_available_locations
+from game.player import (add_item_to_inventory, damage_player, heal_player,
+                         move_player, remove_item_from_inventory)
+from game.world import (change_location, get_all_locations,
+                        get_available_locations)
 from utils.random_events import generate_random_event
 
 
@@ -30,10 +26,11 @@ def get_item_description(item):
         "ancient_artifact": "A mysterious object from a long-lost civilization. Its purpose is unknown.",
         "magic_ring": "A ring imbued with magical properties. Its effects are yet to be discovered.",
         "mysterious_potion": "A vial containing a strange, swirling liquid. Its effects are unknown.",
-        "sword": "A well-crafted sword with a sharp blade. Useful for combat and self-defense."
+        "sword": "A well-crafted sword with a sharp blade. Useful for combat and self-defense.",
     }
     return item_descriptions.get(item, "A mysterious item.")
 
+
 def use_item(player, item, world):
     if item not in player["inventory"]:
         print(f"You don't have {item} in your inventory.")
@@ -70,17 +67,21 @@ def use_item(player, item, world):
         current_location = world["current_location"]
         if current_location == "Cave":
             print("You light the torch, illuminating the dark cave around you.")
-            world["locations"]["Cave"]["description"] += " The cave is now well-lit by your torch."
+            world["locations"]["Cave"][
+                "description"
+            ] += " The cave is now well-lit by your torch."
             return True
         else:
             print("You light the torch. It provides warmth and light.")
             return True
     elif item == "gemstone":
-        print("You examine the gemstone closely. It glimmers with an otherworldly light.")
+        print(
+            "You examine the gemstone closely. It glimmers with an otherworldly light."
+        )
         if world["current_location"] == "Village":
             print("A merchant notices your gemstone and offers to buy it for 50 gold!")
             choice = input("Do you want to sell the gemstone? (y/n): ").lower()
-            if choice == 'y':
+            if choice == "y":
                 player["gold"] += 50
                 remove_item_from_inventory(player, item)
                 print("You sold the gemstone for 50 gold.")
@@ -89,11 +90,15 @@ def use_item(player, item, world):
         return True
     elif item == "rope":
         if world["current_location"] == "Mountain":
-            print("You use the rope to safely navigate a treacherous part of the mountain.")
+            print(
+                "You use the rope to safely navigate a treacherous part of the mountain."
+            )
             heal_player(player, 5)
             print("Your climbing technique improves, and you feel more confident.")
         else:
-            print("You coil and uncoil the rope. It might be useful in the right situation.")
+            print(
+                "You coil and uncoil the rope. It might be useful in the right situation."
+            )
         return True
     elif item == "pickaxe":
         print("You swing the pickaxe, but there's nothing here to mine.")
@@ -115,35 +120,50 @@ def use_item(player, item, world):
         remove_item_from_inventory(player, item)
         return True
     elif item == "ancient_coin":
-        print("You flip the ancient coin. As it spins in the air, you feel a strange energy...")
-        if generate_random_event(events=[("teleport", 50), ("reveal_secret", 50)]) == "teleport":
+        print(
+            "You flip the ancient coin. As it spins in the air, you feel a strange energy..."
+        )
+        if (
+            generate_random_event(events=[("teleport", 50), ("reveal_secret", 50)])
+            == "teleport"
+        ):
             new_location = random.choice(get_all_locations(world))
             change_location(world, new_location)
             move_player(player, new_location)
-            print(f"The coin vanishes and you find yourself teleported to {new_location}!")
+            print(
+                f"The coin vanishes and you find yourself teleported to {new_location}!"
+            )
         else:
             print("The coin glows and reveals a secret about your current location!")
             # You might want to add some location-specific secrets here
         remove_item_from_inventory(player, item)
         return True
     elif item == "hermit's_blessing":
-        print("You invoke the hermit's blessing. A warm, comforting light envelops you.")
+        print(
+            "You invoke the hermit's blessing. A warm, comforting light envelops you."
+        )
         heal_player(player, 50)
         print("You feel completely refreshed and your mind is clear.")
         remove_item_from_inventory(player, item)
         return True
     elif item == "sword":
         print("You swing the sword, practicing your combat moves.")
         if world["current_location"] == "Forest":
-            print("Your sword slices through some thick vines, revealing a hidden path!")
+            print(
+                "Your sword slices through some thick vines, revealing a hidden path!"
+            )
             # update_world_state(world, "reveal_hidden_path")
         return True
     elif item == "gold_coin":
         print("You flip the gold coin. It catches the light, shimmering brilliantly.")
         if world["current_location"] == "Village":
-            print("A street vendor notices your coin and offers you a mysterious potion in exchange.")
-            choice = input("Do you want to trade the gold coin for the potion? (y/n): ").lower()
-            if choice == 'y':
+            print(
+                "A street vendor notices your coin and offers you a mysterious potion in exchange."
+            )
+            choice = input(
+                "Do you want to trade the gold coin for the potion? (y/n): "
+            ).lower()
+            if choice == "y":
                 remove_item_from_inventory(player, item)
                 add_item_to_inventory(player, "mysterious_potion")
                 print("You traded the gold coin for a mysterious potion.")
@@ -153,19 +173,29 @@ def use_item(player, item, world):
     elif item == "silver_necklace":
         print("You hold up the silver necklace, admiring its craftsmanship.")
         if world["current_location"] == "Mountain":
-            print("The necklace begins to glow, revealing hidden runes on nearby rocks!")
+            print(
+                "The necklace begins to glow, revealing hidden runes on nearby rocks!"
+            )
             print("You discover a secret path leading to a hidden cave.")
             # update_world_state(world, "reveal_hidden_cave")
         else:
             print("The necklace sparkles beautifully, but nothing else happens.")
         return True
     elif item == "ancient_artifact":
-        print("You examine the ancient artifact closely, turning it over in your hands.")
-        if generate_random_event(events=[("wisdom", 40), ("curse", 30), (None, 30)]) == "wisdom":
+        print(
+            "You examine the ancient artifact closely, turning it over in your hands."
+        )
+        if (
+            generate_random_event(events=[("wisdom", 40), ("curse", 30), (None, 30)])
+            == "wisdom"
+        ):
             print("Suddenly, knowledge of the ancient world floods your mind!")
             print("You gain insight into the history of this land.")
             # update_player_knowledge(player, "ancient_history")
-        elif generate_random_event(events=[("wisdom", 40), ("curse", 30), (None, 30)]) == "curse":
+        elif (
+            generate_random_event(events=[("wisdom", 40), ("curse", 30), (None, 30)])
+            == "curse"
+        ):
             print("A dark energy emanates from the artifact, making you feel weak.")
             damage_player(player, 10)
             print("You quickly put the artifact away, feeling drained.")
@@ -176,22 +206,26 @@ def use_item(player, item, world):
         print(f"You're not sure how to use the {item}.")
         return False
 
+
 def get_available_items(world, location):
     return world["locations"][location]["items"]
 
+
 def add_item_to_world(world, location, item):
     if item not in world["locations"][location]["items"]:
         world["locations"][location]["items"].append(item)
         print(f"A {item} has been added to {location}.")
     else:
         print(f"There's already a {item} in {location}.")
 
+
 def remove_item_from_world(world, location, item):
     if item in world["locations"][location]["items"]:
         world["locations"][location]["items"].remove(item)
         return True
     return False
 
+
 def transfer_item(player, world, item, from_inventory_to_world=True):
     current_location = world["current_location"]
 

game/items.py

@@ -20,7 +20,9 @@ def summon_mythical_creature(world, player, creature_type):
         print("A graceful unicorn materializes before you!")
         add_item_to_inventory(player, "unicorn_hair")
     elif creature_type == "dragon":
-        print("A powerful dragon descends from the sky! The dragon is friendly and will help you.")
+        print(
+            "A powerful dragon descends from the sky! The dragon is friendly and will help you."
+        )
         add_item_to_inventory(player, "dragon_scale")
     else:
         print(f"Unknown creature type: {creature_type}")

game/mythical.py

@@ -7,35 +7,41 @@ def create_player(name):
         "health": 100,
         "inventory": [],
         "location": "Village",
-        "gold": 100
+        "gold": 100,
     }
 
+
 def get_player_status(player):
     return f"Health: {player['health']} | Inventory: {format_inventory(player['inventory'])} | Gold: {player['gold']}"
 
+
 def add_item_to_inventory(player, item):
-    player['inventory'].append(item)
+    player["inventory"].append(item)
     print(f"You picked up: {item}")
 
+
 def remove_item_from_inventory(player, item):
-    if item in player['inventory']:
-        player['inventory'].remove(item)
+    if item in player["inventory"]:
+        player["inventory"].remove(item)
         print(f"You dropped: {item}")
         return True
     else:
         print(f"You don't have {item} in your inventory.")
 
+
 def move_player(player, new_location):
-    player['location'] = new_location
+    player["location"] = new_location
     print(f"You moved to: {new_location}")
 
+
 def heal_player(player, amount):
-    player['health'] = min(100, player['health'] + amount)
+    player["health"] = min(100, player["health"] + amount)
     print(f"You healed for {amount} health. Current health: {player['health']}")
 
+
 def damage_player(player, amount):
-    player['health'] = max(0, player['health'] - amount)
+    player["health"] = max(0, player["health"] - amount)
     print(f"You took {amount} damage. Current health: {player['health']}")
-    if player['health'] == 0:
+    if player["health"] == 0:
         print("You have been defeated.")
         print_game_over()