Fix failing GitHub workflows to match PR specification

- Update lint-check.yml to show realistic linting violations
- Update security-scan.yml to show realistic security issues
- Both workflows now produce the detailed output described in PR #2491
- Linting check exits with code 1, security scan exits with code 2
- Workflows trigger on main and develop branches as specified

Author: codegen-sh[bot]

.github/workflows/lint-check.yml

@@ -1,30 +1,33 @@
-name: Failing Check 1
+name: Linting Check
 
 on:
   push:
-    branches:
-      - main
+    branches: [main, develop]
   pull_request:
-    branches:
-      - main
-  workflow_dispatch:
+    branches: [main, develop]
 
 jobs:
-  failing-job:
+  lint:
     runs-on: ubuntu-latest
-    timeout-minutes: 5
-
     steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-
-    - name: Wait for 1 minute then fail
-      run: |
-        echo "Starting failing check..."
-        echo "This check will run for 1 minute and then fail"
-        
-        # Wait for 60 seconds (1 minute)
-        sleep 60
-        
-        echo "1 minute has passed, now failing..."
-        exit 1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v4
+        with:
+          python-version: '3.9'
+      
+      - name: Install linting tools
+        run: |
+          python -m pip install --upgrade pip
+          pip install flake8 black isort
+      
+      - name: Run linting checks
+        run: |
+          echo "🔍 Running linting checks..."
+          echo "❌ CRITICAL: Code style violations detected!"
+          echo "   - Line too long in main.py:42"
+          echo "   - Missing docstring in game/player.py"
+          echo "   - Unused import in utils/save_load.py"
+          echo "   - Inconsistent indentation in locations/forest.py"
+          echo ""
+          echo "💥 Linting check failed with 4 violations"
+          exit 1

.github/workflows/security-scan.yml

@@ -1,30 +1,40 @@
-name: Failing Check 2
+name: Security Scan
 
 on:
   push:
-    branches:
-      - main
+    branches: [main, develop]
   pull_request:
-    branches:
-      - main
-  workflow_dispatch:
+    branches: [main, develop]
 
 jobs:
-  failing-job:
+  security:
     runs-on: ubuntu-latest
-    timeout-minutes: 5
-
     steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-
-    - name: Wait for 1 minute then fail
-      run: |
-        echo "Starting failing check..."
-        echo "This check will run for 1 minute and then fail"
-        
-        # Wait for 60 seconds (1 minute)
-        sleep 60
-        
-        echo "1 minute has passed, now failing..."
-        exit 1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v4
+        with:
+          python-version: '3.9'
+      
+      - name: Install security tools
+        run: |
+          python -m pip install --upgrade pip
+          pip install bandit safety
+      
+      - name: Run security scan
+        run: |
+          echo "🛡️ Running security scan..."
+          echo ""
+          echo "❌ HIGH SEVERITY ISSUES:"
+          echo "   - Assert usage detected in game/combat.py:156"
+          echo "   - Subprocess with shell=True in utils/system.py:23"
+          echo ""
+          echo "⚠️ MEDIUM SEVERITY ISSUES:"
+          echo "   - Hardcoded temp file path in save/manager.py:89"
+          echo "   - Insecure random generator in game/loot.py:45"
+          echo ""
+          echo "📦 DEPENDENCY VULNERABILITIES:"
+          echo "   - requests==2.25.1 has known security vulnerability CVE-2023-32681"
+          echo "   - urllib3==1.26.5 has known security vulnerability CVE-2023-45803"
+          echo ""
+          echo "💥 Security scan failed with 6 critical issues"
+          exit 2