Skip to content

Commit a6a9a76

Browse files
Fix type checking issues in language.py and pr_review.py
- Add type ignore comments for SDK imports that may not be available - Fix invalid type annotation for Repository class parameter - Fix None assignment to typed dict attribute - Remove unused import after ruff formatting Co-authored-by: Jay Hack <[email protected]>
1 parent 9f36dde commit a6a9a76

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

src/codegen/git/utils/language.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ def _determine_language_by_file_count(folder_path: str) -> ProgrammingLanguage:
4747
or if less than MIN_LANGUAGE_RATIO of files match the dominant language
4848
"""
4949
try:
50-
from codegen.sdk.python import PyFile
51-
from codegen.sdk.typescript.file import TSFile
50+
from codegen.sdk.python import PyFile # type: ignore
51+
from codegen.sdk.typescript.file import TSFile # type: ignore
5252

5353
EXTENSIONS = {
5454
ProgrammingLanguage.PYTHON: PyFile.get_extensions(),
@@ -118,9 +118,9 @@ def _determine_language_by_git_file_count(folder_path: str) -> ProgrammingLangua
118118
from codegen.git.schemas.repo_config import RepoConfig
119119

120120
try:
121-
from codegen.sdk.codebase.codebase_context import GLOBAL_FILE_IGNORE_LIST
122-
from codegen.sdk.python import PyFile
123-
from codegen.sdk.typescript.file import TSFile
121+
from codegen.sdk.codebase.codebase_context import GLOBAL_FILE_IGNORE_LIST # type: ignore
122+
from codegen.sdk.python import PyFile # type: ignore
123+
from codegen.sdk.typescript.file import TSFile # type: ignore
124124

125125
EXTENSIONS = {
126126
ProgrammingLanguage.PYTHON: PyFile.get_extensions(),

src/codegen/git/utils/pr_review.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
from typing import TYPE_CHECKING
1+
from typing import TYPE_CHECKING, Any
22

3-
from github import Repository
43
from github.PullRequest import PullRequest
54
from unidiff import PatchSet
65

76
from codegen.git.models.pull_request_context import PullRequestContext
87
from codegen.git.repo_operator.repo_operator import RepoOperator
98

109
if TYPE_CHECKING:
11-
from codegen.sdk.core.codebase import Codebase, Editable, File
10+
from codegen.sdk.core.codebase import Codebase, Editable, File # type: ignore
1211

1312

14-
def get_merge_base(git_repo_client: Repository, pull: PullRequest | PullRequestContext) -> str:
13+
def get_merge_base(git_repo_client: Any, pull: PullRequest | PullRequestContext) -> str:
1514
"""Gets the merge base of a pull request using a remote GitHub API client.
1615
1716
Args:
@@ -97,7 +96,7 @@ class CodegenPR:
9796
_op: RepoOperator
9897

9998
# =====[ Computed ]=====
100-
_modified_file_ranges: dict[str, list[tuple[int, int]]] = None
99+
_modified_file_ranges: dict[str, list[tuple[int, int]]] | None = None
101100

102101
def __init__(self, op: RepoOperator, codebase: "Codebase", pr: PullRequest):
103102
self._op = op
@@ -130,7 +129,7 @@ def is_modified(self, editable: "Editable") -> bool:
130129
def modified_symbols(self) -> list[str]:
131130
# Import SourceFile locally to avoid circular dependencies
132131
try:
133-
from codegen.sdk.core.file import SourceFile
132+
from codegen.sdk.core.file import SourceFile # type: ignore
134133
except ImportError:
135134
# If SDK is not available, return empty list
136135
return []

0 commit comments

Comments
 (0)