update snapshot_event_handler example

Author: rushilpatel0

codegen-examples/examples/snapshot_event_handler/event_handlers.py

@@ -4,7 +4,7 @@
 from codegen.extensions.slack.types import SlackEvent
 from codegen.extensions.events.modal.base import CodebaseEventsApp, EventRouterMixin
 from codegen.extensions.github.types.pull_request import PullRequestLabeledEvent
-from pr_tasks import lint_for_dev_import_violations, review_with_codegen_agent
+from pr_tasks import lint_for_dev_import_violations
 from typing import Literal
 from dotenv import load_dotenv
 from fastapi import FastAPI, Request
@@ -85,9 +85,6 @@ def handle_pr(event: PullRequestLabeledEvent):
             # LINT CODEMOD
             lint_for_dev_import_violations(codebase, event)
 
-            # REVIEW CODEMOD
-            review_with_codegen_agent(codebase, event)
-
             return {"message": "PR event handled", "num_files": len(codebase.files), "num_functions": len(codebase.functions)}
 
         @cg.linear.event("Issue")

codegen-examples/examples/snapshot_event_handler/pr_tasks.py

@@ -10,69 +10,105 @@
 
 
 def lint_for_dev_import_violations(codebase: Codebase, event: PullRequestLabeledEvent):
+    # Next.js codemod to detect imports of the react-dev-overlay module in production code
+    
     patch, commit_shas, modified_symbols = codebase.get_modified_symbols_in_pr(event.pull_request.number)
     modified_files = set(commit_shas.keys())
+    from codegen.sdk.core.statements.if_block_statement import IfBlockStatement
 
-    DIR_NAME = "packages/next/src/client/components/react-dev-overlay"
+    DIR_NAME = 'packages/next/src/client/components/react-dev-overlay'
     directory = codebase.get_directory(DIR_NAME)
 
-    # Initialize a list to store all violations
     violations = []
 
-    print("modified_files", modified_files)
-
-    # Check if directory exists before proceeding
-    if directory is not None and hasattr(directory, "files"):
-        for file in directory.files:
-            print("checking file", file.filepath)
-            for imp in file.inbound_imports:
-                print("file", imp.file.filepath)
-                print("checking import", imp.import_statement)
-                # Check if the import is from outside the directory and is in the modified files
-                if imp.file not in directory and imp.file.filepath in modified_files:
-                    # Skip require statements
-                    if "require" in imp.import_statement:
-                        continue
-                    violation = f"- Violation in `{file.filepath}`: Importing from `{imp.file.filepath}` ([link]({imp.github_url}))"
-                    violations.append(violation)
-                    logger.info(f"Found violation: {violation}")
-
-        # Only create a PR comment if violations are found
-        if violations:
-            review_attention_message = "## Dev Import Violations Found\n\n"
-            review_attention_message += "The following files have imports that violate development overlay rules:\n\n"
-            review_attention_message += "\n".join(violations)
-            review_attention_message += "\n\nPlease ensure that development imports are not imported in production code."
-
-            # Create PR comment with the formatted message
-            codebase._op.create_pr_comment(event.pull_request.number, review_attention_message)
-
-
-def review_with_codegen_agent(codebase: Codebase, event: PullRequestLabeledEvent):
-    review_initial_message = "CodegenBot is starting to review the PR please wait..."
-    comment = codebase._op.create_pr_comment(event.number, review_initial_message)
-    # Define tools first
-    pr_tools = [
-        GithubViewPRTool(codebase),
-        GithubCreatePRCommentTool(codebase),
-        GithubCreatePRReviewCommentTool(codebase),
-    ]
-
-    # Create agent with the defined tools
-    agent = CodeAgent(codebase=codebase, tools=pr_tools)
-
-    # Using a prompt from SWE Bench
-    prompt = f"""
-    Hey CodegenBot!
-
-    Here's a SWE task for you. Please Review this pull request!
-    {event.pull_request.url}
-    Do not terminate until have reviewed the pull request and are satisfied with your review.
-
-    Review this Pull request like the señor ingenier you are
-    be explicit about the changes, produce a short summary, and point out possible improvements where pressent dont be self congratulatory stick to the facts
-    use the tools at your disposal to create propper pr reviews include code snippets if needed, and suggest improvements if feel its necesary
-    """
-    # Run the agent
-    agent.run(prompt)
-    comment.delete()
+
+    false_operators = ["!=", "!=="]
+    true_operators = ["===", "=="]
+
+
+
+    def is_valid_block_expression(if_block: IfBlockStatement) -> bool:
+        """Check if the if block has a valid environment check condition.
+        
+        Valid conditions are:
+        - process.env.NODE_ENV !== 'production'
+        - process.env.NODE_ENV != 'production'
+        - process.env.NODE_ENV === 'development'
+        - process.env.NODE_ENV == 'development'
+        """
+        if not if_block.is_if_statement:
+            return False
+            
+        condition = if_block.condition
+        # Get the operator without any whitespace
+        operator = condition.operator[-1].source
+        
+        # Check for non-production conditions
+        if operator in false_operators and condition.source == f"process.env.NODE_ENV {operator} 'production'":
+            return True
+            
+        # Check for explicit development conditions
+        if operator in true_operators and condition.source == f"process.env.NODE_ENV {operator} 'development'":
+            return True
+            
+        return False
+
+
+    def process_else_block_expression(else_block: IfBlockStatement) -> bool:
+        """Check if the else block is valid by checking its parent if block.
+        
+        Valid when the parent if block checks for production environment:
+        - if (process.env.NODE_ENV === 'production') { ... } else { <our import> }
+        - if (process.env.NODE_ENV == 'production') { ... } else { <our import> }
+        """
+        if not else_block.is_else_statement:
+            return False
+            
+        main_if = else_block._main_if_block
+        if not main_if or not main_if.condition:
+            return False
+            
+        condition = main_if.condition
+        operator = condition.operator[-1].source
+        
+        # Valid if the main if block checks for production
+        return operator in true_operators and condition.source == f"process.env.NODE_ENV {operator} 'production'"
+
+
+    for file in directory.files(recursive=True):
+        for imp in file.inbound_imports:
+
+            if imp.file.filepath not in modified_files:
+                # skip if the import is not in the pull request's modified files
+                continue
+            # Skip if the import is from within the target directory
+            if directory.dirpath in imp.file.filepath:
+                # "✅ Valid import" if the import is within the target directory
+                continue
+                
+            parent_if_block = imp.parent_of_type(IfBlockStatement)
+            
+            # Check if import is in a valid environment check block
+            if_block_valid = parent_if_block and is_valid_block_expression(parent_if_block)
+            else_block_valid = parent_if_block and process_else_block_expression(parent_if_block)
+            
+            # Skip if the import is properly guarded by environment checks
+            if if_block_valid or else_block_valid:
+                # "✅ Valid import" these are guarded by non prod checks
+                continue
+
+            # Report invalid imports that aren't properly guarded
+            violation = f"- Violation in `{file.filepath}`: Importing from `{imp.file.filepath}` ([link]({imp.github_url}))"
+            violations.append(violation)
+            logger.info(f"Found violation: {violation}")
+
+
+    if violations:
+        # Comment on PR with violations
+        review_attention_message = "## Dev Import Violations Found\n\n"
+        review_attention_message += "The following files have imports that violate development overlay rules:\n\n"
+        review_attention_message += "\n".join(violations)
+        review_attention_message += "\n\nPlease ensure that development imports are not imported in production code."
+
+        # Create PR comment with the formatted message
+        codebase._op.create_pr_comment(event.pull_request.number, review_attention_message)

src/codegen/extensions/events/modal/base.py

@@ -53,8 +53,6 @@ async def handle_event(self, org: str, repo: str, provider: Literal["slack", "gi
         Klass = self.get_event_handler_cls()
         klass = Klass(repo_org=org, repo_name=repo, commit=last_snapshot_commit)
 
-        print(f"Repo info: org: {org} repo: {repo} commit: {last_snapshot_commit}")
-        print("DEBUG: ", await request.body())
         request_payload = await request.json()
         request_headers = dict(request.headers)
         request_headers.pop("host", None)  # Remove host header if present